Completed
Pull Request — master (#361)
by Ramūnas
37:16
created
src/Oro/Bundle/FilterBundle/Form/EventListener/DateFilterSubscriber.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -157,9 +157,9 @@  discard block
 block discarded – undo
157 157
     /**
158 158
      * Call callback for each of given value, used instead of array_map to walk safely through array
159 159
      *
160
-     * @param array    $keys
160
+     * @param integer[]    $keys
161 161
      * @param array    $data
162
-     * @param callable $callback
162
+     * @param \Closure $callback
163 163
      */
164 164
     private function mapValues(array $keys, array &$data, \Closure $callback)
165 165
     {
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
      *
176 176
      * @param string $part
177 177
      *
178
-     * @return callable
178
+     * @return \Closure
179 179
      */
180 180
     private function getDatePartAccessorClosure($part)
181 181
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/FilterBundle/Grid/Extension/Configuration.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
     protected $types;
18 18
 
19 19
     /**
20
-     * @param $types
20
+     * @param integer[] $types
21 21
      */
22 22
     public function __construct($types)
23 23
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/FilterBundle/Tests/Unit/Form/Type/AbstractTypeTestCase.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
     }
80 80
 
81 81
     /**
82
-     * @return OptionsResolverInterface|\PHPUnit_Framework_MockObject_MockObject
82
+     * @return OptionsResolverInterface
83 83
      */
84 84
     protected function createMockOptionsResolver()
85 85
     {
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
     abstract protected function getTestFormType();
155 155
 
156 156
     /**
157
-     * @return array|FormExtensionInterface[]
157
+     * @return FormExtensionInterface[]
158 158
      */
159 159
     protected function getExtensions()
160 160
     {
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
      * @param string  $class
166 166
      * @param array $events
167 167
      *
168
-     * @return mixed
168
+     * @return MutableFormEventSubscriber
169 169
      */
170 170
     public function getMockSubscriber($class, array $events = [])
171 171
     {
Please login to merge, or discard this patch.
FilterBundle/Tests/Unit/Form/Type/Filter/NumberRangeFilterTypeTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
     }
57 57
 
58 58
     /**
59
-     * @return OptionsResolver|\PHPUnit_Framework_MockObject_MockObject
59
+     * @return OptionsResolver
60 60
      */
61 61
     protected function createMockOptionsResolver()
62 62
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/FormBundle/Config/BlockConfig.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
     protected $subBlocks = array();
43 43
 
44 44
     /**
45
-     * @param $code
45
+     * @param string $code
46 46
      */
47 47
     public function __construct($code)
48 48
     {
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
     }
70 70
 
71 71
     /**
72
-     * @param $code
72
+     * @param string $code
73 73
      * @return $this
74 74
      */
75 75
     public function setCode($code)
Please login to merge, or discard this patch.
src/Oro/Bundle/FormBundle/Form/Extension/JsValidationExtension.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@
 block discarded – undo
145 145
      * Gets constraint name based on object
146 146
      *
147 147
      * @param Constraint $constraint
148
-     * @return mixed|string
148
+     * @return string
149 149
      */
150 150
     protected function getConstraintName(Constraint $constraint)
151 151
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
ImportExport/Serializer/Normalizer/PrimaryItemCollectionNormalizer.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
      *
19 19
      * @param Collection $object object to normalize
20 20
      * @param mixed $format
21
-     * @param array $context
21
+     * @param string[] $context
22 22
      * @return array
23 23
      */
24 24
     public function normalize($object, $format = null, array $context = array())
@@ -41,10 +41,10 @@  discard block
 block discarded – undo
41 41
     /**
42 42
      * Denormalizes and sets primary to first element
43 43
      *
44
-     * @param mixed $data
44
+     * @param string[] $data
45 45
      * @param string $class
46 46
      * @param null $format
47
-     * @param array $context
47
+     * @param string[] $context
48 48
      * @return ArrayCollection
49 49
      */
50 50
     public function denormalize($data, $class, $format = null, array $context = array())
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/FormBundle/Model/UpdateHandler.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
     }
64 64
 
65 65
     /**
66
-     * @param object $entity
66
+     * @param \stdClass $entity
67 67
      * @param FormInterface $form
68 68
      * @param array|callable $saveAndStayRoute
69 69
      * @param array|callable $saveAndCloseRoute
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/FormBundle/Tests/Unit/Autocomplete/SearchHandlerTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -407,7 +407,7 @@
 block discarded – undo
407 407
     }
408 408
 
409 409
     /**
410
-     * @param  array $ids
410
+     * @param  integer[] $ids
411 411
      * @return Item[]
412 412
      */
413 413
     public function createMockSearchItems(array $ids)
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.