orocrm / platform

src/Oro/Bundle/SecurityBundle/ORM/Walker/OwnershipConditionDataBuilder.php

Doc Comments +4 added lines, -4 removed lines

@@ -257,7 +257,7 @@ 
     /**
      * @param OwnershipMetadataInterface $metadata
      *
-     * @return array|int|null
+     * @return integer|null
      */
     protected function getOrganizationId(OwnershipMetadataInterface $metadata = null)
     {
@@ -308,7 +308,7 @@ 
      * Adds all user ids within all business units the given user is associated
      *
      * @param int|string $userId
-     * @param int|string $organizationId
+     * @param integer|null $organizationId
      * @param array      $result [output]
      */
     protected function fillBusinessUnitUserIds($userId, $organizationId, array &$result)
@@ -328,7 +328,7 @@ 
      * Adds all user ids within all subordinate business units the given user is associated
      *
      * @param int|string $userId
-     * @param int|string $organizationId
+     * @param integer|null $organizationId
      * @param array      $result [output]
      */
     protected function fillSubordinateBusinessUnitUserIds($userId, $organizationId, array &$result)
@@ -481,7 +481,7 @@ 
      *
      * @param string $entityName
      * @param string $entityAlias
-     * @param mixed $permissions
+     * @param string $permissions
      *
      * @return array
      */

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Doctrine\Common\EventManager;
 use Doctrine\DBAL\Driver\Connection;
-
 use Symfony\Component\Filesystem\Filesystem;
-
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
 

src/Oro/Bundle/SecurityBundle/Owner/AbstractEntityOwnershipDecisionMaker.php

Doc Comments +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
     }
 
     /**
-     * @return ContainerInterface
+     * @return ContainerAwareInterface
      */
     protected function getContainer()
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/SecurityBundle/Owner/OwnerTree.php

Doc Comments +4 added lines, -4 removed lines

@@ -135,7 +135,7 @@ 
     /**
      * Gets the owning organization id for the given user id
      *
-     * @param  int|string $userId
+     * @param  string $userId
      * @return int|string|null
      */
     public function getUserOrganizationId($userId)
@@ -161,7 +161,7 @@ 
     /**
      * Gets the owning business unit id for the given user id
      *
-     * @param  int|string $userId
+     * @param  string $userId
      * @return int|string|null
      */
     public function getUserBusinessUnitId($userId)
@@ -310,8 +310,8 @@ 
     /**
      * Add the given business unit to the tree
      *
-     * @param int|string      $businessUnitId
-     * @param int|string|null $owningOrganizationId
+     * @param string      $businessUnitId
+     * @param null|string $owningOrganizationId
      *
      * @deprecated 1.8.0:2.1.0 use OwnerTree::addLocalEntity method
      */

src/Oro/Bundle/SecurityBundle/Search/AclHelper.php

Doc Comments +1 added lines, -1 removed lines

@@ -110,7 +110,7 @@
 
     /**
      * @param Query $query
-     * @param $expr
+     * @param \Oro\Bundle\SearchBundle\Query\Criteria\ExpressionBuilder $expr
      */
     protected function addOrganizationLimits(Query $query, $expr)
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/SecurityBundle/SecurityFacade.php

Doc Comments +2 added lines, -2 removed lines

@@ -300,7 +300,7 @@ 
     /**
      * Determines if object is shared with logged user.
      *
-     * @param $object
+     * @param \stdClass $object
      *
      * @return bool
      */
@@ -313,7 +313,7 @@ 
      * Determines if object is shared with given user exactly. If no UserInterface entity is passed
      * then user will be taken from current context.
      *
-     * @param $object
+     * @param \stdClass $object
      * @param UserInterface|null $user
      *
      * @return bool

Unused Use Statements -4 removed lines

@@ -4,17 +4,13 @@
 
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
-
 use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;
 use Oro\Bundle\SecurityBundle\Annotation\Acl;
 use Oro\Bundle\SecurityBundle\Authentication\Token\UsernamePasswordOrganizationToken;
-
 use Oro\Bundle\UserBundle\Entity\User;
 use Oro\Bundle\UserBundle\Entity\UserApi;
-
 use Oro\Bundle\OrganizationBundle\Entity\Manager\BusinessUnitManager;
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
 

src/Oro/Bundle/SecurityBundle/Tests/Unit/Acl/Domain/PermissionGrantingStrategyTest.php

Doc Comments +5 added lines, -2 removed lines

@@ -346,6 +346,9 @@ 
         );
     }
 
+    /**
+     * @param ObjectIdentity $oid
+     */
     protected function getAcl($oid = null, $entriesInheriting = true)
     {
         static $id = 1;
@@ -385,7 +388,7 @@ 
 
     /**
      * @param  string     $permission
-     * @param  object     $object
+     * @param  TestEntity     $object
      * @return array|null may return null if permission/object combination is not supported
      */
     private function getMasks($permission, $object)
@@ -395,7 +398,7 @@ 
 
     /**
      * @param  string      $permission
-     * @param  mixed       $object
+     * @param  TestEntity       $object
      * @return MaskBuilder
      */
     private function getMaskBuilder($permission, $object)

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/SecurityBundle/Tests/Unit/Acl/Group/ChainAclGroupProviderTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
     /**
      * @param bool $isSupports
      * @param string $group
-     * @return \PHPUnit_Framework_MockObject_MockObject|AclGroupProviderInterface
+     * @return AclGroupProviderInterface
      */
     protected function getAclGroupProviderMock($isSupports = true, $group = '')
     {

src/Oro/Bundle/SecurityBundle/Tests/Unit/Acl/Persistence/AceManipulationHelperTest.php

Doc Comments +5 added lines

@@ -436,6 +436,11 @@
         );
     }
 
+    /**
+     * @param boolean $granting
+     * @param integer $mask
+     * @param string $strategy
+     */
     private function getAce(
         $sid,
         $granting = null,

src/Oro/Bundle/SecurityBundle/Tests/Unit/Acl/Persistence/AclPrivilegeRepositoryTest.php

Doc Comments +9 added lines

@@ -352,6 +352,10 @@ 
         $this->assertFalse($p->containsKey('EDIT'));
     }
 
+    /**
+     * @param string $extensionKey
+     * @param ObjectIdentity $rootOid
+     */
     private function initSavePrivileges($extensionKey, $rootOid)
     {
         $this->extension->expects($this->any())
@@ -364,6 +368,11 @@ 
             ->method('adaptRootMask')
             ->will(
                 $this->returnCallback(
+
+                    /**
+                     * @param string $mask
+                     * @param ObjectIdentity $object
+                     */
                     function ($mask, $object) {
                         return $mask;
                     }