orocrm / platform

src/Oro/Bundle/SearchBundle/Tests/Unit/EventListener/IndexListenerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -238,7 +238,7 @@
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject
+     * @return \Doctrine\ORM\EntityManagerInterface
      */
     protected function createEntityManager()
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/SearchBundle/Tests/Unit/Formatter/ResultFormatterTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -130,7 +130,7 @@ 
      *
      * @param  string           $entityName
      * @param  array            $entities
-     * @param  array            $entityIds
+     * @param  integer[]            $entityIds
      * @return EntityRepository
      */
     protected function prepareEntityRepository($entityName, array $entities, array $entityIds)
@@ -225,7 +225,7 @@ 
     /**
      * Get list of test indexer rows
      *
-     * @return array
+     * @return Item[]
      */
     protected function getIndexerRows()
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/SearchBundle/Twig/OroSearchExtension.php

Doc Comments +2 added lines, -2 removed lines

@@ -66,8 +66,8 @@
     /**
      * Trim and highlight text by search string
      *
-     * @param     $text
-     * @param     $searchString
+     * @param     string $text
+     * @param     string $searchString
      * @param int $symbolCount
      *
      * @return string

src/Oro/Bundle/SecurityBundle/Acl/Persistence/AclManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -242,7 +242,7 @@
      *     getOid('Entity:AcmeBundle:SomeEntity')
      *     getOid('Action:Some Action')
      *
-     * @param mixed $val An domain object, object identity descriptor (id:type) or ACL annotation
+     * @param string $val An domain object, object identity descriptor (id:type) or ACL annotation
      * @return OID
      * @throws InvalidDomainObjectException
      */

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/SecurityBundle/Acl/Persistence/AclPrivilegeRepository.php

Doc Comments +4 added lines, -4 removed lines

@@ -84,7 +84,7 @@ 
      * Gets all privileges associated with the given security identity.
      *
      * @param SID $sid
-     * @return ArrayCollection|AclPrivilege[]
+     * @return ArrayCollection
      */
     public function getPrivileges(SID $sid)
     {
@@ -150,7 +150,7 @@ 
      * Associates privileges with the given security identity.
      *
      * @param SID $sid
-     * @param ArrayCollection|AclPrivilege[] $privileges
+     * @param ArrayCollection $privileges
      * @throws \RuntimeException
      *
      * @SuppressWarnings(PHPMD.NPathComplexity)
@@ -244,7 +244,7 @@ 
      * @param array $context
      * @param array $rootKeys
      * @param SID $sid
-     * @param ArrayCollection|AclPrivilege[] $privileges
+     * @param ArrayCollection $privileges
      */
     protected function initSaveContext(array &$context, array $rootKeys, SID $sid, ArrayCollection $privileges)
     {
@@ -449,7 +449,7 @@ 
      * Sorts the given privileges by name in alphabetical order.
      * The root privilege is moved at the top of the list.
      *
-     * @param ArrayCollection|AclPrivilege[] $privileges [input/output]
+     * @param ArrayCollection $privileges [input/output]
      */
     protected function sortPrivileges(ArrayCollection &$privileges)
     {

Unused Use Statements +1 added lines, -4 removed lines

@@ -2,16 +2,13 @@
 
 namespace Oro\Bundle\SecurityBundle\Acl\Persistence;
 
-use Symfony\Component\Security\Acl\Domain\ObjectIdentity;
+use Symfony\Component\Security\Acl\Domain\ObjectIdentity as OID;
 use Symfony\Component\Security\Acl\Exception\NotAllAclsFoundException;
 use Symfony\Component\Security\Acl\Model\SecurityIdentityInterface as SID;
-use Symfony\Component\Security\Acl\Domain\ObjectIdentity as OID;
 use Symfony\Component\Security\Acl\Model\EntryInterface;
 use Symfony\Component\Security\Acl\Model\AclInterface;
 use Symfony\Component\Translation\TranslatorInterface;
-
 use Doctrine\Common\Collections\ArrayCollection;
-
 use Oro\Bundle\SecurityBundle\Acl\Domain\ObjectIdentityFactory;
 use Oro\Bundle\SecurityBundle\Acl\AccessLevel;
 use Oro\Bundle\SecurityBundle\Acl\Permission\MaskBuilder;

src/Oro/Bundle/SecurityBundle/Authentication/Token/ImpersonationToken.php

Doc Comments +2 added lines, -2 removed lines

@@ -13,11 +13,11 @@
     private $organization;
 
     /**
-     * @param string|object            $user         The username (like a nickname, email address, etc.),
+     * @param \Oro\Bundle\UserBundle\Entity\User            $user         The username (like a nickname, email address, etc.),
      *                                               or a UserInterface instance
      *                                               or an object implementing a __toString method.
      * @param Organization             $organization The organization
-     * @param RoleInterface[]|string[] $roles        An array of roles
+     * @param RoleInterface[] $roles        An array of roles
      */
     public function __construct($user, Organization $organization, array $roles = [])
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/SecurityBundle/Entity/AclEntry.php

Doc Comments +1 added lines, -1 removed lines

@@ -148,7 +148,7 @@
     /**
      * Gets class
      *
-     * @return AclClass
+     * @return integer
      */
     public function getClass()
     {

src/Oro/Bundle/SecurityBundle/ORM/Walker/AclHelper.php

Doc Comments +2 added lines, -2 removed lines

@@ -162,7 +162,7 @@ 
      *
      * @param SelectStatement     $ast
      * @param AclConditionStorage $storage
-     * @param                     $permission
+     * @param                     string $permission
      */
     protected function processSubselects(SelectStatement $ast, AclConditionStorage $storage, $permission)
     {
@@ -304,7 +304,7 @@ 
      *
      * @param IdentificationVariableDeclaration $declaration
      * @param                                   $key
-     * @param                                   $permission
+     * @param                                   string $permission
      *
      * @return JoinAssociationCondition|null
      */

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Doctrine\Common\EventManager;
 use Doctrine\DBAL\Driver\Connection;
-
 use Symfony\Component\Filesystem\Filesystem;
-
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
 

src/Oro/Bundle/SecurityBundle/ORM/Walker/AclWalker.php

Doc Comments +5 added lines, -5 removed lines

@@ -158,7 +158,7 @@ 
      * work with join statements of query
      *
      * @param SelectStatement $AST
-     * @param array           $joinConditions
+     * @param Condition\JoinAclCondition[]           $joinConditions
      */
     protected function addAclToJoinClause($AST, array $joinConditions)
     {
@@ -223,7 +223,7 @@ 
      * work with "where" statement of query
      *
      * @param SelectStatement $AST
-     * @param array           $whereConditions
+     * @param AclCondition[]           $whereConditions
      */
     protected function addAclToWhereClause($AST, array $whereConditions)
     {
@@ -441,7 +441,7 @@ 
     /**
      * @param array $aclConditionalFactors
      *
-     * @return array
+     * @return ConditionalPrimary[]
      */
     protected function addShareFactor(array $aclConditionalFactors)
     {
@@ -454,7 +454,7 @@ 
     }
 
     /**
-     * @param $data
+     * @param Node $data
      *
      * @return ExistsExpression
      */
@@ -487,7 +487,7 @@ 
     /**
      * @param $data
      *
-     * @return array
+     * @return ConditionalPrimary[]
      */
     protected function buildSubselectWhereConditions($data)
     {

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Doctrine\Common\EventManager;
 use Doctrine\DBAL\Driver\Connection;
-
 use Symfony\Component\Filesystem\Filesystem;
-
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;