Completed
Pull Request — master (#364)
by Sufijen
42:35
created
src/Oro/Bundle/EmailBundle/Entity/Repository/EmailUserRepository.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@
 block discarded – undo
127 127
      *
128 128
      * @param User         $user
129 129
      * @param Organization $organization
130
-     * @return mixed
130
+     * @return QueryBuilder
131 131
      */
132 132
     public function findUnseenUserEmail(User $user, Organization $organization, $ids = [])
133 133
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/EventListener/EmailUserListener.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@
 block discarded – undo
141 141
      * Collect updated EmailUser entities
142 142
      *
143 143
      * @param $entities
144
-     * @param $uow - UnitOfWork
144
+     * @param \Doctrine\ORM\UnitOfWork $uow - UnitOfWork
145 145
      */
146 146
     protected function collectUpdatedEmailUserEntities($entities, $uow)
147 147
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Form/Handler/EmailApiHandler.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -551,8 +551,8 @@  discard block
 block discarded – undo
551 551
     }
552 552
 
553 553
     /**
554
-     * @param string[]|EmailRecipient[]|Collection $existingRecipients
555
-     * @param string[]|EmailRecipient[]|Collection $newRecipients
554
+     * @param \Doctrine\Common\Collections\ArrayCollection $existingRecipients
555
+     * @param string[] $newRecipients
556 556
      *
557 557
      * @return bool
558 558
      */
@@ -613,7 +613,7 @@  discard block
 block discarded – undo
613 613
 
614 614
     /**
615 615
      * @param string[]|string $existingRefs
616
-     * @param string[]|string $newRefs
616
+     * @param string $newRefs
617 617
      *
618 618
      * @return bool
619 619
      */
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Form/Model/Email.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
     /**
174 174
      * Set parent email id
175 175
      *
176
-     * @param $parentEmailId
176
+     * @param integer $parentEmailId
177 177
      *
178 178
      * @return $this
179 179
      */
@@ -527,7 +527,7 @@  discard block
 block discarded – undo
527 527
     /**
528 528
      * Get organization
529 529
      *
530
-     * @return OrganizationInterface
530
+     * @return OrganizationInterface|null
531 531
      */
532 532
     public function getOrganization()
533 533
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Form/Model/EmailApi.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -441,7 +441,7 @@  discard block
 block discarded – undo
441 441
     /**
442 442
      * Indicate if email is seen
443 443
      *
444
-     * @return string
444
+     * @return boolean
445 445
      */
446 446
     public function isSeen()
447 447
     {
@@ -525,7 +525,7 @@  discard block
 block discarded – undo
525 525
      *
526 526
      * @param string $xThreadId
527 527
      *
528
-     * @return Email
528
+     * @return EmailApi
529 529
      */
530 530
     public function setXThreadId($xThreadId)
531 531
     {
@@ -537,7 +537,7 @@  discard block
 block discarded – undo
537 537
     /**
538 538
      * Get thread
539 539
      *
540
-     * @return EmailThread
540
+     * @return integer
541 541
      */
542 542
     public function getThread()
543 543
     {
@@ -549,7 +549,7 @@  discard block
 block discarded – undo
549 549
      *
550 550
      * @param EmailThread|null $thread
551 551
      *
552
-     * @return Email
552
+     * @return EmailApi
553 553
      */
554 554
     public function setThread($thread)
555 555
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Form/Model/EmailAttachment.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
     }
89 89
 
90 90
     /**
91
-     * @return EmailAttachmentEntity
91
+     * @return EmailAttachment
92 92
      */
93 93
     public function getEmailAttachment()
94 94
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Mailer/DirectMailer.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@
 block discarded – undo
158 158
     /**
159 159
      * Returns a real transport used to send mails by a mailer specified in the constructor of this class
160 160
      *
161
-     * @return \Swift_Transport|null
161
+     * @return \Swift_Transport
162 162
      */
163 163
     protected function findRealTransport()
164 164
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Mailer/Processor.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -520,9 +520,9 @@
 block discarded – undo
520 520
     /**
521 521
      * Get imap origin if exists.
522 522
      *
523
-     * @param $enableUseUserEmailOrigin
524
-     * @param $emailOwner
525
-     * @param $organization
523
+     * @param boolean $enableUseUserEmailOrigin
524
+     * @param User $emailOwner
525
+     * @param OrganizationInterface|null $organization
526 526
      * @return mixed|null|InternalEmailOrigin
527 527
      */
528 528
     protected function getPreferedOrigin($enableUseUserEmailOrigin, $emailOwner, $organization)
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Manager/AutoResponseManager.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -156,9 +156,9 @@  discard block
 block discarded – undo
156 156
 
157 157
     /**
158 158
      * @param Email                         $email
159
-     * @param AutoResponseRule[]|Collection $rules
159
+     * @param Collection $rules
160 160
      *
161
-     * @return EmailModel[]|Collection
161
+     * @return Collection
162 162
      */
163 163
     protected function createReplyEmailModels(Email $email, Collection $rules)
164 164
     {
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
     }
218 218
 
219 219
     /**
220
-     * @param MailBox $mailbox
220
+     * @param Mailbox $mailbox
221 221
      * @param Email   $email
222 222
      *
223 223
      * @return AutoResponseRule[]|Collection
@@ -273,7 +273,7 @@  discard block
 block discarded – undo
273 273
 
274 274
     /**
275 275
      * @param string $field
276
-     * @param object $context
276
+     * @param Email $context
277 277
      *
278 278
      * @return string[]
279 279
      */
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -4,17 +4,13 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\HttpFoundation\JsonResponse;
6 6
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
7
-
8 7
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
9 8
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
10
-
11 9
 use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;
12 10
 use Oro\Bundle\SecurityBundle\Annotation\Acl;
13 11
 use Oro\Bundle\SecurityBundle\Authentication\Token\UsernamePasswordOrganizationToken;
14
-
15 12
 use Oro\Bundle\UserBundle\Entity\User;
16 13
 use Oro\Bundle\UserBundle\Entity\UserApi;
17
-
18 14
 use Oro\Bundle\OrganizationBundle\Entity\Manager\BusinessUnitManager;
19 15
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
20 16
 
Please login to merge, or discard this patch.