Completed
Pull Request — master (#364)
by Sufijen
42:35
created
src/Oro/Bundle/EmailBundle/Acl/Voter/EmailVoter.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@
 block discarded – undo
103 103
 
104 104
     /**
105 105
      * @param $object
106
-     * @param $objectClass
106
+     * @param string $objectClass
107 107
      *
108 108
      * @return mixed
109 109
      */
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Builder/Helper/EmailModelBuilderHelper.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -215,7 +215,7 @@  discard block
 block discarded – undo
215 215
 
216 216
     /**
217 217
      * @param EmailEntity $emailEntity
218
-     * @param             $templatePath
218
+     * @param             string|null $templatePath
219 219
      *
220 220
      * @return null|string
221 221
      */
@@ -232,8 +232,8 @@  discard block
 block discarded – undo
232 232
     }
233 233
 
234 234
     /**
235
-     * @param $prefix
236
-     * @param $subject
235
+     * @param string $prefix
236
+     * @param string $subject
237 237
      *
238 238
      * @return string
239 239
      */
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
248 248
     /**
249 249
      * @param string $entityClass
250 250
      * @param string $entityId
251
-     * @return object
251
+     * @return \Oro\Bundle\EmailBundle\Model\EmailTemplateInterface
252 252
      */
253 253
     public function getTargetEntity($entityClass, $entityId)
254 254
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Controller/Api/Rest/EmailController.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -6,12 +6,8 @@
 block discarded – undo
6 6
 use FOS\RestBundle\Controller\Annotations\RouteResource;
7 7
 use FOS\RestBundle\Controller\Annotations\QueryParam;
8 8
 use FOS\RestBundle\Controller\Annotations\Get;
9
-use FOS\RestBundle\Controller\Annotations\Delete;
10
-
11 9
 use Nelmio\ApiDocBundle\Annotation\ApiDoc;
12
-
13 10
 use Symfony\Component\HttpFoundation\Response;
14
-
15 11
 use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;
16 12
 use Oro\Bundle\SoapBundle\Controller\Api\Rest\RestController;
17 13
 use Oro\Bundle\SoapBundle\Request\Parameters\Filter\StringToArrayParameterFilter;
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Controller/Api/Rest/EmailOriginController.php 1 patch
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -6,14 +6,9 @@
 block discarded – undo
6 6
 use FOS\RestBundle\Controller\Annotations\RouteResource;
7 7
 use FOS\RestBundle\Controller\Annotations\QueryParam;
8 8
 use FOS\RestBundle\Controller\Annotations\Get;
9
-use FOS\RestBundle\Controller\Annotations\Delete;
10
-
11 9
 use Nelmio\ApiDocBundle\Annotation\ApiDoc;
12
-
13 10
 use Symfony\Component\HttpFoundation\Response;
14
-
15 11
 use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;
16
-use Oro\Bundle\SecurityBundle\SecurityFacade;
17 12
 use Oro\Bundle\SoapBundle\Controller\Api\Rest\RestGetController;
18 13
 
19 14
 /**
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Controller/EmailController.php 1 patch
Unused Use Statements   -7 removed lines patch added patch discarded remove patch
@@ -4,21 +4,14 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\ORM\EntityManager;
6 6
 use Doctrine\ORM\EntityRepository;
7
-use Doctrine\ORM\Query;
8
-
9 7
 use FOS\RestBundle\Util\Codes;
10
-
11 8
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
12 9
 use Symfony\Component\HttpFoundation\JsonResponse;
13 10
 use Symfony\Component\HttpFoundation\Request;
14 11
 use Symfony\Component\HttpFoundation\Response;
15
-use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
16 12
 use Symfony\Component\Security\Core\Exception\AccessDeniedException;
17
-
18 13
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
19 14
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
20
-
21
-use Oro\Bundle\EmailBundle\Model\WebSocket\WebSocketSendProcessor;
22 15
 use Oro\Bundle\EmailBundle\Cache\EmailCacheManager;
23 16
 use Oro\Bundle\EmailBundle\Entity\Manager\EmailManager;
24 17
 use Oro\Bundle\EmailBundle\Entity\Email;
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Entity/Mailbox.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
     }
221 221
 
222 222
     /**
223
-     * @return MailboxProcessSettings|null
223
+     * @return MailboxProcessSettings
224 224
      */
225 225
     public function getProcessSettings()
226 226
     {
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
333 333
     }
334 334
 
335 335
     /**
336
-     * @return Collection|EmailUser[]
336
+     * @return EmailUser[]
337 337
      */
338 338
     public function getEmailUsers()
339 339
     {
@@ -425,7 +425,7 @@  discard block
 block discarded – undo
425 425
     }
426 426
 
427 427
     /**
428
-     * @param AutoResponseRule[]|Collection $autoResponseRules
428
+     * @param Collection $autoResponseRules
429 429
      */
430 430
     public function setAutoResponseRules(Collection $autoResponseRules)
431 431
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Entity/Manager/EmailActivityApiEntityManager.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
     /**
44 44
      * Returns id of an email entity corresponding given criteria
45 45
      *
46
-     * @param Criteria|array $criteria
46
+     * @param Criteria $criteria
47 47
      * @param array          $joins
48 48
      *
49 49
      * @return int|null
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -3,11 +3,8 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\EmailBundle\Sync;
4 4
 
5 5
 use Doctrine\ORM\EntityManager;
6
-use Doctrine\ORM\Query;
7
-
8 6
 use Psr\Log\LoggerAwareInterface;
9 7
 use Psr\Log\LoggerAwareTrait;
10
-
11 8
 use Oro\Bundle\EmailBundle\Entity\Provider\EmailOwnerProviderStorage;
12 9
 use Oro\Bundle\EmailBundle\Entity\Manager\EmailAddressManager;
13 10
 use Oro\Bundle\EmailBundle\Tools\EmailAddressHelper;
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Entity/Manager/EmailActivityManager.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -5,9 +5,7 @@  discard block
 block discarded – undo
5 5
 use Doctrine\ORM\EntityManager;
6 6
 use Doctrine\ORM\Event\OnFlushEventArgs;
7 7
 use Doctrine\ORM\Event\PostFlushEventArgs;
8
-
9 8
 use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorage;
10
-
11 9
 use Oro\Bundle\ActivityBundle\Manager\ActivityManager;
12 10
 use Oro\Bundle\ActivityBundle\Model\ActivityInterface;
13 11
 use Oro\Bundle\EmailBundle\Entity\Email;
@@ -15,7 +13,6 @@  discard block
 block discarded – undo
15 13
 use Oro\Bundle\EmailBundle\Provider\EmailActivityListProvider;
16 14
 use Oro\Bundle\EntityConfigBundle\DependencyInjection\Utils\ServiceLink;
17 15
 use Oro\Bundle\SecurityBundle\Authentication\Token\OrganizationContextTokenInterface;
18
-use Oro\Bundle\SecurityBundle\Owner\EntityOwnerAccessor;
19 16
 
20 17
 /**
21 18
  * @SuppressWarnings(PHPMD.ExcessiveClassComplexity)
Please login to merge, or discard this patch.
EmailBundle/Entity/Manager/EmailActivitySuggestionApiEntityManager.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -11,6 +11,7 @@
 block discarded – undo
11 11
 {
12 12
     /**
13 13
      * {@inheritdoc}
14
+     * @param integer $id
14 15
      */
15 16
     public function find($id)
16 17
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,9 +3,7 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\EmailBundle\Entity\Manager;
4 4
 
5 5
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
6
-
7 6
 use Oro\Bundle\EmailBundle\Entity\Email;
8
-use Oro\Bundle\SearchBundle\Query\Result as SearchResult;
9 7
 
10 8
 class EmailActivitySuggestionApiEntityManager extends EmailActivitySearchApiEntityManager
11 9
 {
Please login to merge, or discard this patch.