Completed
Pull Request — master (#364)
by Sufijen
42:35
created
src/Oro/Bundle/DataGridBundle/Twig/DataGridExtension.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
      * Generate grid element id.
125 125
      *
126 126
      * @param DatagridInterface $grid
127
-     * @return array
127
+     * @return string
128 128
      */
129 129
     public function generateGridElementId(DatagridInterface $grid)
130 130
     {
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
      *
143 143
      * @param string $name
144 144
      * @param string $scope
145
-     * @return array
145
+     * @return string
146 146
      */
147 147
     public function buildGridFullName($name, $scope)
148 148
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/DistributionBundle/Controller/PackageController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -236,7 +236,7 @@
 block discarded – undo
236 236
     /**
237 237
      * @param array $params
238 238
      * @param string $paramName
239
-     * @param mixed $defaultValue
239
+     * @param null|false $defaultValue
240 240
      *
241 241
      * @return mixed
242 242
      */
Please login to merge, or discard this patch.
src/Oro/Bundle/DistributionBundle/Manager/PackageManager.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -199,7 +199,7 @@
 block discarded – undo
199 199
 
200 200
     /**
201 201
      * @param string $packageName
202
-     * @param mixed $version
202
+     * @param string|null $version
203 203
      *
204 204
      * @return PackageInterface
205 205
      * @throws \RuntimeException
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/DistributionBundle/OroKernel.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
     /**
82 82
      * Finds all .../Resource/config/oro/bundles.yml in given root folders
83 83
      *
84
-     * @param array $roots
84
+     * @param string[] $roots
85 85
      *
86 86
      * @return array
87 87
      */
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/DistributionBundle/Script/Runner.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -319,7 +319,7 @@
 block discarded – undo
319 319
      * @param string $commandPrefix
320 320
      * @param int $commandSize - windows shell-command is limited by 8kb
321 321
      *
322
-     * @return array of commands to be executed
322
+     * @return string[] of commands to be executed
323 323
      */
324 324
     protected function makeCommands(array $paths, $commandPrefix, $commandSize = 8000)
325 325
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/DistributionBundle/Test/PhpUnit/Helper/MockHelperTrait.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@
 block discarded – undo
5 5
 {
6 6
     /**
7 7
      * @param string $className
8
-     * @return \PHPUnit_Framework_MockObject_MockObject
8
+     * @return \Symfony\Component\Form\FormBuilderInterface
9 9
      */
10 10
     protected function createConstructorLessMock($className)
11 11
     {
Please login to merge, or discard this patch.
Oro/Bundle/DistributionBundle/Test/PhpUnit/Helper/ReflectionHelperTrait.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -5,8 +5,8 @@  discard block
 block discarded – undo
5 5
 trait ReflectionHelperTrait
6 6
 {
7 7
     /**
8
-     * @param mixed $class
9
-     * @param mixed $subclass
8
+     * @param string $class
9
+     * @param string $subclass
10 10
      */
11 11
     public function assertSubclassOf($class, $subclass)
12 12
     {
@@ -15,8 +15,8 @@  discard block
 block discarded – undo
15 15
     }
16 16
 
17 17
     /**
18
-     * @param mixed $interface
19
-     * @param mixed $class
18
+     * @param string $interface
19
+     * @param string $class
20 20
      */
21 21
     public function assertImplementsInterface($interface, $class)
22 22
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/DistributionBundle/Tests/Functional/Script/RunnerTest.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
      * @param \Composer\Package\PackageInterface $package
284 284
      * @param string $targetDir
285 285
      *
286
-     * @return \PHPUnit_Framework_MockObject_MockObject|InstallationManager
286
+     * @return InstallationManager
287 287
      */
288 288
     protected function createInstallationManagerMock(PackageInterface $package = null, $targetDir = null)
289 289
     {
@@ -299,9 +299,9 @@  discard block
 block discarded – undo
299 299
     }
300 300
 
301 301
     /**
302
-     * @param $annotationLabel
303
-     * @param $pathToFile
304
-     * @param $scriptOutput
302
+     * @param string $annotationLabel
303
+     * @param string $pathToFile
304
+     * @param string $scriptOutput
305 305
      *
306 306
      * @return string
307 307
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
DistributionBundle/Tests/Unit/Manager/Helper/ChangeSetBuilderTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 
4 4
 use Composer\Package\PackageInterface;
5 5
 use Oro\Bundle\DistributionBundle\Manager\Helper\ChangeSetBuilder;
6
-use Oro\Bundle\DistributionBundle\Test\PhpUnit\Helper\MockHelperTrait;
7 6
 
8 7
 class ChangeSetBuilderTest extends \PHPUnit_Framework_TestCase
9 8
 {
Please login to merge, or discard this patch.