orocrm / platform

src/Oro/Bundle/SoapBundle/Controller/Api/Rest/RestController.php

Doc Comments -1 removed lines

@@ -84,7 +84,6 @@
     /**
      * Create new entity
      *
-     * @param mixed $_ [optional] Arguments will be passed to createEntity method of manager (result of getManager)
      *
      * @return mixed
      */

Unused Use Statements -3 removed lines

@@ -4,16 +4,13 @@
 
 use Oro\Bundle\WorkflowBundle\Model\ContextAccessor;
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
-
 use Oro\Bundle\WorkflowBundle\Form\EventListener\DefaultValuesListener;
 use Oro\Bundle\WorkflowBundle\Form\EventListener\InitActionsListener;
 use Oro\Bundle\WorkflowBundle\Form\EventListener\RequiredAttributesListener;
 use Oro\Bundle\WorkflowBundle\Form\Type\WorkflowAttributesType;
-
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowItem;
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowStep;
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowDefinition;
-
 use Oro\Bundle\WorkflowBundle\Model\Step;
 use Oro\Bundle\WorkflowBundle\Model\Attribute;
 use Oro\Bundle\WorkflowBundle\Model\WorkflowData;

src/Oro/Bundle/SoapBundle/Controller/Api/Rest/RestGetController.php

Unused Use Statements -5 removed lines

@@ -4,21 +4,16 @@
 
 use Doctrine\ORM\QueryBuilder;
 use Nelmio\ApiDocBundle\Annotation\ApiDoc;
-
 use Oro\Bundle\SearchBundle\Event\PrepareResultItemEvent;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpFoundation\JsonResponse;
-
-use Doctrine\ORM\Query;
 use Doctrine\ORM\UnitOfWork;
 use Doctrine\ORM\Proxy\Proxy;
 use Doctrine\Common\Collections\Criteria;
-
 use FOS\RestBundle\Util\Codes;
 use FOS\RestBundle\View\View;
 use FOS\RestBundle\Controller\FOSRestController;
 use FOS\RestBundle\Request\ParamFetcherInterface;
-
 use Oro\Bundle\EntityBundle\ORM\SqlQueryBuilder;
 use Oro\Bundle\SearchBundle\Query\Query as SearchQuery;
 use Oro\Bundle\SearchBundle\Query\Result\Item as SearchResultItem;

src/Oro/Bundle/SoapBundle/Controller/Api/Soap/SoapController.php

Doc Comments -2 removed lines

@@ -29,7 +29,6 @@ 
     /**
      * Create new
      *
-     * @param mixed $_ [optional] Arguments will be passed to createEntity method
      * @return integer
      */
     public function handleCreateRequest()
@@ -43,7 +42,6 @@ 
     /**
      * Create new entity
      *
-     * @param mixed $_ [optional] Arguments will be passed to createEntity method of manager (result of getManager)
      * @return mixed
      */
     protected function createEntity()

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Doctrine\Common\EventManager;
 use Doctrine\DBAL\Driver\Connection;
-
 use Symfony\Component\Filesystem\Filesystem;
-
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
 

src/Oro/Bundle/SoapBundle/Entity/Manager/ApiEntityManager.php

Doc Comments +3 added lines, -3 removed lines

@@ -234,7 +234,7 @@ 
      * @param null  $orderBy
      * @param array $joins
      *
-     * @return QueryBuilder|SqlQueryBuilder|SearchQuery|null
+     * @return QueryBuilder
      */
     public function getListQueryBuilder($limit = 10, $page = 1, $criteria = [], $orderBy = null, $joins = [])
     {
@@ -351,7 +351,7 @@ 
      * @param array $criteria
      * @param null  $orderBy
      *
-     * @return array|Criteria
+     * @return Criteria
      */
     protected function prepareQueryCriteria($limit = 10, $page = 1, $criteria = [], $orderBy = null)
     {
@@ -399,7 +399,7 @@ 
      * Get order by
      *
      * @param $orderBy
-     * @return array|null
+     * @return string[]
      */
     protected function getOrderBy($orderBy)
     {

Unused Use Statements -3 removed lines

@@ -4,16 +4,13 @@
 
 use Oro\Bundle\WorkflowBundle\Model\ContextAccessor;
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
-
 use Oro\Bundle\WorkflowBundle\Form\EventListener\DefaultValuesListener;
 use Oro\Bundle\WorkflowBundle\Form\EventListener\InitActionsListener;
 use Oro\Bundle\WorkflowBundle\Form\EventListener\RequiredAttributesListener;
 use Oro\Bundle\WorkflowBundle\Form\Type\WorkflowAttributesType;
-
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowItem;
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowStep;
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowDefinition;
-
 use Oro\Bundle\WorkflowBundle\Model\Step;
 use Oro\Bundle\WorkflowBundle\Model\Attribute;
 use Oro\Bundle\WorkflowBundle\Model\WorkflowData;

src/Oro/Bundle/SoapBundle/Handler/Context.php

Doc Comments +1 added lines, -1 removed lines

@@ -85,7 +85,7 @@
 
     /**
      * @param string $key
-     * @param null   $default
+     * @param string   $default
      *
      * @return null
      */

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/SyncBundle/Tests/Unit/Wamp/PDO.php

Doc Comments +5 added lines

@@ -11,6 +11,11 @@
 {
     protected $query;
 
+    /**
+     * @param integer $a
+     * @param integer $b
+     * @param integer $c
+     */
     public function __construct($a, $b, $c)
     {
         $arbitrary = "nothing important here";

src/Oro/Bundle/TagBundle/Entity/TagManager.php

Unused Use Statements -3 removed lines

@@ -2,13 +2,10 @@
 
 namespace Oro\Bundle\TagBundle\Entity;
 
-use Doctrine\ORM\Query\Expr;
 use Doctrine\ORM\EntityManager;
 use Doctrine\Common\Util\ClassUtils;
 use Doctrine\Common\Collections\ArrayCollection;
-
 use Symfony\Bundle\FrameworkBundle\Routing\Router;
-
 use Oro\Bundle\SecurityBundle\SecurityFacade;
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
 use Oro\Bundle\UserBundle\Entity\User;

Doc Comments +3 added lines, -3 removed lines

@@ -124,7 +124,7 @@ 
     /**
      * Adds multiple tags on the given entity
      *
-     * @param Collection|Tag[] $tags   Array of Tag objects
+     * @param Tag[] $tags   Array of Tag objects
      * @param object           $entity entity
      */
     public function addTags($tags, $entity)
@@ -153,7 +153,7 @@ 
      *
      * @param object                 $entity
      * @param User|null              $owner
-     * @param Collection|Tag[]|int[] $tags
+     * @param Collection $tags
      *
      * @return int
      */
@@ -417,7 +417,7 @@ 
     /**
      * @param Tag $tag
      *
-     * @return callable
+     * @return \Closure
      *
      * @@deprecated
      */

src/Oro/Bundle/TagBundle/Provider/SearchProvider.php

Doc Comments +1 added lines

@@ -57,6 +57,7 @@
 
     /**
      * {@inheritdoc}
+     * @param integer $tagId
      */
     public function getResults($tagId)
     {

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Doctrine\Common\EventManager;
 use Doctrine\DBAL\Driver\Connection;
-
 use Symfony\Component\Filesystem\Filesystem;
-
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
 

src/Oro/Bundle/TagBundle/Tests/Selenium/TagsAcl.php

Doc Comments +24 added lines

@@ -127,6 +127,10 @@ 
         }
     }
 
+    /**
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
+     * @param string $role
+     */
     public function deleteAcl($login, $role, $username, $tagName)
     {
         /** @var Roles $login*/
@@ -143,6 +147,10 @@ 
             ->checkContextMenu($tagName, 'Delete');
     }
 
+    /**
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
+     * @param string $role
+     */
     public function updateAcl($login, $role, $username, $tagName)
     {
         /** @var Roles $login*/
@@ -159,6 +167,10 @@ 
             ->checkContextMenu($tagName, 'Update');
     }
 
+    /**
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
+     * @param string $role
+     */
     public function createAcl($login, $role, $username)
     {
         /** @var Roles $login*/
@@ -175,6 +187,10 @@ 
             ->assertElementNotPresent("//div[@class = 'container-fluid']//a[contains(., 'Create Tag')]");
     }
 
+    /**
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
+     * @param string $role
+     */
     public function viewListAcl($login, $role, $username)
     {
         /** @var Roles $login*/
@@ -191,6 +207,10 @@ 
             ->assertTitle('403 - Forbidden');
     }
 
+    /**
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
+     * @param string $roleName
+     */
     public function unassignGlobalAcl($login, $roleName, $tagName)
     {
         $username = 'user' . mt_rand();
@@ -229,6 +249,10 @@ 
             );
     }
 
+    /**
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
+     * @param string $role
+     */
     public function assignAcl($login, $role, $username)
     {
         /** @var Roles $login*/