Completed
Pull Request — master (#364)
by Sufijen
42:35
created
src/Oro/Bundle/ImapBundle/Manager/ImapEmailManager.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -295,7 +295,7 @@
 block discarded – undo
295 295
 
296 296
     /**
297 297
      * @param Headers $headers
298
-     * @param $name
298
+     * @param string $name
299 299
      * @return array|null
300 300
      */
301 301
     protected function getMultiMessageId(Headers $headers, $name)
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/ImapBundle/Sync/ImapEmailSynchronizationProcessor.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -456,7 +456,7 @@
 block discarded – undo
456 456
      * Check allowing to save email by uid
457 457
      *
458 458
      * @param Email $email
459
-     * @param array $existingUids
459
+     * @param integer[] $existingUids
460 460
      *
461 461
      * @return bool
462 462
      */
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -5,8 +5,6 @@  discard block
 block discarded – undo
5 5
 use Doctrine\Common\Collections\ArrayCollection;
6 6
 use Doctrine\ORM\EntityManager;
7 7
 use Doctrine\ORM\Query;
8
-
9
-
10 8
 use Oro\Bundle\EmailBundle\Entity\Mailbox;
11 9
 use Oro\Bundle\EmailBundle\Model\FolderType;
12 10
 use Oro\Bundle\EmailBundle\Builder\EmailEntityBuilder;
@@ -15,7 +13,6 @@  discard block
 block discarded – undo
15 13
 use Oro\Bundle\EmailBundle\Entity\EmailOrigin;
16 14
 use Oro\Bundle\EmailBundle\Sync\AbstractEmailSynchronizationProcessor;
17 15
 use Oro\Bundle\EmailBundle\Sync\KnownEmailAddressCheckerInterface;
18
-
19 16
 use Oro\Bundle\ImapBundle\Entity\ImapEmail;
20 17
 use Oro\Bundle\ImapBundle\Entity\ImapEmailFolder;
21 18
 use Oro\Bundle\ImapBundle\Entity\Repository\ImapEmailFolderRepository;
@@ -23,7 +20,6 @@  discard block
 block discarded – undo
23 20
 use Oro\Bundle\ImapBundle\Mail\Storage\Exception\UnsupportException;
24 21
 use Oro\Bundle\ImapBundle\Mail\Storage\Exception\UnselectableFolderException;
25 22
 use Oro\Bundle\ImapBundle\Mail\Storage\Folder;
26
-use Oro\Bundle\ImapBundle\Mail\Storage\Imap;
27 23
 use Oro\Bundle\ImapBundle\Manager\ImapEmailIterator;
28 24
 use Oro\Bundle\ImapBundle\Manager\ImapEmailManager;
29 25
 use Oro\Bundle\ImapBundle\Manager\DTO\Email;
Please login to merge, or discard this patch.
DependencyInjection/Compiler/ProcessorRegistryCompilerPass.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
      * @param string $serviceId
75 75
      * @param string $tagName
76 76
      * @param array $tagAttributes
77
-     * @param array $requiredAttributes
77
+     * @param string[] $requiredAttributes
78 78
      * @throws LogicException
79 79
      */
80 80
     private function assertTagHasAttributes($serviceId, $tagName, array $tagAttributes, array $requiredAttributes)
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\DependencyInjection\ContainerBuilder;
6 6
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
7
-use Symfony\Component\DependencyInjection\Definition;
8 7
 use Symfony\Component\DependencyInjection\Reference;
9 8
 use Symfony\Component\DependencyInjection\Exception\LogicException;
10 9
 
Please login to merge, or discard this patch.
src/Oro/Bundle/ImportExportBundle/Field/DatabaseHelper.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
     }
143 143
 
144 144
     /**
145
-     * @param object $entity
145
+     * @param \stdClass $entity
146 146
      * @return object
147 147
      */
148 148
     public function getEntityReference($entity)
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
     /**
288 288
      * We should limit data with current organization
289 289
      *
290
-     * @param $entityName
290
+     * @param string $entityName
291 291
      * @return bool
292 292
      */
293 293
     protected function shouldBeAddedOrganizationLimits($entityName)
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/ImportExportBundle/Formatter/ExcelDateTimeTypeFormatter.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -96,6 +96,9 @@
 block discarded – undo
96 96
 
97 97
     /**
98 98
      * {@inheritdoc}
99
+     * @param integer $dateType
100
+     * @param integer $timeType
101
+     * @param string $locale
99 102
      */
100 103
     public function getPattern($dateType, $timeType, $locale = null)
101 104
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/ImportExportBundle/Handler/AbstractImportHandler.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -132,10 +132,10 @@
 block discarded – undo
132 132
     }
133 133
 
134 134
     /**
135
-     * @param $jobName
136
-     * @param $processorAlias
137
-     * @param $inputFormat
138
-     * @param $inputFilePrefix
135
+     * @param string $jobName
136
+     * @param string $processorAlias
137
+     * @param string $inputFormat
138
+     * @param string $inputFilePrefix
139 139
      * @param array $options
140 140
      * @param $entityName
141 141
      * @return JobResult
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/ImportExportBundle/Handler/ExportHandler.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -148,7 +148,7 @@
 block discarded – undo
148 148
     /**
149 149
      * Handles download export file action
150 150
      *
151
-     * @param $fileName
151
+     * @param string $fileName
152 152
      * @return Response
153 153
      */
154 154
     public function handleDownloadExportResult($fileName)
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
Serializer/Normalizer/AbstractContextModeAwareNormalizer.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -16,6 +16,9 @@
 block discarded – undo
16 16
      */
17 17
     protected $defaultMode = null;
18 18
 
19
+    /**
20
+     * @param string $defaultMode
21
+     */
19 22
     public function __construct(array $availableModes, $defaultMode = null)
20 23
     {
21 24
         $this->setAvailableModes($availableModes);
Please login to merge, or discard this patch.
Bundle/ImportExportBundle/Serializer/Normalizer/CollectionNormalizer.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
      *
40 40
      * @param Collection $object object to normalize
41 41
      * @param mixed $format
42
-     * @param array $context
42
+     * @param string[] $context
43 43
      * @return array
44 44
      */
45 45
     public function normalize($object, $format = null, array $context = array())
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.