Completed
Pull Request — 1.8 (#365)
by Sufijen
506:56 queued 431:47
created
src/Oro/Bundle/EmailBundle/Controller/Api/Rest/EmailOriginController.php 1 patch
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -6,14 +6,9 @@
 block discarded – undo
6 6
 use FOS\RestBundle\Controller\Annotations\RouteResource;
7 7
 use FOS\RestBundle\Controller\Annotations\QueryParam;
8 8
 use FOS\RestBundle\Controller\Annotations\Get;
9
-use FOS\RestBundle\Controller\Annotations\Delete;
10
-
11 9
 use Nelmio\ApiDocBundle\Annotation\ApiDoc;
12
-
13 10
 use Symfony\Component\HttpFoundation\Response;
14
-
15 11
 use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;
16
-use Oro\Bundle\SecurityBundle\SecurityFacade;
17 12
 use Oro\Bundle\SoapBundle\Controller\Api\Rest\RestGetController;
18 13
 
19 14
 /**
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Entity/Mailbox.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -220,7 +220,7 @@  discard block
 block discarded – undo
220 220
     }
221 221
 
222 222
     /**
223
-     * @return MailboxProcessSettings|null
223
+     * @return MailboxProcessSettings
224 224
      */
225 225
     public function getProcessSettings()
226 226
     {
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
333 333
     }
334 334
 
335 335
     /**
336
-     * @return Collection|EmailUser[]
336
+     * @return EmailUser[]
337 337
      */
338 338
     public function getEmailUsers()
339 339
     {
@@ -425,7 +425,7 @@  discard block
 block discarded – undo
425 425
     }
426 426
 
427 427
     /**
428
-     * @param AutoResponseRule[]|Collection $autoResponseRules
428
+     * @param Collection $autoResponseRules
429 429
      */
430 430
     public function setAutoResponseRules(Collection $autoResponseRules)
431 431
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Entity/Manager/EmailActivityApiEntityManager.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
     /**
44 44
      * Returns id of an email entity corresponding given criteria
45 45
      *
46
-     * @param Criteria|array $criteria
46
+     * @param Criteria $criteria
47 47
      * @param array          $joins
48 48
      *
49 49
      * @return int|null
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -3,11 +3,8 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\EmailBundle\Sync;
4 4
 
5 5
 use Doctrine\ORM\EntityManager;
6
-use Doctrine\ORM\Query;
7
-
8 6
 use Psr\Log\LoggerAwareInterface;
9 7
 use Psr\Log\LoggerAwareTrait;
10
-
11 8
 use Oro\Bundle\EmailBundle\Entity\Provider\EmailOwnerProviderStorage;
12 9
 use Oro\Bundle\EmailBundle\Entity\Manager\EmailAddressManager;
13 10
 use Oro\Bundle\EmailBundle\Tools\EmailAddressHelper;
Please login to merge, or discard this patch.
EmailBundle/Entity/Manager/EmailActivitySuggestionApiEntityManager.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -11,6 +11,7 @@
 block discarded – undo
11 11
 {
12 12
     /**
13 13
      * {@inheritdoc}
14
+     * @param integer $id
14 15
      */
15 16
     public function find($id)
16 17
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,9 +3,7 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\EmailBundle\Entity\Manager;
4 4
 
5 5
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
6
-
7 6
 use Oro\Bundle\EmailBundle\Entity\Email;
8
-use Oro\Bundle\SearchBundle\Query\Result as SearchResult;
9 7
 
10 8
 class EmailActivitySuggestionApiEntityManager extends EmailActivitySearchApiEntityManager
11 9
 {
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Entity/Repository/EmailRecipientRepository.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
     }
43 43
 
44 44
     /**
45
-     * @param array $senderEmails
45
+     * @param integer[] $senderEmails
46 46
      * @param array $excludedEmails
47 47
      * @param string|null $query
48 48
      *
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Entity/Repository/EmailUserRepository.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@
 block discarded – undo
127 127
      *
128 128
      * @param User         $user
129 129
      * @param Organization $organization
130
-     * @return mixed
130
+     * @return QueryBuilder
131 131
      */
132 132
     public function findUnseenUserEmail(User $user, Organization $organization, $ids = [])
133 133
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/EventListener/EmailUserListener.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -141,7 +141,7 @@
 block discarded – undo
141 141
      * Collect updated EmailUser entities
142 142
      *
143 143
      * @param $entities
144
-     * @param $uow - UnitOfWork
144
+     * @param \Doctrine\ORM\UnitOfWork $uow - UnitOfWork
145 145
      */
146 146
     protected function collectUpdatedEmailUserEntities($entities, $uow)
147 147
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,8 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\EmailBundle\EventListener;
4 4
 
5 5
 use Doctrine\ORM\Event\OnFlushEventArgs;
6
-use Doctrine\ORM\Event\PostFlushEventArgs;
7
-
8 6
 use Oro\Bundle\EmailBundle\Model\WebSocket\WebSocketSendProcessor;
9 7
 use Oro\Bundle\EmailBundle\Entity\EmailUser;
10 8
 
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Form/Handler/EmailApiHandler.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -551,8 +551,8 @@  discard block
 block discarded – undo
551 551
     }
552 552
 
553 553
     /**
554
-     * @param string[]|EmailRecipient[]|Collection $existingRecipients
555
-     * @param string[]|EmailRecipient[]|Collection $newRecipients
554
+     * @param \Doctrine\Common\Collections\ArrayCollection $existingRecipients
555
+     * @param string[] $newRecipients
556 556
      *
557 557
      * @return bool
558 558
      */
@@ -613,7 +613,7 @@  discard block
 block discarded – undo
613 613
 
614 614
     /**
615 615
      * @param string[]|string $existingRefs
616
-     * @param string[]|string $newRefs
616
+     * @param string $newRefs
617 617
      *
618 618
      * @return bool
619 619
      */
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Form/Model/Email.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
     /**
174 174
      * Set parent email id
175 175
      *
176
-     * @param $parentEmailId
176
+     * @param integer $parentEmailId
177 177
      *
178 178
      * @return $this
179 179
      */
@@ -527,7 +527,7 @@  discard block
 block discarded – undo
527 527
     /**
528 528
      * Get organization
529 529
      *
530
-     * @return OrganizationInterface
530
+     * @return OrganizationInterface|null
531 531
      */
532 532
     public function getOrganization()
533 533
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.