Completed
Pull Request — master (#337)
by Ivan
39:35
created
Oro/Bundle/EntityConfigBundle/EventListener/AbstractConfigGridListener.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -262,7 +262,7 @@  discard block
 block discarded – undo
262 262
 
263 263
     /**
264 264
      * @param DatagridConfiguration $config
265
-     * @param                       $itemType
265
+     * @param                       string|null $itemType
266 266
      */
267 267
     protected function addEntityConfigProperties(DatagridConfiguration $config, $itemType)
268 268
     {
@@ -321,7 +321,7 @@  discard block
 block discarded – undo
321 321
      * @param array $filters
322 322
      * @param array $actions
323 323
      *
324
-     * @return callable
324
+     * @return \Closure
325 325
      */
326 326
     public function getActionConfigurationClosure($filters, $actions)
327 327
     {
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -4,17 +4,13 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\HttpFoundation\JsonResponse;
6 6
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
7
-
8 7
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
9 8
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
10
-
11 9
 use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;
12 10
 use Oro\Bundle\SecurityBundle\Annotation\Acl;
13 11
 use Oro\Bundle\SecurityBundle\Authentication\Token\UsernamePasswordOrganizationToken;
14
-
15 12
 use Oro\Bundle\UserBundle\Entity\User;
16 13
 use Oro\Bundle\UserBundle\Entity\UserApi;
17
-
18 14
 use Oro\Bundle\OrganizationBundle\Entity\Manager\BusinessUnitManager;
19 15
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
20 16
 
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityConfigBundle/Form/Type/ConfigScopeType.php 2 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -218,6 +218,9 @@  discard block
 block discarded – undo
218 218
         return $values;
219 219
     }
220 220
 
221
+    /**
222
+     * @param string $cssClass
223
+     */
221 224
     protected function appendClassAttr(array &$options, $cssClass)
222 225
     {
223 226
         if (isset($options['attr']['class'])) {
@@ -227,6 +230,9 @@  discard block
 block discarded – undo
227 230
         }
228 231
     }
229 232
 
233
+    /**
234
+     * @param string $name
235
+     */
230 236
     protected function setAttr(array &$options, $name, $value)
231 237
     {
232 238
         if (!isset($options['attr'])) {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
EntityConfigBundle/ImportExport/Strategy/EntityFieldImportStrategy.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
     /**
108 108
      * @param FieldConfigModel $entity
109 109
      * @param array $searchContext
110
-     * @return null|FieldConfigModel
110
+     * @return FieldConfigModel
111 111
      */
112 112
     protected function findExistingEntity($entity, array $searchContext = [])
113 113
     {
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 
120 120
     /**
121 121
      * @param FieldConfigModel $entity
122
-     * @return null|FieldConfigModel
122
+     * @return FieldConfigModel
123 123
      */
124 124
     protected function validateAndUpdateContext(FieldConfigModel $entity)
125 125
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityConfigBundle/Migration/RemoveEnumFieldQuery.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -119,7 +119,7 @@
 block discarded – undo
119 119
 
120 120
     /**
121 121
      * @param LoggerInterface $logger
122
-     * @param $sql
122
+     * @param string $sql
123 123
      * @param array $parameters
124 124
      * @throws \Doctrine\DBAL\DBALException
125 125
      */
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityConfigBundle/Provider/ConfigProvider.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -196,7 +196,7 @@
 block discarded – undo
196 196
      * Applies the callback to configuration data to all configurable entities (if $className is not specified)
197 197
      * or all configurable fields of the given entity.
198 198
      *
199
-     * @param callable    $callback The callback function to run for configuration data for each object
199
+     * @param \Closure    $callback The callback function to run for configuration data for each object
200 200
      * @param string|null $className
201 201
      * @param bool        $withHidden
202 202
      *
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
Tests/Unit/ImportExport/Strategy/EntityFieldImportStrategyTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -186,7 +186,7 @@
 block discarded – undo
186 186
     }
187 187
 
188 188
     /**
189
-     * @param object $object
189
+     * @param EntityFieldImportStrategy $object
190 190
      * @param string $property
191 191
      * @return mixed $value
192 192
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityConfigBundle/Tools/ConfigHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
      *
95 95
      * @param string $className
96 96
      *
97
-     * @return array [$moduleName, $entityName]
97
+     * @return string[] [$moduleName, $entityName]
98 98
      */
99 99
     public static function getModuleAndEntityNames($className)
100 100
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityConfigBundle/Tools/ConfigLoader.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
      * Load entity configs from annotations to a database
38 38
      *
39 39
      * @param bool                 $force  Force overwrite config's option values
40
-     * @param callable|null        $filter function (ClassMetadata[] $doctrineAllMetadata)
40
+     * @param null|\Closure        $filter function (ClassMetadata[] $doctrineAllMetadata)
41 41
      * @param LoggerInterface|null $logger
42 42
      * @param bool                 $dryRun Log modifications without apply them
43 43
      *
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityExtendBundle/Entity/Manager/AssociationManager.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
      * @param string $attribute The name of the entity config attribute which indicates
104 104
      *                          whether the association is enabled or not
105 105
      *
106
-     * @return callable
106
+     * @return \Closure
107 107
      */
108 108
     public function getSingleOwnerFilter($scope, $attribute = 'enabled')
109 109
     {
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
      * @param string $attribute The name of the entity config attribute which is used to store
122 122
      *                          enabled associations
123 123
      *
124
-     * @return callable
124
+     * @return \Closure
125 125
      */
126 126
     public function getMultiOwnerFilter($scope, $attribute)
127 127
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.