Completed
Pull Request — master (#337)
by Ivan
36:14
created
Tests/Functional/Controller/Api/Rest/WorkflowControllerTest.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -211,6 +211,7 @@
 block discarded – undo
211 211
     /**
212 212
      * @param string
213 213
      * @param string|null $workflowName
214
+     * @param string $entityClass
214 215
      */
215 216
     protected function assertActiveWorkflow($entityClass, $workflowName)
216 217
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
Oro/Bundle/WorkflowBundle/Tests/Unit/Acl/Voter/WorkflowEntityVoterTest.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -232,10 +232,10 @@
 block discarded – undo
232 232
     }
233 233
 
234 234
     /**
235
-     * @param array $entityAcls
235
+     * @param WorkflowEntityAcl[] $entityAcls
236 236
      * @param string|null $entityClass
237 237
      * @param int|null $entityIdentifier
238
-     * @param array $aclIdentities
238
+     * @param WorkflowEntityAclIdentity[] $aclIdentities
239 239
      */
240 240
     protected function setRegistryRepositories(
241 241
         array $entityAcls = [],
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
Tests/Unit/EventListener/WorkflowDataSerializeListenerTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -193,7 +193,7 @@
 block discarded – undo
193 193
 
194 194
     /**
195 195
      * @param array $uowExpectedCalls
196
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Doctrine\ORM\EntityManager
196
+     * @return \Doctrine\ORM\EntityManagerInterface
197 197
      */
198 198
     protected function getPostFlushEntityManagerMock(array $uowExpectedCalls)
199 199
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
Tests/Unit/Form/Type/AbstractWorkflowAttributesTypeTestCase.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,16 +4,13 @@
 block discarded – undo
4 4
 
5 5
 use Oro\Bundle\WorkflowBundle\Model\ContextAccessor;
6 6
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
7
-
8 7
 use Oro\Bundle\WorkflowBundle\Form\EventListener\DefaultValuesListener;
9 8
 use Oro\Bundle\WorkflowBundle\Form\EventListener\InitActionsListener;
10 9
 use Oro\Bundle\WorkflowBundle\Form\EventListener\RequiredAttributesListener;
11 10
 use Oro\Bundle\WorkflowBundle\Form\Type\WorkflowAttributesType;
12
-
13 11
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowItem;
14 12
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowStep;
15 13
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowDefinition;
16
-
17 14
 use Oro\Bundle\WorkflowBundle\Model\Step;
18 15
 use Oro\Bundle\WorkflowBundle\Model\Attribute;
19 16
 use Oro\Bundle\WorkflowBundle\Model\WorkflowData;
Please login to merge, or discard this patch.
src/Oro/Bundle/WorkflowBundle/Tests/Unit/Model/Action/TreeExecutorTest.php 1 patch
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -117,6 +117,9 @@  discard block
 block discarded – undo
117 117
         $listAction->execute(array());
118 118
     }
119 119
 
120
+    /**
121
+     * @return \Oro\Bundle\WorkflowBundle\Model\Action\ActionInterface
122
+     */
120 123
     protected function getExceptionAction()
121 124
     {
122 125
         $action = $this->getMockBuilder('Oro\Bundle\WorkflowBundle\Model\Action\ActionInterface')
@@ -127,6 +130,10 @@  discard block
 block discarded – undo
127 130
             ->method('execute')
128 131
             ->will(
129 132
                 $this->returnCallback(
133
+
134
+                    /**
135
+                     * @return \Oro\Bundle\WorkflowBundle\Model\Action\ActionInterface
136
+                     */
130 137
                     function () {
131 138
                         throw new \Exception('TEST');
132 139
                     }
Please login to merge, or discard this patch.
src/Oro/Bundle/WorkflowBundle/Tests/Unit/Model/AttributeAssemblerTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
     }
36 36
 
37 37
     /**
38
-     * @return \PHPUnit_Framework_MockObject_MockObject
38
+     * @return \Oro\Bundle\WorkflowBundle\Model\AttributeGuesser
39 39
      */
40 40
     protected function getAttributeGuesser()
41 41
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/WorkflowBundle/Tests/Unit/Model/TransitionAssemblerTest.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -317,7 +317,7 @@
 block discarded – undo
317 317
     /**
318 318
      * @param string $templateType
319 319
      * @param array $configuration
320
-     * @param $actualTransition
320
+     * @param Transition $actualTransition
321 321
      */
322 322
     protected function assertTemplate($templateType, $configuration, $actualTransition)
323 323
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/WorkflowBundle/Tests/Unit/Model/TransitionManagerTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -58,6 +58,9 @@
 block discarded – undo
58 58
         $this->assertEquals($expected, $transitions->toArray());
59 59
     }
60 60
 
61
+    /**
62
+     * @param string $name
63
+     */
61 64
     protected function getTransitionMock($name, $isStart = false, $step = null)
62 65
     {
63 66
         $transition = $this->getMockBuilder('Oro\Bundle\WorkflowBundle\Model\Transition')
Please login to merge, or discard this patch.
src/Oro/Bundle/WorkflowBundle/Tests/Unit/Model/WorkflowManagerTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -891,7 +891,7 @@
 block discarded – undo
891 891
      * @param string $name
892 892
      * @param array $entityAttributes
893 893
      * @param array $startTransitions
894
-     * @return Workflow|\PHPUnit_Framework_MockObject_MockObject
894
+     * @return Workflow
895 895
      */
896 896
     protected function createWorkflow(
897 897
         $name = self::TEST_WORKFLOW_NAME,
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.