Completed
Pull Request — master (#377)
by Ivan
33:41
created
src/Oro/Bundle/FormBundle/Tests/Unit/Model/UpdateHandlerTest.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
     }
77 77
 
78 78
     /**
79
-     * @return object
79
+     * @return \stdClass
80 80
      */
81 81
     protected function getObject()
82 82
     {
@@ -492,7 +492,7 @@  discard block
 block discarded – undo
492 492
 
493 493
     /**
494 494
      * @param \PHPUnit_Framework_MockObject_MockObject|Form $form
495
-     * @param object $entity
495
+     * @param \stdClass $entity
496 496
      * @param string $wid
497 497
      * @return array
498 498
      */
@@ -518,7 +518,7 @@  discard block
 block discarded – undo
518 518
 
519 519
     /**
520 520
      * @param FormInterface $form
521
-     * @param object $entity
521
+     * @param \stdClass $entity
522 522
      */
523 523
     protected function assertProcessEventsTriggered(FormInterface $form, $entity)
524 524
     {
@@ -533,7 +533,7 @@  discard block
 block discarded – undo
533 533
 
534 534
     /**
535 535
      * @param FormInterface $form
536
-     * @param object $entity
536
+     * @param \stdClass $entity
537 537
      */
538 538
     protected function assertProcessAfterEventsTriggered(FormInterface $form, $entity)
539 539
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/FormBundle/Utils/FormUtils.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
      * Appends CSS class(es) to given form view
42 42
      *
43 43
      * @param FormView $view
44
-     * @param string|[]   $cssClass
44
+     * @param string|[]   $cssClasses
45 45
      */
46 46
     public static function appendClass(FormView $view, $cssClasses)
47 47
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/HelpBundle/DependencyInjection/ApplicationConfiguration.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,8 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\HelpBundle\DependencyInjection;
4 4
 
5 5
 use Symfony\Component\Config\Definition\Builder\TreeBuilder;
6
-use Symfony\Component\Config\Definition\ConfigurationInterface;
7
-use Symfony\Component\Config\Definition\Exception\InvalidConfigurationException;
8 6
 
9 7
 class ApplicationConfiguration extends AbstractConfiguration
10 8
 {
Please login to merge, or discard this patch.
src/Oro/Bundle/ImapBundle/Connector/ImapConnector.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -137,7 +137,7 @@
 block discarded – undo
137 137
     }
138 138
 
139 139
     /**
140
-     * @param null $query
140
+     * @param string $query
141 141
      *
142 142
      * @return mixed
143 143
      */
Please login to merge, or discard this patch.
src/Oro/Bundle/ImapBundle/Connector/Search/AbstractSearchStringManager.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
 
98 98
     /**
99 99
      * @param string $itemName The property name
100
-     * @param mixed $itemValue A constant the property value is compared
100
+     * @param string $itemValue A constant the property value is compared
101 101
      * @param int $match The match type. One of SearchQueryMatch::* values
102 102
      * @return string
103 103
      * @throws \InvalidArgumentException
@@ -156,7 +156,7 @@  discard block
 block discarded – undo
156 156
     /**
157 157
      * Returns a string represents the given date in format required for search query criterion.
158 158
      *
159
-     * @param mixed $value
159
+     * @param \DateTime $value
160 160
      * @return string
161 161
      */
162 162
     abstract protected function formatDate($value);
Please login to merge, or discard this patch.
src/Oro/Bundle/ImapBundle/Controller/ConnectionController.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -129,7 +129,7 @@
 block discarded – undo
129 129
     /**
130 130
      * @param int|null $id
131 131
      *
132
-     * @return Organization|null
132
+     * @return null|\Oro\Bundle\OrganizationBundle\Entity\OrganizationInterface
133 133
      */
134 134
     protected function getOrganization($id)
135 135
     {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,16 +4,13 @@
 block discarded – undo
4 4
 
5 5
 use Oro\Bundle\WorkflowBundle\Model\ContextAccessor;
6 6
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
7
-
8 7
 use Oro\Bundle\WorkflowBundle\Form\EventListener\DefaultValuesListener;
9 8
 use Oro\Bundle\WorkflowBundle\Form\EventListener\InitActionsListener;
10 9
 use Oro\Bundle\WorkflowBundle\Form\EventListener\RequiredAttributesListener;
11 10
 use Oro\Bundle\WorkflowBundle\Form\Type\WorkflowAttributesType;
12
-
13 11
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowItem;
14 12
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowStep;
15 13
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowDefinition;
16
-
17 14
 use Oro\Bundle\WorkflowBundle\Model\Step;
18 15
 use Oro\Bundle\WorkflowBundle\Model\Attribute;
19 16
 use Oro\Bundle\WorkflowBundle\Model\WorkflowData;
Please login to merge, or discard this patch.
src/Oro/Bundle/ImapBundle/Entity/UserEmailOrigin.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
     /**
136 136
      * Gets the port of SMTP server
137 137
      *
138
-     * @return int
138
+     * @return string
139 139
      */
140 140
     public function getSmtpPort()
141 141
     {
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
     /**
160 160
      * Gets the port of IMAP server
161 161
      *
162
-     * @return int
162
+     * @return string
163 163
      */
164 164
     public function getImapPort()
165 165
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/ImapBundle/EventListener/UserEmailOriginListener.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@
 block discarded – undo
60 60
     }
61 61
 
62 62
     /**
63
-     * @param ArrayCollection|EmailFolder[] $folders
63
+     * @param ArrayCollection $folders
64 64
      * @param ImapEmailFolderManager $manager
65 65
      */
66 66
     protected function createImapEmailFolders($folders, ImapEmailFolderManager $manager)
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/ImapBundle/Manager/ImapEmailFolderManager.php 2 patches
Doc Comments   +8 added lines, -7 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     }
51 51
 
52 52
     /**
53
-     * @return EmailFolder[]
53
+     * @return ArrayCollection
54 54
      */
55 55
     public function getFolders()
56 56
     {
@@ -118,9 +118,9 @@  discard block
 block discarded – undo
118 118
     }
119 119
 
120 120
     /**
121
-     * @param Folder[]|ArrayCollection $srcFolders
121
+     * @param Folder[] $srcFolders
122 122
      *
123
-     * @return EmailFolderModel[]
123
+     * @return ArrayCollection
124 124
      */
125 125
     protected function processFolders(array $srcFolders)
126 126
     {
@@ -155,8 +155,8 @@  discard block
 block discarded – undo
155 155
     }
156 156
 
157 157
     /**
158
-     * @param EmailFolderModel[]|ArrayCollection $syncedFolderModels
159
-     * @param ImapEmailFolder[]|ArrayCollection $existingImapFolders
158
+     * @param ArrayCollection $syncedFolderModels
159
+     * @param ArrayCollection $existingImapFolders
160 160
      *
161 161
      * @return EmailFolderModel[]
162 162
      */
@@ -202,6 +202,7 @@  discard block
 block discarded – undo
202 202
 
203 203
     /**
204 204
      * @param Folder $srcFolder
205
+     * @param integer $uidValidity
205 206
      *
206 207
      * @return EmailFolderModel
207 208
      */
@@ -243,7 +244,7 @@  discard block
 block discarded – undo
243 244
     /**
244 245
      * @param EmailFolderModel[]|ArrayCollection $emailFolderModels
245 246
      *
246
-     * @return EmailFolder[]|ArrayCollection
247
+     * @return ArrayCollection
247 248
      */
248 249
     protected function extractEmailFolders($emailFolderModels)
249 250
     {
@@ -263,7 +264,7 @@  discard block
 block discarded – undo
263 264
     }
264 265
 
265 266
     /**
266
-     * @return ImapEmailFolder[]|ArrayCollection
267
+     * @return ArrayCollection
267 268
      */
268 269
     protected function getExistingFolders()
269 270
     {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,9 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\Collections\ArrayCollection;
6 6
 use Doctrine\ORM\EntityManager;
7
-
8
-use Zend\Mail\Storage\Exception as MailException;
9
-
10 7
 use Oro\Bundle\EmailBundle\Entity\EmailFolder;
11 8
 use Oro\Bundle\EmailBundle\Entity\EmailOrigin;
12 9
 use Oro\Bundle\ImapBundle\Connector\ImapConnector;
Please login to merge, or discard this patch.