Completed
Push — 1.9 ( fa6699 )
by
unknown
301:30 queued 254:09
created
src/Oro/Bundle/WorkflowBundle/Model/AbstractStorage.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
     /**
72 72
      * Get data values
73 73
      *
74
-     * @param array $names Optional list of names of values that should be filtered
74
+     * @param string[] $names Optional list of names of values that should be filtered
75 75
      * @return array
76 76
      */
77 77
     public function getValues(array $names = array())
Please login to merge, or discard this patch.
src/Oro/Bundle/WorkflowBundle/Model/Action/CreateRelatedEntity.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@
 block discarded – undo
80 80
     }
81 81
 
82 82
     /**
83
-     * @param mixed $context
83
+     * @param WorkflowItem $context
84 84
      * @param object $entity
85 85
      * @param array $parameters
86 86
      */
Please login to merge, or discard this patch.
src/Oro/Bundle/WorkflowBundle/Model/Action/FormatString.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@
 block discarded – undo
66 66
 
67 67
     /**
68 68
      * @param mixed $context
69
-     * @return array
69
+     * @return string
70 70
      * @throws \Oro\Bundle\WorkflowBundle\Exception\InvalidParameterException
71 71
      */
72 72
     protected function getArguments($context)
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/WorkflowBundle/Model/AttributeAssembler.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
 
166 166
     /**
167 167
      * @param Attribute $attribute
168
-     * @param string|array $optionNames
168
+     * @param string $optionNames
169 169
      * @throws AssemblerException If attribute is invalid
170 170
      */
171 171
     protected function assertAttributeHasOptions(Attribute $attribute, $optionNames)
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
 
184 184
     /**
185 185
      * @param Attribute $attribute
186
-     * @param string|array $optionNames
186
+     * @param string $optionNames
187 187
      * @throws AssemblerException If attribute is invalid
188 188
      */
189 189
     protected function assertAttributeHasNoOptions(Attribute $attribute, $optionNames)
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/WorkflowBundle/Model/AttributeGuesser.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -137,7 +137,7 @@
 block discarded – undo
137 137
 
138 138
     /**
139 139
      * @param string $rootClass
140
-     * @param string|PropertyPathInterface $propertyPath
140
+     * @param string $propertyPath
141 141
      * @return array|null
142 142
      */
143 143
     public function guessAttributeParameters($rootClass, $propertyPath)
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/WorkflowBundle/Model/StepManager.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
     }
56 56
 
57 57
     /**
58
-     * @return Collection|Step[]
58
+     * @return Collection
59 59
      */
60 60
     public function getSteps()
61 61
     {
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
     /**
66 66
      * Get steps sorted by order.
67 67
      *
68
-     * @return Collection|Step[]
68
+     * @return ArrayCollection
69 69
      */
70 70
     public function getOrderedSteps()
71 71
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/WorkflowBundle/Model/WorkflowData.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -61,8 +61,8 @@  discard block
 block discarded – undo
61 61
     /**
62 62
      * Get mapped field path by field name.
63 63
      *
64
-     * @param string|PropertyPathInterface $propertyPath
65
-     * @return null|string
64
+     * @param string $propertyPath
65
+     * @return PropertyPathInterface
66 66
      */
67 67
     protected function getMappedPath($propertyPath)
68 68
     {
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
      * Get property path for array as first accessor.
82 82
      *
83 83
      * @param string $path
84
-     * @return string
84
+     * @return PropertyPath
85 85
      */
86 86
     protected function getConstructedPropertyPath($path)
87 87
     {
@@ -326,7 +326,7 @@  discard block
 block discarded – undo
326 326
 
327 327
     /**
328 328
      * @param Proxy $entity
329
-     * @return object|Proxy|null
329
+     * @return null|Proxy
330 330
      */
331 331
     protected function extractProxyEntity(Proxy $entity)
332 332
     {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,12 +4,9 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\Persistence\Proxy;
6 6
 use Doctrine\ORM\EntityNotFoundException;
7
-
8 7
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
9
-use Symfony\Component\PropertyAccess\PropertyAccess;
10 8
 use Symfony\Component\PropertyAccess\PropertyPath;
11 9
 use Symfony\Component\PropertyAccess\PropertyPathInterface;
12
-
13 10
 use Oro\Component\PropertyAccess\PropertyAccessor;
14 11
 
15 12
 class WorkflowData implements \ArrayAccess, \IteratorAggregate, \Countable
Please login to merge, or discard this patch.
Tests/Functional/Controller/Api/Rest/WorkflowControllerTest.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -211,6 +211,7 @@
 block discarded – undo
211 211
     /**
212 212
      * @param string
213 213
      * @param string|null $workflowName
214
+     * @param string $entityClass
214 215
      */
215 216
     protected function assertActiveWorkflow($entityClass, $workflowName)
216 217
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
Oro/Bundle/WorkflowBundle/Tests/Unit/Acl/Voter/WorkflowEntityVoterTest.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -232,10 +232,10 @@
 block discarded – undo
232 232
     }
233 233
 
234 234
     /**
235
-     * @param array $entityAcls
235
+     * @param WorkflowEntityAcl[] $entityAcls
236 236
      * @param string|null $entityClass
237 237
      * @param int|null $entityIdentifier
238
-     * @param array $aclIdentities
238
+     * @param WorkflowEntityAclIdentity[] $aclIdentities
239 239
      */
240 240
     protected function setRegistryRepositories(
241 241
         array $entityAcls = [],
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.