orocrm / platform

src/Oro/Bundle/SecurityBundle/Acl/Persistence/AclPrivilegeRepository.php

Doc Comments +4 added lines, -4 removed lines

@@ -84,7 +84,7 @@ 
      * Gets all privileges associated with the given security identity.
      *
      * @param SID $sid
-     * @return ArrayCollection|AclPrivilege[]
+     * @return ArrayCollection
      */
     public function getPrivileges(SID $sid)
     {
@@ -150,7 +150,7 @@ 
      * Associates privileges with the given security identity.
      *
      * @param SID $sid
-     * @param ArrayCollection|AclPrivilege[] $privileges
+     * @param ArrayCollection $privileges
      * @throws \RuntimeException
      *
      * @SuppressWarnings(PHPMD.NPathComplexity)
@@ -244,7 +244,7 @@ 
      * @param array $context
      * @param array $rootKeys
      * @param SID $sid
-     * @param ArrayCollection|AclPrivilege[] $privileges
+     * @param ArrayCollection $privileges
      */
     protected function initSaveContext(array &$context, array $rootKeys, SID $sid, ArrayCollection $privileges)
     {
@@ -449,7 +449,7 @@ 
      * Sorts the given privileges by name in alphabetical order.
      * The root privilege is moved at the top of the list.
      *
-     * @param ArrayCollection|AclPrivilege[] $privileges [input/output]
+     * @param ArrayCollection $privileges [input/output]
      */
     protected function sortPrivileges(ArrayCollection &$privileges)
     {

Unused Use Statements +1 added lines, -4 removed lines

@@ -2,16 +2,13 @@
 
 namespace Oro\Bundle\SecurityBundle\Acl\Persistence;
 
-use Symfony\Component\Security\Acl\Domain\ObjectIdentity;
+use Symfony\Component\Security\Acl\Domain\ObjectIdentity as OID;
 use Symfony\Component\Security\Acl\Exception\NotAllAclsFoundException;
 use Symfony\Component\Security\Acl\Model\SecurityIdentityInterface as SID;
-use Symfony\Component\Security\Acl\Domain\ObjectIdentity as OID;
 use Symfony\Component\Security\Acl\Model\EntryInterface;
 use Symfony\Component\Security\Acl\Model\AclInterface;
 use Symfony\Component\Translation\TranslatorInterface;
-
 use Doctrine\Common\Collections\ArrayCollection;
-
 use Oro\Bundle\SecurityBundle\Acl\Domain\ObjectIdentityFactory;
 use Oro\Bundle\SecurityBundle\Acl\AccessLevel;
 use Oro\Bundle\SecurityBundle\Acl\Permission\MaskBuilder;

src/Oro/Bundle/SecurityBundle/Authentication/Token/ImpersonationToken.php

Doc Comments +2 added lines, -2 removed lines

@@ -13,11 +13,11 @@
     private $organization;
 
     /**
-     * @param string|object            $user         The username (like a nickname, email address, etc.),
+     * @param \Oro\Bundle\UserBundle\Entity\User            $user         The username (like a nickname, email address, etc.),
      *                                               or a UserInterface instance
      *                                               or an object implementing a __toString method.
      * @param Organization             $organization The organization
-     * @param RoleInterface[]|string[] $roles        An array of roles
+     * @param RoleInterface[] $roles        An array of roles
      */
     public function __construct($user, Organization $organization, array $roles = [])
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/SecurityBundle/ORM/Walker/AclHelper.php

Doc Comments +2 added lines, -2 removed lines

@@ -162,7 +162,7 @@ 
      *
      * @param SelectStatement     $ast
      * @param AclConditionStorage $storage
-     * @param                     $permission
+     * @param                     string $permission
      */
     protected function processSubselects(SelectStatement $ast, AclConditionStorage $storage, $permission)
     {
@@ -304,7 +304,7 @@ 
      *
      * @param IdentificationVariableDeclaration $declaration
      * @param                                   $key
-     * @param                                   $permission
+     * @param                                   string $permission
      *
      * @return JoinAssociationCondition|null
      */

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Doctrine\Common\EventManager;
 use Doctrine\DBAL\Driver\Connection;
-
 use Symfony\Component\Filesystem\Filesystem;
-
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
 

src/Oro/Bundle/SecurityBundle/ORM/Walker/Condition/JoinAssociationCondition.php

Doc Comments +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
     }
 
     /**
-     * @param array $joinConditions
+     * @param integer[] $joinConditions
      */
     public function setJoinConditions($joinConditions)
     {

src/Oro/Bundle/SecurityBundle/Owner/AbstractEntityOwnershipDecisionMaker.php

Doc Comments +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
     }
 
     /**
-     * @return ContainerInterface
+     * @return ContainerAwareInterface
      */
     protected function getContainer()
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/SecurityBundle/Owner/OwnerTree.php

Doc Comments +4 added lines, -4 removed lines

@@ -135,7 +135,7 @@ 
     /**
      * Gets the owning organization id for the given user id
      *
-     * @param  int|string $userId
+     * @param  string $userId
      * @return int|string|null
      */
     public function getUserOrganizationId($userId)
@@ -161,7 +161,7 @@ 
     /**
      * Gets the owning business unit id for the given user id
      *
-     * @param  int|string $userId
+     * @param  string $userId
      * @return int|string|null
      */
     public function getUserBusinessUnitId($userId)
@@ -310,8 +310,8 @@ 
     /**
      * Add the given business unit to the tree
      *
-     * @param int|string      $businessUnitId
-     * @param int|string|null $owningOrganizationId
+     * @param string      $businessUnitId
+     * @param null|string $owningOrganizationId
      *
      * @deprecated 1.8.0:2.1.0 use OwnerTree::addLocalEntity method
      */

src/Oro/Bundle/SecurityBundle/Search/AclHelper.php

Doc Comments +1 added lines, -1 removed lines

@@ -110,7 +110,7 @@
 
     /**
      * @param Query $query
-     * @param $expr
+     * @param \Oro\Bundle\SearchBundle\Query\Criteria\ExpressionBuilder $expr
      */
     protected function addOrganizationLimits(Query $query, $expr)
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/SecurityBundle/Tests/Unit/Acl/Domain/PermissionGrantingStrategyTest.php

Doc Comments +5 added lines, -2 removed lines

@@ -346,6 +346,9 @@ 
         );
     }
 
+    /**
+     * @param ObjectIdentity $oid
+     */
     protected function getAcl($oid = null, $entriesInheriting = true)
     {
         static $id = 1;
@@ -385,7 +388,7 @@ 
 
     /**
      * @param  string     $permission
-     * @param  object     $object
+     * @param  TestEntity     $object
      * @return array|null may return null if permission/object combination is not supported
      */
     private function getMasks($permission, $object)
@@ -395,7 +398,7 @@ 
 
     /**
      * @param  string      $permission
-     * @param  mixed       $object
+     * @param  TestEntity       $object
      * @return MaskBuilder
      */
     private function getMaskBuilder($permission, $object)

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/SecurityBundle/Tests/Unit/Acl/Group/ChainAclGroupProviderTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
     /**
      * @param bool $isSupports
      * @param string $group
-     * @return \PHPUnit_Framework_MockObject_MockObject|AclGroupProviderInterface
+     * @return AclGroupProviderInterface
      */
     protected function getAclGroupProviderMock($isSupports = true, $group = '')
     {