orocrm / platform

src/Oro/Bundle/NotificationBundle/Processor/AbstractNotificationProcessor.php

Doc Comments +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
      * Checks if command is already queued.
      *
      * @param string $command
-     * @return Job
+     * @return boolean
      */
     protected function hasNotFinishedJob($command)
     {

Unused Use Statements -3 removed lines

@@ -4,16 +4,13 @@
 
 use Oro\Bundle\WorkflowBundle\Model\ContextAccessor;
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
-
 use Oro\Bundle\WorkflowBundle\Form\EventListener\DefaultValuesListener;
 use Oro\Bundle\WorkflowBundle\Form\EventListener\InitActionsListener;
 use Oro\Bundle\WorkflowBundle\Form\EventListener\RequiredAttributesListener;
 use Oro\Bundle\WorkflowBundle\Form\Type\WorkflowAttributesType;
-
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowItem;
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowStep;
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowDefinition;
-
 use Oro\Bundle\WorkflowBundle\Model\Step;
 use Oro\Bundle\WorkflowBundle\Model\Attribute;
 use Oro\Bundle\WorkflowBundle\Model\WorkflowData;

src/Oro/Bundle/NotificationBundle/Provider/NotificationManager.php

Doc Comments +4 added lines, -1 removed lines

@@ -31,6 +31,9 @@ 
      */
     protected $notificationRules;
 
+    /**
+     * @param string $className
+     */
     public function __construct(ObjectManager $em, $className)
     {
         $this->handlers = array();
@@ -92,7 +95,7 @@ 
      *
      * @param string $entityName
      * @param string $eventName
-     * @return \Doctrine\Common\Collections\Collection|ArrayCollection
+     * @return \Doctrine\Common\Collections\ArrayCollection
      */
     protected function getRulesByCriteria($entityName, $eventName)
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/NotificationBundle/Tests/Selenium/TransactionEmailsAclTest.php

Doc Comments +16 added lines

@@ -117,6 +117,10 @@ 
         }
     }
 
+    /**
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
+     * @param string $roleName
+     */
     public function deleteAcl($login, $roleName, $username, $email)
     {
         $login->openRoles('Oro\Bundle\UserBundle')
@@ -132,6 +136,10 @@ 
             ->checkContextMenu($email, 'Delete');
     }
 
+    /**
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
+     * @param string $roleName
+     */
     public function updateAcl($login, $roleName, $username, $email)
     {
         $login->openRoles('Oro\Bundle\UserBundle')
@@ -147,6 +155,10 @@ 
             ->checkContextMenu($email, 'Edit');
     }
 
+    /**
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
+     * @param string $roleName
+     */
     public function createAcl($login, $roleName, $username)
     {
         $login->openRoles('Oro\Bundle\UserBundle')
@@ -165,6 +177,10 @@ 
             );
     }
 
+    /**
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
+     * @param string $roleName
+     */
     public function viewListAcl($login, $roleName, $username)
     {
         $login->openRoles('Oro\Bundle\UserBundle')

src/Oro/Bundle/OrganizationBundle/Controller/BusinessUnitController.php

Unused Use Statements -3 removed lines

@@ -3,13 +3,10 @@
 namespace Oro\Bundle\OrganizationBundle\Controller;
 
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
-
 use Oro\Bundle\OrganizationBundle\Entity\BusinessUnit;
 use Oro\Bundle\SecurityBundle\Annotation\Acl;
 use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;

src/Oro/Bundle/OrganizationBundle/Entity/Manager/OrganizationManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
      * @param User   $user
      * @param string $name
      *
-     * @return null|Organization
+     * @return Organization[]
      */
     public function getEnabledUserOrganizationByName(User $user, $name)
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/OrganizationBundle/Entity/Repository/BusinessUnitRepository.php

Unused Use Statements -2 removed lines

@@ -2,9 +2,7 @@
 namespace Oro\Bundle\OrganizationBundle\Entity\Repository;
 
 use Doctrine\ORM\EntityRepository;
-use Doctrine\ORM\Query\Expr;
 use Doctrine\ORM\QueryBuilder;
-
 use Oro\Bundle\OrganizationBundle\Entity\BusinessUnit;
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
 use Oro\Bundle\UserBundle\Entity\User;

src/Oro/Bundle/OrganizationBundle/Form/Extension/OwnerFormExtension.php

Doc Comments +3 added lines, -3 removed lines

@@ -303,7 +303,7 @@ 
 
     /**
      * @param FormBuilderInterface|FormInterface $builder
-     * @param                                    $dataClass
+     * @param                                    string $dataClass
      * @param string                             $permission
      * @param array                              $data
      * @param int                                $entityId
@@ -476,7 +476,7 @@ 
     }
 
     /**
-     * @return null|User
+     * @return User
      */
     protected function getCurrentUser()
     {
@@ -579,7 +579,7 @@ 
     /**
      * Get organization from security facade
      *
-     * @return bool|Organization
+     * @return Organization
      */
     protected function getOrganization()
     {

Unused Use Statements -5 removed lines

@@ -6,15 +6,10 @@
 use Doctrine\Common\Util\ClassUtils;
 use Doctrine\ORM\EntityManager;
 use Doctrine\ORM\Query\Expr\OrderBy;
-
 use JMS\JobQueueBundle\Entity\Job;
-
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
-
 use Oro\Bundle\BatchBundle\ORM\Query\BufferedQueryResultIterator;
-
 use Oro\Bundle\EntityBundle\ORM\DoctrineHelper;
-
 use Oro\Bundle\SearchBundle\Command\IndexCommand;
 use Oro\Bundle\SearchBundle\Entity\Query as QueryLog;
 use Oro\Bundle\SearchBundle\Event\BeforeSearchEvent;

src/Oro/Bundle/OrganizationBundle/Provider/Filter/ChoiceTreeBusinessUnitProvider.php

Doc Comments -1 removed lines

@@ -37,7 +37,6 @@
     }
 
     /**
-     * @param Organization $currentOrganization
      *
      * @return array
      */

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/OrganizationBundle/Tests/Unit/Entity/Manager/BusinessUnitManagerTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -302,8 +302,8 @@
 
     /**
      * @param int   $id
-     * @param array $organizations
-     * @param array $bUnits
+     * @param Organization[] $organizations
+     * @param BusinessUnit[] $bUnits
      * @return User
      */
     protected function getCurrentUser($id, array $organizations, array $bUnits)

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Doctrine\Common\EventManager;
 use Doctrine\DBAL\Driver\Connection;
-
 use Symfony\Component\Filesystem\Filesystem;
-
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;