SoapSearchApiTest - Code Metrics - orocrm/platform - Measure and Improve Code Quality continuously with Scrutinizer

SoapSearchApiTest A
last analyzed 2016-05-19 07:51 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	93
Duplicated Lines	10.75 %

Coupling/Cohesion

Components	2
Dependencies	2

Metric	Value
wmc	14
lcom	2
cbo	2
dl	10
loc	93
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
D	testSearch()	10	50	10
A	setUp()	0	7	1
A	searchDataProvider()	0	6	1
A	assertResultHasItems()	0	6	2

How to fix Duplicated Code

<?php

namespace Oro\Bundle\SearchBundle\Tests\Functional\Controller\Api;

use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;

/**
 * @outputBuffering enabled
 * @dbIsolation
 * @dbReindex
 */
class SoapSearchApiTest extends WebTestCase
{
    /** Default value for offset and max_records */
    const DEFAULT_VALUE = 0;

    protected function setUp()
    {
        $this->initClient([], $this->generateWsseAuthHeader());
        $this->initSoapClient();

        $this->loadFixtures(['Oro\Bundle\SearchBundle\Tests\Functional\Controller\DataFixtures\LoadSearchItemData']);
    }

    /**
     * @param array $request
     * @param array $response
     * @SuppressWarnings(PHPMD.NPathComplexity)
     * @dataProvider searchDataProvider
     */
    public function testSearch(array $request, array $response)
    {
        if (array_key_exists('supported_engines', $request)) {
            $engine = $this->getContainer()->getParameter('oro_search.engine');
            if (!in_array($engine, $request['supported_engines'])) {
                $this->markTestIncomplete('Test should not be executed on this engine');
            }
            unset($request['supported_engines']);
        }

        if (is_null($request['search'])) {
            $request['search'] ='';
        }
        if (is_null($request['offset'])) {
            $request['offset'] = self::DEFAULT_VALUE;
        }
        if (is_null($request['max_results'])) {
            $request['max_results'] = self::DEFAULT_VALUE;
        }

        $result = $this->soapClient->search(
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
            $request['search'],
            $request['offset'],
            $request['max_results']
        );
        $result = $this->valueToArray($result);

        $this->assertEquals($response['records_count'], $result['recordsCount']);
        $this->assertEquals($response['count'], $result['count']);

        if (empty($result['elements']['item'])) {
            $result['elements']['item'] = [];
        }

        // if only one element
        if (empty($result['elements']['item'][0])) {
            $result['elements']['item'] = [$result['elements']['item']];
        }

        // remove ID references
        $recordsRequired = !empty($response['soap']['item'][0]['recordTitle']);
        foreach (array_keys($result['elements']['item']) as $key) {
            unset($result['elements']['item'][$key]['recordId']);
            if (!$recordsRequired) {
                unset($result['elements']['item'][$key]['recordTitle']);
            }
        }

        $this->assertResultHasItems($response['soap']['item'], $result['elements']['item']);
    }

    /**
     * Data provider for SOAP API tests
     *
     * @return array
     */
    public function searchDataProvider()
    {
        return $this->getApiRequestsData(
            __DIR__ . DIRECTORY_SEPARATOR . '..' . DIRECTORY_SEPARATOR . 'requests'
        );
    }

    /**
     * @param array $items
     * @param array $result
     */
    protected function assertResultHasItems(array $items, array $result)
    {
        foreach ($items as $item) {
            $this->assertContains($item, $result);
        }
    }
}


1		<?php
2
3		namespace Oro\Bundle\SearchBundle\Tests\Functional\Controller\Api;
4
5		use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
6
7		/**
8		* @outputBuffering enabled
9		* @dbIsolation
10		* @dbReindex
11		*/
12		class SoapSearchApiTest extends WebTestCase
13		{
14		/** Default value for offset and max_records */
15		const DEFAULT_VALUE = 0;
16
17		protected function setUp()
18		{
19		$this->initClient([], $this->generateWsseAuthHeader());
20		$this->initSoapClient();
21
22		$this->loadFixtures(['Oro\Bundle\SearchBundle\Tests\Functional\Controller\DataFixtures\LoadSearchItemData']);
23		}
24
25		/**
26		* @param array $request
27		* @param array $response
28		* @SuppressWarnings(PHPMD.NPathComplexity)
29		* @dataProvider searchDataProvider
30		*/
31		public function testSearch(array $request, array $response)
32		{
33	View Code Duplication	if (array_key_exists('supported_engines', $request)) {
34		$engine = $this->getContainer()->getParameter('oro_search.engine');
35		if (!in_array($engine, $request['supported_engines'])) {
36		$this->markTestIncomplete('Test should not be executed on this engine');
37		}
38		unset($request['supported_engines']);
39		}
40
41		if (is_null($request['search'])) {
42		$request['search'] ='';
43		}
44		if (is_null($request['offset'])) {
45		$request['offset'] = self::DEFAULT_VALUE;
46		}
47		if (is_null($request['max_results'])) {
48		$request['max_results'] = self::DEFAULT_VALUE;
49		}
50
51		$result = $this->soapClient->search(
		0 ignored issues – show Documentation Bug introduced 2015-11-22 01:09 UTC by Report Bug Copy Issue Report The method `search` does not exist on `object<Oro\Bundle\TestFr...Bundle\Test\SoapClient>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
52		$request['search'],
53		$request['offset'],
54		$request['max_results']
55		);
56		$result = $this->valueToArray($result);
57
58		$this->assertEquals($response['records_count'], $result['recordsCount']);
59		$this->assertEquals($response['count'], $result['count']);
60
61		if (empty($result['elements']['item'])) {
62		$result['elements']['item'] = [];
63		}
64
65		// if only one element
66	View Code Duplication	if (empty($result['elements']['item'][0])) {
67		$result['elements']['item'] = [$result['elements']['item']];
68		}
69
70		// remove ID references
71		$recordsRequired = !empty($response['soap']['item'][0]['recordTitle']);
72		foreach (array_keys($result['elements']['item']) as $key) {
73		unset($result['elements']['item'][$key]['recordId']);
74		if (!$recordsRequired) {
75		unset($result['elements']['item'][$key]['recordTitle']);
76		}
77		}
78
79		$this->assertResultHasItems($response['soap']['item'], $result['elements']['item']);
80		}
81
82		/**
83		* Data provider for SOAP API tests
84		*
85		* @return array
86		*/
87		public function searchDataProvider()
88		{
89		return $this->getApiRequestsData(
90		__DIR__ . DIRECTORY_SEPARATOR . '..' . DIRECTORY_SEPARATOR . 'requests'
91		);
92		}
93
94		/**
95		* @param array $items
96		* @param array $result
97		*/
98		protected function assertResultHasItems(array $items, array $result)
99		{
100		foreach ($items as $item) {
101		$this->assertContains($item, $result);
102		}
103		}
104		}
105

orocrm / platform

SoapSearchApiTest A last analyzed 2016-05-19 07:51 UTC

Complexity

Size/Duplication

Coupling/Cohesion

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

SoapSearchApiTest A
last analyzed 2016-05-19 07:51 UTC