NewsletterSubscriberVoterTest - Code Metrics - Inspection of "Merge remote-tracking branch 'remotes/dev/master'" - orocrm/crm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 36acf6...c2375b )

unknown

created 2016-05-18 12:31 UTC

NewsletterSubscriberVoterTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	229
Duplicated Lines	16.59 %

Coupling/Cohesion

Components	1
Dependencies	4

Metric	Value
wmc	8
lcom	1
cbo	4
dl	38
loc	229
rs	10

6 Methods

Rating	Name	Duplication	Size	Complexity
A	tearDown()	0	4	1
A	setUp()	0	7	1
B	testVote()	29	29	1
B	attributesDataProvider()	0	115	1
A	getObjectIdentity()	9	9	1
B	getSubscriber()	0	25	3

How to fix Duplicated Code

<?php

namespace OroCRM\Bundle\MagentoBundle\Tests\Unit\Acl\Voter;

use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;

use OroCRM\Bundle\MagentoBundle\Entity\NewsletterSubscriber;
use OroCRM\Bundle\MagentoBundle\Acl\Voter\NewsletterSubscriberVoter;

class NewsletterSubscriberVoterTest extends AbstractTwoWaySyncVoterTest
{
    /**
     * @var NewsletterSubscriberVoter
     */
    protected $voter;

    protected function setUp()
    {
        parent::setUp();

        $this->voter = new NewsletterSubscriberVoter($this->doctrineHelper);
        $this->voter->setSettingsProvider($this->settingsProvider);
    }

    protected function tearDown()
    {
        unset($this->voter, $this->doctrineHelper);
    }

    /**
     * @param object $object
     * @param string $className
     * @param array $attributes
     * @param bool $hasApplicableChannels
     * @param bool $isChannelApplicable
     * @param bool $expected
     *
     * @dataProvider attributesDataProvider
     */
    public function testVote($object, $className, $attributes, $hasApplicableChannels, $isChannelApplicable, $expected)

    {
        $this->doctrineHelper->expects($this->any())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('getEntityClass')
            ->with($object)
            ->will($this->returnValue($className));

        $this->voter->setClassName('OroCRM\Bundle\MagentoBundle\Entity\NewsletterSubscriber');

        $this->doctrineHelper->expects($this->any())
            ->method('getSingleEntityIdentifier')
            ->with($object, false)
            ->will($this->returnValue(1));

        $this->settingsProvider->expects($this->any())
            ->method('isChannelApplicable')
            ->will($this->returnValue($isChannelApplicable));

        $this->settingsProvider->expects($this->any())
            ->method('hasApplicableChannels')
            ->will($this->returnValue($hasApplicableChannels));

        /** @var TokenInterface $token */
        $token = $this->getMock('Symfony\Component\Security\Core\Authentication\Token\TokenInterface');
        $this->assertEquals(
            $expected,
            $this->voter->vote($token, $object, $attributes)
        );
    }

    /**
     * @return array
     *
     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
     */
    public function attributesDataProvider()
    {
        $className = 'OroCRM\Bundle\MagentoBundle\Entity\NewsletterSubscriber';
        $objectIdentityClass = 'Symfony\Component\Security\Acl\Model\ObjectIdentityInterface';


        return [
            // has not applicable channels
            [
                $this->getObjectIdentity($objectIdentityClass, $className),
                $objectIdentityClass,
                ['VIEW'],
                false,
                false,
                NewsletterSubscriberVoter::ACCESS_ABSTAIN,
            ],
            [
                $this->getObjectIdentity($objectIdentityClass, $className),
                $objectIdentityClass,
                ['CREATE'],
                false,
                false,
                NewsletterSubscriberVoter::ACCESS_DENIED,
            ],
            [
                $this->getObjectIdentity($objectIdentityClass, $className),
                $objectIdentityClass,
                ['EDIT'],
                false,
                false,
                NewsletterSubscriberVoter::ACCESS_DENIED,
            ],
            [
                $this->getObjectIdentity($objectIdentityClass, $className),
                $objectIdentityClass,
                ['DELETE'],
                false,
                false,
                NewsletterSubscriberVoter::ACCESS_ABSTAIN
            ],
            [
                $this->getObjectIdentity($objectIdentityClass, $className),
                $objectIdentityClass,
                ['ASSIGN'],
                false,
                false,
                NewsletterSubscriberVoter::ACCESS_ABSTAIN
            ],
            // channel not applicable
            [$this->getSubscriber(), $className, ['VIEW'], true, false, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
            [$this->getSubscriber(), $className, ['CREATE'], true, false, NewsletterSubscriberVoter::ACCESS_DENIED],
            [$this->getSubscriber(), $className, ['EDIT'], true, false, NewsletterSubscriberVoter::ACCESS_DENIED],
            [$this->getSubscriber(), $className, ['DELETE'], true, false, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
            [$this->getSubscriber(), $className, ['ASSIGN'], true, false, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
            // without customer
            [$this->getSubscriber(), $className, ['VIEW'], true, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
            [$this->getSubscriber(), $className, ['CREATE'], true, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
            [$this->getSubscriber(), $className, ['EDIT'], true, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
            [$this->getSubscriber(), $className, ['DELETE'], true, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
            [$this->getSubscriber(), $className, ['ASSIGN'], true, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
            // with customer and without origin id
            [$this->getSubscriber(true), $className, ['VIEW'], true, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
            [$this->getSubscriber(true), $className, ['CREATE'], true, true, NewsletterSubscriberVoter::ACCESS_DENIED],
            [$this->getSubscriber(true), $className, ['EDIT'], true, true, NewsletterSubscriberVoter::ACCESS_DENIED],
            [$this->getSubscriber(true), $className, ['DELETE'], true, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
            [$this->getSubscriber(true), $className, ['ASSIGN'], true, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
            // applicable with origin id
            [
                $this->getSubscriber(true, 1),
                $className,
                ['VIEW'],
                true,
                true,
                NewsletterSubscriberVoter::ACCESS_ABSTAIN
            ],
            [
                $this->getSubscriber(true, 1),
                $className,
                ['CREATE'],
                true,
                true,
                NewsletterSubscriberVoter::ACCESS_ABSTAIN
            ],
            [
                $this->getSubscriber(true, 1),
                $className,
                ['EDIT'],
                true,
                true,
                NewsletterSubscriberVoter::ACCESS_ABSTAIN
            ],
            [
                $this->getSubscriber(true, 1),
                $className,
                ['DELETE'],
                true,
                true,
                NewsletterSubscriberVoter::ACCESS_ABSTAIN
            ],
            [
                $this->getSubscriber(true, 1),
                $className,
                ['ASSIGN'],
                true,
                true,
                NewsletterSubscriberVoter::ACCESS_ABSTAIN
            ],
            // applicable but without channels
            [$this->getSubscriber(1), $className, ['VIEW'], false, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            [$this->getSubscriber(1), $className, ['CREATE'], false, true, NewsletterSubscriberVoter::ACCESS_DENIED],
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            [$this->getSubscriber(1), $className, ['EDIT'], false, true, NewsletterSubscriberVoter::ACCESS_DENIED],
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            [$this->getSubscriber(1), $className, ['DELETE'], false, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            [$this->getSubscriber(1), $className, ['ASSIGN'], false, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN]
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        ];
    }

    /**
     * @param string $objectIdentityClass
     * @param string $className
     *
     * @return \PHPUnit_Framework_MockObject_MockObject|NewsletterSubscriber
     */
    public function getObjectIdentity($objectIdentityClass, $className)

    {
        $objectIdentity = $this->getMock($objectIdentityClass);
        $objectIdentity->expects($this->any())
            ->method('getType')
            ->will($this->returnValue($className));

        return $objectIdentity;
    }

    /**
     * @param bool $hasCustomer
     * @param int $customerOriginId
     *
     * @return \PHPUnit_Framework_MockObject_MockObject|NewsletterSubscriber
     */
    protected function getSubscriber($hasCustomer = false, $customerOriginId = null)
    {
        $newsletterSubscriber = $this->getMock('OroCRM\Bundle\MagentoBundle\Entity\NewsletterSubscriber');

        $channel = $this->getMock('Oro\Bundle\IntegrationBundle\Entity\Channel');
        $newsletterSubscriber->expects($this->any())
            ->method('getChannel')
            ->will($this->returnValue($channel));

        if ($hasCustomer) {
            $customer = $this->getMock('OroCRM\Bundle\MagentoBundle\Entity\Customer');

            $newsletterSubscriber->expects($this->any())
                ->method('getCustomer')
                ->will($this->returnValue($customer));

            if ($customerOriginId) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
                $customer->expects($this->once())
                    ->method('getOriginId')
                    ->will($this->returnValue($customerOriginId));
            }
        }

        return $newsletterSubscriber;
    }
}


1		<?php
2
3		namespace OroCRM\Bundle\MagentoBundle\Tests\Unit\Acl\Voter;
4
5		use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
6
7		use OroCRM\Bundle\MagentoBundle\Entity\NewsletterSubscriber;
8		use OroCRM\Bundle\MagentoBundle\Acl\Voter\NewsletterSubscriberVoter;
9
10		class NewsletterSubscriberVoterTest extends AbstractTwoWaySyncVoterTest
11		{
12		/**
13		* @var NewsletterSubscriberVoter
14		*/
15		protected $voter;
16
17		protected function setUp()
18		{
19		parent::setUp();
20
21		$this->voter = new NewsletterSubscriberVoter($this->doctrineHelper);
22		$this->voter->setSettingsProvider($this->settingsProvider);
23		}
24
25		protected function tearDown()
26		{
27		unset($this->voter, $this->doctrineHelper);
28		}
29
30		/**
31		* @param object $object
32		* @param string $className
33		* @param array $attributes
34		* @param bool $hasApplicableChannels
35		* @param bool $isChannelApplicable
36		* @param bool $expected
37		*
38		* @dataProvider attributesDataProvider
39		*/
40	View Code Duplication	public function testVote($object, $className, $attributes, $hasApplicableChannels, $isChannelApplicable, $expected)
		0 ignored issues – show Duplication introduced 2015-11-25 07:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
41		{
42		$this->doctrineHelper->expects($this->any())
		0 ignored issues – show Bug introduced 2016-02-04 07:16 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `Oro\Bundle\EntityBundle\ORM\DoctrineHelper`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
43		->method('getEntityClass')
44		->with($object)
45		->will($this->returnValue($className));
46
47		$this->voter->setClassName('OroCRM\Bundle\MagentoBundle\Entity\NewsletterSubscriber');
48
49		$this->doctrineHelper->expects($this->any())
50		->method('getSingleEntityIdentifier')
51		->with($object, false)
52		->will($this->returnValue(1));
53
54		$this->settingsProvider->expects($this->any())
55		->method('isChannelApplicable')
56		->will($this->returnValue($isChannelApplicable));
57
58		$this->settingsProvider->expects($this->any())
59		->method('hasApplicableChannels')
60		->will($this->returnValue($hasApplicableChannels));
61
62		/** @var TokenInterface $token */
63		$token = $this->getMock('Symfony\Component\Security\Core\Authentication\Token\TokenInterface');
64		$this->assertEquals(
65		$expected,
66		$this->voter->vote($token, $object, $attributes)
67		);
68		}
69
70		/**
71		* @return array
72		*
73		* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
74		*/
75		public function attributesDataProvider()
76		{
77		$className = 'OroCRM\Bundle\MagentoBundle\Entity\NewsletterSubscriber';
78		$objectIdentityClass = 'Symfony\Component\Security\Acl\Model\ObjectIdentityInterface';
79
80
81		return [
82		// has not applicable channels
83		[
84		$this->getObjectIdentity($objectIdentityClass, $className),
85		$objectIdentityClass,
86		['VIEW'],
87		false,
88		false,
89		NewsletterSubscriberVoter::ACCESS_ABSTAIN,
90		],
91		[
92		$this->getObjectIdentity($objectIdentityClass, $className),
93		$objectIdentityClass,
94		['CREATE'],
95		false,
96		false,
97		NewsletterSubscriberVoter::ACCESS_DENIED,
98		],
99		[
100		$this->getObjectIdentity($objectIdentityClass, $className),
101		$objectIdentityClass,
102		['EDIT'],
103		false,
104		false,
105		NewsletterSubscriberVoter::ACCESS_DENIED,
106		],
107		[
108		$this->getObjectIdentity($objectIdentityClass, $className),
109		$objectIdentityClass,
110		['DELETE'],
111		false,
112		false,
113		NewsletterSubscriberVoter::ACCESS_ABSTAIN
114		],
115		[
116		$this->getObjectIdentity($objectIdentityClass, $className),
117		$objectIdentityClass,
118		['ASSIGN'],
119		false,
120		false,
121		NewsletterSubscriberVoter::ACCESS_ABSTAIN
122		],
123		// channel not applicable
124		[$this->getSubscriber(), $className, ['VIEW'], true, false, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
125		[$this->getSubscriber(), $className, ['CREATE'], true, false, NewsletterSubscriberVoter::ACCESS_DENIED],
126		[$this->getSubscriber(), $className, ['EDIT'], true, false, NewsletterSubscriberVoter::ACCESS_DENIED],
127		[$this->getSubscriber(), $className, ['DELETE'], true, false, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
128		[$this->getSubscriber(), $className, ['ASSIGN'], true, false, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
129		// without customer
130		[$this->getSubscriber(), $className, ['VIEW'], true, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
131		[$this->getSubscriber(), $className, ['CREATE'], true, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
132		[$this->getSubscriber(), $className, ['EDIT'], true, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
133		[$this->getSubscriber(), $className, ['DELETE'], true, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
134		[$this->getSubscriber(), $className, ['ASSIGN'], true, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
135		// with customer and without origin id
136		[$this->getSubscriber(true), $className, ['VIEW'], true, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
137		[$this->getSubscriber(true), $className, ['CREATE'], true, true, NewsletterSubscriberVoter::ACCESS_DENIED],
138		[$this->getSubscriber(true), $className, ['EDIT'], true, true, NewsletterSubscriberVoter::ACCESS_DENIED],
139		[$this->getSubscriber(true), $className, ['DELETE'], true, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
140		[$this->getSubscriber(true), $className, ['ASSIGN'], true, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
141		// applicable with origin id
142		[
143		$this->getSubscriber(true, 1),
144		$className,
145		['VIEW'],
146		true,
147		true,
148		NewsletterSubscriberVoter::ACCESS_ABSTAIN
149		],
150		[
151		$this->getSubscriber(true, 1),
152		$className,
153		['CREATE'],
154		true,
155		true,
156		NewsletterSubscriberVoter::ACCESS_ABSTAIN
157		],
158		[
159		$this->getSubscriber(true, 1),
160		$className,
161		['EDIT'],
162		true,
163		true,
164		NewsletterSubscriberVoter::ACCESS_ABSTAIN
165		],
166		[
167		$this->getSubscriber(true, 1),
168		$className,
169		['DELETE'],
170		true,
171		true,
172		NewsletterSubscriberVoter::ACCESS_ABSTAIN
173		],
174		[
175		$this->getSubscriber(true, 1),
176		$className,
177		['ASSIGN'],
178		true,
179		true,
180		NewsletterSubscriberVoter::ACCESS_ABSTAIN
181		],
182		// applicable but without channels
183		[$this->getSubscriber(1), $className, ['VIEW'], false, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
		0 ignored issues – show Documentation introduced 2016-02-10 07:16 UTC by Report Bug Copy Issue Report `1` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
184		[$this->getSubscriber(1), $className, ['CREATE'], false, true, NewsletterSubscriberVoter::ACCESS_DENIED],
		0 ignored issues – show Documentation introduced 2016-02-10 07:16 UTC by Report Bug Copy Issue Report `1` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
185		[$this->getSubscriber(1), $className, ['EDIT'], false, true, NewsletterSubscriberVoter::ACCESS_DENIED],
		0 ignored issues – show Documentation introduced 2016-02-10 07:16 UTC by Report Bug Copy Issue Report `1` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
186		[$this->getSubscriber(1), $className, ['DELETE'], false, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN],
		0 ignored issues – show Documentation introduced 2016-02-10 07:16 UTC by Report Bug Copy Issue Report `1` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
187		[$this->getSubscriber(1), $className, ['ASSIGN'], false, true, NewsletterSubscriberVoter::ACCESS_ABSTAIN]
		0 ignored issues – show Documentation introduced 2016-02-10 07:16 UTC by Report Bug Copy Issue Report `1` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
188		];
189		}
190
191		/**
192		* @param string $objectIdentityClass
193		* @param string $className
194		*
195		* @return \PHPUnit_Framework_MockObject_MockObject\|NewsletterSubscriber
196		*/
197	View Code Duplication	public function getObjectIdentity($objectIdentityClass, $className)
		0 ignored issues – show Duplication introduced 2016-05-18 12:43 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
198		{
199		$objectIdentity = $this->getMock($objectIdentityClass);
200		$objectIdentity->expects($this->any())
201		->method('getType')
202		->will($this->returnValue($className));
203
204		return $objectIdentity;
205		}
206
207		/**
208		* @param bool $hasCustomer
209		* @param int $customerOriginId
210		*
211		* @return \PHPUnit_Framework_MockObject_MockObject\|NewsletterSubscriber
212		*/
213		protected function getSubscriber($hasCustomer = false, $customerOriginId = null)
214		{
215		$newsletterSubscriber = $this->getMock('OroCRM\Bundle\MagentoBundle\Entity\NewsletterSubscriber');
216
217		$channel = $this->getMock('Oro\Bundle\IntegrationBundle\Entity\Channel');
218		$newsletterSubscriber->expects($this->any())
219		->method('getChannel')
220		->will($this->returnValue($channel));
221
222		if ($hasCustomer) {
223		$customer = $this->getMock('OroCRM\Bundle\MagentoBundle\Entity\Customer');
224
225		$newsletterSubscriber->expects($this->any())
226		->method('getCustomer')
227		->will($this->returnValue($customer));
228
229		if ($customerOriginId) {
		0 ignored issues – show Bug Best Practice introduced 2015-11-25 07:11 UTC by Report Bug Copy Issue Report The expression `$customerOriginId` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
230		$customer->expects($this->once())
231		->method('getOriginId')
232		->will($this->returnValue($customerOriginId));
233		}
234		}
235
236		return $newsletterSubscriber;
237		}
238		}
239

orocrm / crm

Push — master ( 36acf6...c2375b )

NewsletterSubscriberVoterTest A

Complexity

Size/Duplication

Coupling/Cohesion

6 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like