ProxyEntityWriter::write() - Code Metrics - Inspection of "Merge remote-tracking branch 'remotes/dev/master'" - orocrm/crm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c2375b...0b658a )

unknown

created 2016-05-19 06:27 UTC

ProxyEntityWriter::write() C

↳ Parent: ProxyEntityWriter

Complexity

Conditions	11
Paths	11

Size

Total Lines	41
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	41
rs	5.2653
cc	11
eloc	28
nc	11
nop	1

How to fix Complexity

<?php

namespace OroCRM\Bundle\MagentoBundle\ImportExport\Writer;

use Psr\Log\NullLogger;
use Psr\Log\LoggerAwareTrait;
use Psr\Log\LoggerAwareInterface;

use Akeneo\Bundle\BatchBundle\Entity\StepExecution;
use Akeneo\Bundle\BatchBundle\Item\ItemWriterInterface;
use Akeneo\Bundle\BatchBundle\Step\StepExecutionAwareInterface;

use Oro\Bundle\BatchBundle\Step\StepExecutionRestoreInterface;

use Oro\Bundle\ImportExportBundle\Field\DatabaseHelper;

use OroCRM\Bundle\MagentoBundle\Entity\Cart;
use OroCRM\Bundle\MagentoBundle\Entity\Order;
use OroCRM\Bundle\MagentoBundle\Entity\Customer;
use OroCRM\Bundle\MagentoBundle\Entity\NewsletterSubscriber;

class ProxyEntityWriter implements
    ItemWriterInterface,
    StepExecutionAwareInterface,
    StepExecutionRestoreInterface,
    LoggerAwareInterface
{
    use LoggerAwareTrait;

    /** @var ItemWriterInterface */
    protected $writer;

    /** @var DatabaseHelper */
    protected $databaseHelper;

    /** @var StepExecution|null */
    protected $previousStepExecution;

    /**
     * @param ItemWriterInterface $writer
     * @param DatabaseHelper $databaseHelper
     */
    public function __construct(ItemWriterInterface $writer, DatabaseHelper $databaseHelper)
    {
        $this->writer = $writer;
        $this->databaseHelper = $databaseHelper;
        $this->logger = new NullLogger();
    }

    /**
     * {@inheritdoc}
     *
     * Prepare items for PersistentBatchWriter, filters for duplicates and takes only latest versions
     */
    public function write(array $items)
    {
        $uniqueItems = [];
        $uniqueKeys = [];
        foreach ($items as $item) {
            if ($item instanceof Customer) {
                //GuestCustomerStrategy checks both email and channel
                if ($item->isGuest()) {
                    $channel = $item->getChannel();
                    $identifier = preg_replace('/[^a-zA-Z0-9\.]/', '', $item->getEmail());
                    //set unique identifier: email and channel id
                    if ($channel) {
                        $identifier.=$channel->getId();
                    }
                } else {
                    $identifier = $item->getOriginId();
                }
                $this->handleIdentifier($uniqueItems, $item, $identifier);
            } elseif ($item instanceof Cart) {
                $this->handleIdentifier($uniqueItems, $item, $item->getOriginId());
            } elseif ($item instanceof Order) {
                $this->handleIdentifier($uniqueItems, $item, $item->getIncrementId());
            } elseif ($item instanceof NewsletterSubscriber) {
                $identifier = $item->getCustomer() ? $item->getCustomer()->getId() : 0;
                if ($identifier !== 0 && in_array($identifier, $uniqueKeys)) {
                    $this->logSkipped($item->getOriginId());
                } else {
                    $uniqueKeys[] = $identifier;
                    $uniqueItems[] = $item;
                }

            } else {
                $uniqueItems[] = $item;
            }
        }

        $this->writer->write($uniqueItems);

        // force entity cache clear if clear is skipped
        $this->databaseHelper->onClear();
    }

    /**
     * {@inheritdoc}
     */
    public function setStepExecution(StepExecution $stepExecution)
    {
        if ($this->writer instanceof StepExecutionAwareInterface) {
            $this->writer->setStepExecution($stepExecution);
        }
    }

    /**
     * {@inheritdoc}
     */
    public function restoreStepExecution()
    {
        if ($this->writer instanceof StepExecutionRestoreInterface) {
            $this->writer->restoreStepExecution();
        }
    }

    /**
     * @param array $uniqueItems
     * @param object $item
     * @param string|null $identifier
     */
    protected function handleIdentifier(array &$uniqueItems, $item, $identifier = null)
    {
        if ($identifier && array_key_exists($identifier, $uniqueItems)) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->logSkipped($identifier);
        }

        if ($identifier) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $uniqueItems[$identifier] = $item;
        } else {
            $uniqueItems[spl_object_hash($item)] = $item;
        }
    }

    /**
     * @param int|string $identifier
     */
    protected function logSkipped($identifier)
    {
        $this->logger->info(
            sprintf('[origin_id=%s] Item skipped because of newer version found', (string)$identifier)
        );
    }
}


1			<?php
2
3			namespace OroCRM\Bundle\MagentoBundle\ImportExport\Writer;
4
5			use Psr\Log\NullLogger;
6			use Psr\Log\LoggerAwareTrait;
7			use Psr\Log\LoggerAwareInterface;
8
9			use Akeneo\Bundle\BatchBundle\Entity\StepExecution;
10			use Akeneo\Bundle\BatchBundle\Item\ItemWriterInterface;
11			use Akeneo\Bundle\BatchBundle\Step\StepExecutionAwareInterface;
12
13			use Oro\Bundle\BatchBundle\Step\StepExecutionRestoreInterface;
14
15			use Oro\Bundle\ImportExportBundle\Field\DatabaseHelper;
16
17			use OroCRM\Bundle\MagentoBundle\Entity\Cart;
18			use OroCRM\Bundle\MagentoBundle\Entity\Order;
19			use OroCRM\Bundle\MagentoBundle\Entity\Customer;
20			use OroCRM\Bundle\MagentoBundle\Entity\NewsletterSubscriber;
21
22			class ProxyEntityWriter implements
23			ItemWriterInterface,
24			StepExecutionAwareInterface,
25			StepExecutionRestoreInterface,
26			LoggerAwareInterface
27			{
28			use LoggerAwareTrait;
29
30			/** @var ItemWriterInterface */
31			protected $writer;
32
33			/** @var DatabaseHelper */
34			protected $databaseHelper;
35
36			/** @var StepExecution\|null */
37			protected $previousStepExecution;
38
39			/**
40			* @param ItemWriterInterface $writer
41			* @param DatabaseHelper $databaseHelper
42			*/
43			public function __construct(ItemWriterInterface $writer, DatabaseHelper $databaseHelper)
44			{
45			$this->writer = $writer;
46			$this->databaseHelper = $databaseHelper;
47			$this->logger = new NullLogger();
48			}
49
50			/**
51			* {@inheritdoc}
52			*
53			* Prepare items for PersistentBatchWriter, filters for duplicates and takes only latest versions
54			*/
55			public function write(array $items)
56			{
57			$uniqueItems = [];
58			$uniqueKeys = [];
59			foreach ($items as $item) {
60			if ($item instanceof Customer) {
61			//GuestCustomerStrategy checks both email and channel
62			if ($item->isGuest()) {
63			$channel = $item->getChannel();
64			$identifier = preg_replace('/[^a-zA-Z0-9\.]/', '', $item->getEmail());
65			//set unique identifier: email and channel id
66			if ($channel) {
67			$identifier.=$channel->getId();
68			}
69			} else {
70			$identifier = $item->getOriginId();
71			}
72			$this->handleIdentifier($uniqueItems, $item, $identifier);
73			} elseif ($item instanceof Cart) {
74			$this->handleIdentifier($uniqueItems, $item, $item->getOriginId());
75			} elseif ($item instanceof Order) {
76			$this->handleIdentifier($uniqueItems, $item, $item->getIncrementId());
77			} elseif ($item instanceof NewsletterSubscriber) {
78			$identifier = $item->getCustomer() ? $item->getCustomer()->getId() : 0;
79			if ($identifier !== 0 && in_array($identifier, $uniqueKeys)) {
80			$this->logSkipped($item->getOriginId());
81			} else {
82			$uniqueKeys[] = $identifier;
83			$uniqueItems[] = $item;
84			}
85
86			} else {
87			$uniqueItems[] = $item;
88			}
89			}
90
91			$this->writer->write($uniqueItems);
92
93			// force entity cache clear if clear is skipped
94			$this->databaseHelper->onClear();
95			}
96
97			/**
98			* {@inheritdoc}
99			*/
100			public function setStepExecution(StepExecution $stepExecution)
101			{
102			if ($this->writer instanceof StepExecutionAwareInterface) {
103			$this->writer->setStepExecution($stepExecution);
104			}
105			}
106
107			/**
108			* {@inheritdoc}
109			*/
110			public function restoreStepExecution()
111			{
112			if ($this->writer instanceof StepExecutionRestoreInterface) {
113			$this->writer->restoreStepExecution();
114			}
115			}
116
117			/**
118			* @param array $uniqueItems
119			* @param object $item
120			* @param string\|null $identifier
121			*/
122			protected function handleIdentifier(array &$uniqueItems, $item, $identifier = null)
123			{
124			if ($identifier && array_key_exists($identifier, $uniqueItems)) {
			0 ignored issues – show Bug Best Practice introduced 2015-12-23 08:20 UTC by Report Bug Copy Issue Report The expression `$identifier` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
125			$this->logSkipped($identifier);
126			}
127
128			if ($identifier) {
			0 ignored issues – show Bug Best Practice introduced 2015-12-23 08:20 UTC by Report Bug Copy Issue Report The expression `$identifier` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
129			$uniqueItems[$identifier] = $item;
130			} else {
131			$uniqueItems[spl_object_hash($item)] = $item;
132			}
133			}
134
135			/**
136			* @param int\|string $identifier
137			*/
138			protected function logSkipped($identifier)
139			{
140			$this->logger->info(
141			sprintf('[origin_id=%s] Item skipped because of newer version found', (string)$identifier)
142			);
143			}
144			}
145

orocrm / crm

Push — master ( c2375b...0b658a )

ProxyEntityWriter::write() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like