Completed
Push — 1.10 ( 93e51c...7f32fb )
by
unknown
11:06
created
Bundle/SalesBundle/Tests/Unit/Builder/OpportunityRelationsBuilderTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@
 block discarded – undo
147 147
     }
148 148
 
149 149
     /**
150
-     * @param object $object
150
+     * @param B2bCustomer $object
151 151
      * @param int $id
152 152
      */
153 153
     private function setObjectId($object, $id)
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -3,9 +3,6 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\SalesBundle\Tests\Unit\Builder;
4 4
 
5 5
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
6
-
7
-use Oro\Bundle\SecurityBundle\SecurityFacade;
8
-
9 6
 use OroCRM\Bundle\AccountBundle\Entity\Account;
10 7
 use OroCRM\Bundle\ChannelBundle\Entity\Channel;
11 8
 use OroCRM\Bundle\ContactBundle\Entity\Contact;
Please login to merge, or discard this patch.
Bundle/SalesBundle/Migrations/Schema/v1_23/UpdateWorkflowItemStepData.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -341,7 +341,7 @@
 block discarded – undo
341 341
     /**
342 342
      * @param LoggerInterface $logger
343 343
      * @param string $name
344
-     * @param array $exclude
344
+     * @param string[] $exclude
345 345
      * @return array
346 346
      */
347 347
     protected function getWorkflowFieldsByWorkflow(LoggerInterface $logger, $name, array $exclude)
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,10 +3,8 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\SalesBundle\Migrations\Schema\v1_23;
4 4
 
5 5
 use Psr\Log\LoggerInterface;
6
-
7 6
 use Doctrine\DBAL\Types\Type;
8 7
 use Doctrine\DBAL\Connection;
9
-
10 8
 use Oro\Bundle\MigrationBundle\Migration\ArrayLogger;
11 9
 use Oro\Bundle\MigrationBundle\Migration\ParametrizedMigrationQuery;
12 10
 
Please login to merge, or discard this patch.
Bundle/MagentoBundle/ImportExport/Strategy/DefaultMagentoImportStrategy.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
      * should be configured special identity fields or search context in appropriate strategy
67 67
      *
68 68
      * @param       $entity
69
-     * @param       $entityClass
69
+     * @param       string $entityClass
70 70
      * @param array $searchContext
71 71
      *
72 72
      * @return array|null
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
      *
98 98
      * @param object $entity
99 99
      *
100
-     * @return null|Customer
100
+     * @return null|\Oro\Bundle\BusinessEntitiesBundle\Entity\BasePerson
101 101
      */
102 102
     protected function findExistingCustomerByContext($entity)
103 103
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,10 +4,8 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\PropertyAccess\PropertyAccess;
6 6
 use Symfony\Component\PropertyAccess\PropertyAccessor;
7
-
8 7
 use Oro\Bundle\ImportExportBundle\Strategy\Import\ConfigurableAddOrReplaceStrategy;
9 8
 use Oro\Bundle\AddressBundle\Entity\Region;
10
-
11 9
 use OroCRM\Bundle\MagentoBundle\Entity\Customer;
12 10
 use OroCRM\Bundle\MagentoBundle\Entity\Region as MagentoRegion;
13 11
 
Please login to merge, or discard this patch.
OroCRM/Bundle/MagentoBundle/Tests/Functional/Fixture/LoadMagentoChannel.php 2 patches
Doc Comments   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -148,8 +148,8 @@  discard block
 block discarded – undo
148 148
     }
149 149
 
150 150
     /**
151
-     * @param                 $billing
152
-     * @param                 $shipping
151
+     * @param                 CartAddress $billing
152
+     * @param                 CartAddress $shipping
153 153
      * @param Customer        $customer
154 154
      * @param ArrayCollection $item
155 155
      * @param CartStatus      $status
@@ -189,8 +189,8 @@  discard block
 block discarded – undo
189 189
     }
190 190
 
191 191
     /**
192
-     * @param                 $billing
193
-     * @param                 $shipping
192
+     * @param                 CartAddress $billing
193
+     * @param                 CartAddress $shipping
194 194
      * @param ArrayCollection $item
195 195
      * @param CartStatus      $status
196 196
      *
@@ -229,8 +229,8 @@  discard block
 block discarded – undo
229 229
     }
230 230
 
231 231
     /**
232
-     * @param $table
233
-     * @param $method
232
+     * @param string $table
233
+     * @param string $method
234 234
      *
235 235
      * @return array
236 236
      */
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
     /**
293 293
      * @param $region
294 294
      * @param $country
295
-     * @param $originId
295
+     * @param integer $originId
296 296
      *
297 297
      * @return CartAddress
298 298
      */
@@ -391,7 +391,7 @@  discard block
 block discarded – undo
391 391
     }
392 392
 
393 393
     /**
394
-     * @param                $oid
394
+     * @param                integer $oid
395 395
      * @param Account        $account
396 396
      * @param MagentoAddress $address
397 397
      *
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -5,17 +5,14 @@
 block discarded – undo
5 5
 use Doctrine\Common\Collections\ArrayCollection;
6 6
 use Doctrine\Common\DataFixtures\AbstractFixture;
7 7
 use Doctrine\Common\Persistence\ObjectManager;
8
-
9 8
 use Symfony\Component\DependencyInjection\ContainerAwareInterface;
10 9
 use Symfony\Component\DependencyInjection\ContainerInterface;
11
-
12 10
 use Oro\Bundle\AddressBundle\Entity\Address;
13 11
 use Oro\Component\Config\Common\ConfigObject;
14 12
 use Oro\Bundle\IntegrationBundle\Entity\Channel as Integration;
15 13
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
16 14
 use Oro\Bundle\UserBundle\Entity\User;
17 15
 use Oro\Bundle\UserBundle\Model\Gender;
18
-
19 16
 use OroCRM\Bundle\AccountBundle\Entity\Account;
20 17
 use OroCRM\Bundle\ChannelBundle\Builder\BuilderFactory;
21 18
 use OroCRM\Bundle\ChannelBundle\Entity\Channel;
Please login to merge, or discard this patch.
src/OroCRM/Bundle/ActivityContactBundle/EventListener/ActivityListener.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -321,7 +321,7 @@  discard block
 block discarded – undo
321 321
 
322 322
     /**
323 323
      * @param $entity
324
-     * @param $extendProvider
324
+     * @param \Oro\Bundle\EntityConfigBundle\Provider\ConfigProvider|null $extendProvider
325 325
      */
326 326
     protected function collectDeleteEntities($entity, $extendProvider)
327 327
     {
@@ -357,7 +357,7 @@  discard block
 block discarded – undo
357 357
     /**
358 358
      * @param OnFlushEventArgs $args
359 359
      * @param                  $entity
360
-     * @param                  $extendProvider
360
+     * @param                  \Oro\Bundle\EntityConfigBundle\Provider\ConfigProvider|null $extendProvider
361 361
      */
362 362
     protected function collectUpdateEntities(OnFlushEventArgs $args, $entity, $extendProvider)
363 363
     {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -6,14 +6,11 @@
 block discarded – undo
6 6
 use Doctrine\ORM\EntityManager;
7 7
 use Doctrine\ORM\Event\OnFlushEventArgs;
8 8
 use Doctrine\ORM\Event\PostFlushEventArgs;
9
-
10 9
 use Symfony\Component\PropertyAccess\PropertyAccess;
11 10
 use Symfony\Component\PropertyAccess\PropertyAccessorInterface;
12
-
13 11
 use Oro\Bundle\ActivityBundle\Event\ActivityEvent;
14 12
 use Oro\Bundle\EntityBundle\ORM\DoctrineHelper;
15 13
 use Oro\Bundle\EntityConfigBundle\Config\ConfigManager;
16
-
17 14
 use OroCRM\Bundle\ActivityContactBundle\Model\TargetExcludeList;
18 15
 use OroCRM\Bundle\ActivityContactBundle\Direction\DirectionProviderInterface;
19 16
 use OroCRM\Bundle\ActivityContactBundle\EntityConfig\ActivityScope;
Please login to merge, or discard this patch.
OroCRM/Bundle/MagentoBundle/Provider/Iterator/AbstractBridgeIterator.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,9 +3,7 @@
 block discarded – undo
3 3
 namespace OroCRM\Bundle\MagentoBundle\Provider\Iterator;
4 4
 
5 5
 use Oro\Bundle\IntegrationBundle\Utils\ConverterUtils;
6
-
7 6
 use OroCRM\Bundle\MagentoBundle\Provider\BatchFilterBag;
8
-use OroCRM\Bundle\MagentoBundle\Provider\Transport\ServerTimeAwareInterface;
9 7
 use OroCRM\Bundle\MagentoBundle\Provider\Transport\SoapTransport;
10 8
 
11 9
 abstract class AbstractBridgeIterator extends AbstractPageableSoapIterator implements PredefinedFiltersAwareInterface
Please login to merge, or discard this patch.
Bundle/MagentoBundle/Provider/Iterator/AbstractPageableSoapIterator.php 2 patches
Doc Comments   +5 added lines, -2 removed lines patch added patch discarded remove patch
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
     /**
262 262
      * Load entities ids list
263 263
      *
264
-     * @return true|null true when there are ids retrieved
264
+     * @return null|boolean true when there are ids retrieved
265 265
      */
266 266
     protected function findEntitiesToProcess()
267 267
     {
@@ -294,7 +294,7 @@  discard block
 block discarded – undo
294 294
     /**
295 295
      * Retrieve store ids for given website
296 296
      *
297
-     * @param $websiteId
297
+     * @param integer $websiteId
298 298
      *
299 299
      * @return array
300 300
      * @throws \LogicException
@@ -402,6 +402,9 @@  discard block
 block discarded – undo
402 402
         return $toDate;
403 403
     }
404 404
 
405
+    /**
406
+     * @param \DateTime $dateToSync
407
+     */
405 408
     protected function getToDate($dateToSync)
406 409
     {
407 410
         $dateTo = clone $dateToSync;
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use Psr\Log\LoggerAwareInterface;
6 6
 use Psr\Log\LoggerAwareTrait;
7 7
 use Psr\Log\NullLogger;
8
-
9 8
 use OroCRM\Bundle\MagentoBundle\Provider\BatchFilterBag;
10 9
 use OroCRM\Bundle\MagentoBundle\Provider\Transport\ServerTimeAwareInterface;
11 10
 use OroCRM\Bundle\MagentoBundle\Provider\Transport\SoapTransport;
Please login to merge, or discard this patch.
MagentoBundle/Provider/Iterator/NewsletterSubscriberBridgeIterator.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -160,7 +160,7 @@
 block discarded – undo
160 160
      * Fix time frame if it's possible to retrieve server time.
161 161
      *
162 162
      * @param string $dateField
163
-     * @return bool | \DateTime
163
+     * @return \DateTime | \DateTime
164 164
      */
165 165
     protected function fixServerTime($dateField)
166 166
     {
Please login to merge, or discard this patch.
src/OroCRM/Bundle/MagentoBundle/Provider/MagentoSyncProcessor.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -154,7 +154,7 @@
 block discarded – undo
154 154
 
155 155
     /**
156 156
      * @param $syncedTo
157
-     * @param $interval
157
+     * @param \DateInterval $interval
158 158
      * @return mixed
159 159
      */
160 160
     protected function getIncrementalSyncedTo($syncedTo, $interval)
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -3,9 +3,7 @@  discard block
 block discarded – undo
3 3
 namespace OroCRM\Bundle\MagentoBundle\Provider;
4 4
 
5 5
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
6
-
7 6
 use Doctrine\Common\Persistence\ManagerRegistry;
8
-
9 7
 use Oro\Bundle\IntegrationBundle\Entity\Channel as Integration;
10 8
 use Oro\Bundle\ImportExportBundle\Processor\ProcessorRegistry;
11 9
 use Oro\Bundle\IntegrationBundle\ImportExport\Job\Executor;
@@ -14,7 +12,6 @@  discard block
 block discarded – undo
14 12
 use Oro\Bundle\IntegrationBundle\Provider\SyncProcessor;
15 13
 use Oro\Bundle\IntegrationBundle\Entity\Repository\ChannelRepository;
16 14
 use Oro\Bundle\IntegrationBundle\Entity\Status;
17
-
18 15
 use OroCRM\Bundle\MagentoBundle\Entity\MagentoSoapTransport;
19 16
 
20 17
 class MagentoSyncProcessor extends SyncProcessor
Please login to merge, or discard this patch.