Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
19 | class EmailCampaignController extends Controller |
||
20 | { |
||
21 | /** |
||
22 | * @Route("/", name="orocrm_email_campaign_index") |
||
23 | * @AclAncestor("orocrm_email_campaign_view") |
||
24 | * @Template |
||
25 | */ |
||
26 | public function indexAction() |
||
32 | |||
33 | /** |
||
34 | * Create email campaign |
||
35 | * |
||
36 | * @Route("/create", name="orocrm_email_campaign_create") |
||
37 | * @Template("OroCRMCampaignBundle:EmailCampaign:update.html.twig") |
||
38 | * @Acl( |
||
39 | * id="orocrm_email_campaign_create", |
||
40 | * type="entity", |
||
41 | * permission="CREATE", |
||
42 | * class="OroCRMCampaignBundle:EmailCampaign" |
||
43 | * ) |
||
44 | */ |
||
45 | public function createAction() |
||
49 | |||
50 | /** |
||
51 | * Edit email campaign |
||
52 | * |
||
53 | * @Route("/update/{id}", name="orocrm_email_campaign_update", requirements={"id"="\d+"}, defaults={"id"=0}) |
||
54 | * @Template |
||
55 | * @Acl( |
||
56 | * id="orocrm_email_campaign_update", |
||
57 | * type="entity", |
||
58 | * permission="EDIT", |
||
59 | * class="OroCRMCampaignBundle:EmailCampaign" |
||
60 | * ) |
||
61 | * @param EmailCampaign $entity |
||
62 | * @return array |
||
63 | */ |
||
64 | public function updateAction(EmailCampaign $entity) |
||
68 | |||
69 | /** |
||
70 | * View email campaign |
||
71 | * |
||
72 | * @Route("/view/{id}", name="orocrm_email_campaign_view", requirements={"id"="\d+"}) |
||
73 | * @Acl( |
||
74 | * id="orocrm_email_campaign_view", |
||
75 | * type="entity", |
||
76 | * permission="VIEW", |
||
77 | * class="OroCRMCampaignBundle:EmailCampaign" |
||
78 | * ) |
||
79 | * @Template |
||
80 | * @param EmailCampaign $entity |
||
81 | * @return array |
||
82 | */ |
||
83 | public function viewAction(EmailCampaign $entity) |
||
96 | |||
97 | /** |
||
98 | * Process save email campaign entity |
||
99 | * |
||
100 | * @param EmailCampaign $entity |
||
101 | * @return array |
||
102 | */ |
||
103 | View Code Duplication | protected function update(EmailCampaign $entity) |
|
120 | |||
121 | /** |
||
122 | * Returns form instance |
||
123 | * |
||
124 | * @return FormInterface |
||
125 | */ |
||
126 | protected function getForm() |
||
140 | |||
141 | /** |
||
142 | * @Route("/send/{id}", name="orocrm_email_campaign_send", requirements={"id"="\d+"}) |
||
143 | * @Acl( |
||
144 | * id="orocrm_email_campaign_send", |
||
145 | * type="action", |
||
146 | * label="orocrm.campaign.acl.send_emails.label", |
||
147 | * description="orocrm.campaign.acl.send_emails.description", |
||
148 | * group_name="" |
||
149 | * ) |
||
150 | * |
||
151 | * @param EmailCampaign $entity |
||
152 | * @return array |
||
153 | */ |
||
154 | public function sendAction(EmailCampaign $entity) |
||
179 | |||
180 | /** |
||
181 | * @param EmailCampaign $entity |
||
182 | * @return bool |
||
183 | */ |
||
184 | protected function isManualSendAllowed(EmailCampaign $entity) |
||
201 | } |
||
202 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.