OroCRM\Bundle\CallBundle\Controller\CallController

Complexity

Total Complexity

14

Size/Duplication

Total Lines	185
Duplicated Lines	18.38 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	activityAction()	0	6	1
A	createAction()	0	19	1
A	updateAction()	0	6	1
A	indexAction()	0	6	1
A	viewAction()	0	6	1
A	callsAction()	0	6	1
A	baseCallsAction()	0	6	1
A	infoAction()	0	8	1
A	update()	23	23	3
A	getTargetEntity()	11	11	3

<?php

namespace OroCRM\Bundle\CallBundle\Controller;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;

use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;

use Oro\Bundle\SecurityBundle\Annotation\Acl;
use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;

use OroCRM\Bundle\CallBundle\Entity\Call;

class CallController extends Controller
{
    /**
     * This action is used to render the list of calls associated with the given entity
     * on the view page of this entity
     *
     * @Route("/activity/view/{entityClass}/{entityId}", name="orocrm_call_activity_view")
     * @AclAncestor("orocrm_call_view")
     * @Template
     */
    public function activityAction($entityClass, $entityId)
    {
        return array(
            'entity' => $this->get('oro_entity.routing_helper')->getEntity($entityClass, $entityId)
        );
    }

    /**
     * @Route("/create", name="orocrm_call_create")
     * @Template("OroCRMCallBundle:Call:update.html.twig")
     * @Acl(
     *      id="orocrm_call_create",
     *      type="entity",
     *      permission="CREATE",
     *      class="OroCRMCallBundle:Call"
     * )
     */
    public function createAction()
    {
        $entity = new Call();

        $callStatus = $this->getDoctrine()

The method findOneByName() does not exist on Doctrine\Common\Persistence\ObjectRepository. Did you maybe mean findOneBy()?

            ->getRepository('OroCRMCallBundle:CallStatus')
            ->findOneByName('completed');
        $entity->setCallStatus($callStatus);

        $callDirection = $this->getDoctrine()

The method findOneByName() does not exist on Doctrine\Common\Persistence\ObjectRepository. Did you maybe mean findOneBy()?

            ->getRepository('OroCRMCallBundle:CallDirection')
            ->findOneByName('outgoing');
        $entity->setDirection($callDirection);

        $formAction = $this->get('oro_entity.routing_helper')
            ->generateUrlByRequest('orocrm_call_create', $this->getRequest());

The method Symfony\Bundle\FrameworkBundle\Controller\Controller::getRequest() has been deprecated with message: since version 2.4, to be removed in 3.0. Ask Symfony to inject the Request object into your controller method instead by type hinting it in the method's signature.

        return $this->update($entity, $formAction);
    }

    /**
     * @Route("/update/{id}", name="orocrm_call_update", requirements={"id"="\d+"})
     * @Template
     * @Acl(
     *      id="orocrm_call_update",
     *      type="entity",
     *      permission="EDIT",
     *      class="OroCRMCallBundle:Call"
     * )
     */
    public function updateAction(Call $entity)
    {
        $formAction = $this->get('router')->generate('orocrm_call_update', ['id' => $entity->getId()]);

        return $this->update($entity, $formAction);
    }

    /**
     * @Route(name="orocrm_call_index")
     * @Template
     * @Acl(
     *      id="orocrm_call_view",
     *      type="entity",
     *      permission="VIEW",
     *      class="OroCRMCallBundle:Call"
     * )
     */
    public function indexAction()
    {
        return array(
            'entity_class' => $this->container->getParameter('orocrm_call.call.entity.class')
        );
    }

    /**
     * @Route("/view/{id}", name="orocrm_call_view")
     * @Template
     */
    public function viewAction(Call $entity)
    {
        return [
            'entity' => $entity,
        ];
    }

    /**
     * @Route("/widget", name="orocrm_call_widget_calls")
     * @Template
     * @AclAncestor("orocrm_call_view")
     *
     * @param Request $request
     * @return array
     */
    public function callsAction(Request $request)
    {
        return array(
            'datagridParameters' => $request->query->all()
        );
    }

    /**
     * @Route("/base-widget", name="orocrm_call_base_widget_calls")
     * @Template
     * @AclAncestor("orocrm_call_view")
     */
    public function baseCallsAction(Request $request)
    {
        return array(
            'datagridParameters' => $request->query->all()
        );
    }

    /**
     * @Route(
     *      "/widget/info/{id}/{renderContexts}",
     *      name="orocrm_call_widget_info",
     *      requirements={"id"="\d+", "renderContexts"="\d+"},
     *      defaults={"renderContexts"=true}
     * )
     * @Template("OroCRMCallBundle:Call/widget:info.html.twig")
     * @AclAncestor("orocrm_call_view")
     */
    public function infoAction(Call $entity, $renderContexts)
    {
        return [
            'entity'         => $entity,
            'target'         => $this->getTargetEntity(),
            'renderContexts' => (bool)$renderContexts
        ];
    }

    /**
     * @param Call   $entity
     * @param string $formAction
     *
     * @return array
     */
    protected function update(Call $entity, $formAction)

This method seems to be duplicated in your project.

    {
        $saved = false;

        if ($this->get('orocrm_call.call.form.handler')->process($entity)) {
            if (!$this->getRequest()->get('_widgetContainer')) {

The method Symfony\Bundle\FrameworkBundle\Controller\Controller::getRequest() has been deprecated with message: since version 2.4, to be removed in 3.0. Ask Symfony to inject the Request object into your controller method instead by type hinting it in the method's signature.

                $this->get('session')->getFlashBag()->add(
                    'success',
                    $this->get('translator')->trans('orocrm.call.controller.call.saved.message')
                );

                return $this->get('oro_ui.router')->redirect($entity);
            }
            $saved = true;
        }

        return array(
            'entity'     => $entity,
            'saved'      => $saved,
            'form'       => $this->get('orocrm_call.call.form.handler')->getForm()->createView(),
            'formAction' => $formAction
        );
    }

    /**
     * Get target entity
     *
     * @return object|null
     */
    protected function getTargetEntity()

This method seems to be duplicated in your project.

    {
        $entityRoutingHelper = $this->get('oro_entity.routing_helper');
        $targetEntityClass   = $entityRoutingHelper->getEntityClassName($this->getRequest(), 'targetActivityClass');

The method Symfony\Bundle\FrameworkBundle\Controller\Controller::getRequest() has been deprecated with message: since version 2.4, to be removed in 3.0. Ask Symfony to inject the Request object into your controller method instead by type hinting it in the method's signature.

        $targetEntityId      = $entityRoutingHelper->getEntityId($this->getRequest(), 'targetActivityId');

The method Symfony\Bundle\FrameworkBundle\Controller\Controller::getRequest() has been deprecated with message: since version 2.4, to be removed in 3.0. Ask Symfony to inject the Request object into your controller method instead by type hinting it in the method's signature.

        if (!$targetEntityClass || !$targetEntityId) {
            return null;
        }

        return $entityRoutingHelper->getEntity($targetEntityClass, $targetEntityId);
    }
}