OroCRM\Bundle\ContactBundle\Form\Handler\ContactEmailHandler

Complexity

Total Complexity

12

Size/Duplication

Total Lines	114
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes	8
Bugs	4	Features	3

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	13	13	1
C	process()	33	33	7
A	handleDelete()	16	16	3
A	onSuccess()	6	6	1

<?php

namespace OroCRM\Bundle\ContactBundle\Form\Handler;

use Doctrine\ORM\EntityManagerInterface;

use Symfony\Component\Form\FormInterface;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

use Oro\Bundle\SoapBundle\Entity\Manager\ApiEntityManager;
use Oro\Bundle\SecurityBundle\SecurityFacade;

use OroCRM\Bundle\ContactBundle\Validator\ContactEmailDeleteValidator;
use OroCRM\Bundle\ContactBundle\Entity\ContactEmail;
use OroCRM\Bundle\ContactBundle\Entity\Contact;

class ContactEmailHandler

This class seems to be duplicated in your project.

{
    /** @var FormInterface */
    protected $form;

    /** @var Request */
    protected $request;

    /** @var EntityManagerInterface */
    protected $manager;

    /** @var  ContactEmailDeleteValidator */
    protected $contactEmailDeleteValidator;

    /** @var SecurityFacade */
    protected $securityFacade;

    /**
     * @param FormInterface $form
     * @param Request $request
     * @param EntityManagerInterface $manager
     * @param ContactEmailDeleteValidator $contactEmailDeleteValidator
     * @param SecurityFacade $securityFacade
     */
    public function __construct(
        FormInterface $form,
        Request $request,

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

        EntityManagerInterface $manager,
        ContactEmailDeleteValidator $contactEmailDeleteValidator,
        SecurityFacade $securityFacade
    ) {
        $this->form    = $form;
        $this->request = $request;
        $this->manager = $manager;
        $this->contactEmailDeleteValidator = $contactEmailDeleteValidator;
        $this->securityFacade = $securityFacade;
    }

    /**
     * Process form
     *
     * @param ContactEmail $entity
     *
     * @return bool True on successful processing, false otherwise
     *
     * @throws AccessDeniedException
     */
    public function process(ContactEmail $entity)
    {
        $this->form->setData($entity);

        $submitData = [
            'email' => $this->request->request->get('email'),
            'primary' => $this->request->request->get('primary')
        ];

        if (in_array($this->request->getMethod(), ['POST', 'PUT'])) {
            $this->form->submit($submitData);

            if ($this->form->isValid() && $this->request->request->get('contactId')) {
                $contact = $this->manager->find(
                    'OroCRMContactBundle:Contact',
                    $this->request->request->get('contactId')
                );
                if (!$this->securityFacade->isGranted('EDIT', $contact)) {
                    throw new AccessDeniedException();
                }

                if ($contact->getPrimaryEmail() && $this->request->request->get('primary') === true) {
                    return false;
                }

                $this->onSuccess($entity, $contact);

                return true;
            }
        }

        return false;
    }

    /**
     * @param $id
     * @param ApiEntityManager $manager
     * @throws \Exception
     */
    public function handleDelete($id, ApiEntityManager $manager)
    {
        /** @var ContactEmail $contactEmail */
        $contactEmail = $manager->find($id);
        if (!$this->securityFacade->isGranted('EDIT', $contactEmail->getOwner())) {
            throw new AccessDeniedException();
        }

        if ($this->contactEmailDeleteValidator->validate($contactEmail)) {
            $em = $manager->getObjectManager();
            $em->remove($contactEmail);
            $em->flush();
        } else {
            throw new \Exception("oro.contact.email.error.delete.more_one", 500);
        }
    }

    /**
     * @param ContactEmail $entity
     * @param Contact $contact
     */
    protected function onSuccess(ContactEmail $entity, Contact $contact)
    {
        $entity->setOwner($contact);
        $this->manager->persist($entity);
        $this->manager->flush();
    }
}