CartControllerTest::gridProvider() - Code Metrics - Inspection of "Merge remote-tracking branch 'remotes/dev/master'" - orocrm/crm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9fc944...74d39c )

unknown

created 2016-10-26 06:11 UTC

CartControllerTest::gridProvider() B

↳ Parent: CartControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	91
Code Lines	59

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	91
rs	8.518
cc	1
eloc	59
nc	1
nop	0

How to fix Long Method

<?php

namespace Oro\Bundle\MagentoBundle\Tests\Functional\Controller;

use Oro\Bundle\OrganizationBundle\Entity\Organization;

/**
 * @outputBuffering enabled
 * @dbIsolation
 */
class CartControllerTest extends AbstractController
{
    /** @var \Oro\Bundle\MagentoBundle\Entity\Cart */
    public static $cart;

    protected function postFixtureLoad()
    {
        parent::postFixtureLoad();

        self::$cart = $this->getReference('cart');
    }

    /**
     * @afterClass
     */
    public function clear()
    {
        self::$cart = null;
        gc_collect_cycles();
    }

    /**
     * @return int
     */
    protected function getMainEntityId()
    {
        $this->assertNotEmpty(self::$cart);

        return self::$cart->getId();
    }

    public function testView()
    {
        $this->client->request(
            'GET',
            $this->getUrl(
                'oro_magento_cart_view',
                ['id' => $this->getMainEntityId(), 'isRemoved' => 0]
            )
        );
        $result = $this->client->getResponse();
        $this->assertHtmlResponseStatusCodeEquals($result, 200);
        $this->assertContains('Cart Information', $result->getContent());
        $this->assertContains('[email protected]', $result->getContent());
        $this->assertContains('Customer Information', $result->getContent());
        $this->assertContains('[email protected]', $result->getContent());
        $this->assertContains('Cart Items', $result->getContent());
        $this->assertContains('Demo Web store', $result->getContent());
        $this->assertContains('Sync Data', $result->getContent());
        $this->assertContains('Open', $result->getContent());
        $this->assertContains('web site', $result->getContent());
        $this->assertContains('demo store', $result->getContent());
        $this->assertContains('Send email', $result->getContent());

        $filteredHtml = str_replace(['<br/>', '<br />'], ' ', $result->getContent());

        /** @var Organization $organization */
        $organization = $this->client
            ->getContainer()
            ->get('doctrine')
            ->getRepository('OroOrganizationBundle:Organization')
            ->getFirst();

        $this->assertContains(
            'John Doe ' . $organization->getName() . ' street CITY AZ US 123456',
            preg_replace('#\s+#', ' ', $filteredHtml)
        );
    }

    /**
     * {@inheritdoc}
     *
     * @dataProvider gridProvider
     */
    public function testGrid($requestData)
    {
        parent::testGrid($requestData);
    }

    public function gridProvider()
    {
        return [
            'Magento cart grid' => [
                [
                    'gridParameters' => [
                        'gridName' => 'magento-cart-grid',
                        'magento-cart-grid[_sort_by][originId]' => 'ASC',
                    ],
                    'gridFilters' => [],
                    'asserts' => [
                        [
                            'channelName' => 'Magento channel',
                            'firstName' => 'John',
                            'lastName' => 'Doe',
                            'email' => '[email protected]',
                            'regionName' => 'Arizona'
                        ],
                        [
                            'channelName' => 'Magento channel',
                            'firstName' => 'Guest Jack',
                            'lastName' => 'Guest White',
                            'email' => '[email protected]',
                            'regionName' => 'Arizona'
                        ]
                    ],
                    'expectedResultCount' => 2
                ],
            ],
            'Magento cart grid with filters' => [
                [
                    'gridParameters' => [
                        'gridName' => 'magento-cart-grid'
                    ],
                    'gridFilters' => [
                        'magento-cart-grid[_filter][lastName][value]' => 'Doe',
                        'magento-cart-grid[_filter][firstName][value]' => 'John'
                    ],
                    'assert' => [
                        'channelName' => 'Magento channel',
                        'firstName' => 'John',
                        'lastName' => 'Doe',
                        'email' => '[email protected]',
                        'regionName' => 'Arizona'
                    ],
                    'expectedResultCount' => 1
                ],
            ],
            'Magento cart grid with filters without result' => [
                [
                    'gridParameters' => [
                        'gridName' => 'magento-cart-grid'
                    ],
                    'gridFilters' => [
                        'magento-cart-grid[_filter][lastName][value]' => 'Doe',
                        'magento-cart-grid[_filter][firstName][value]' => 'Doe'
                    ],
                    'assert' => [],
                    'expectedResultCount' => 0
                ]
            ],
            'Cart item grid' => [
                [
                    'gridParameters' => [
                        'gridName' => 'magento-cartitem-active-grid',
                        'id' => 'id',
                    ],
                    'gridFilters' => [],
                    'assert' => [
                        'sku' => 'sku',
                        'qty' => 0,
                        'rowTotal' => 'USD 100.00',
                        'taxAmount' => 'USD 10.00',
                        'discountAmount' => 'USD 0.00'
                    ],
                    'expectedResultCount' => 1
                ],
            ],
            'Cart item grid removed' => [
                [
                    'gridParameters' => [
                        'gridName' => 'magento-cartitem-removed-grid',
                        'id' => 'id',
                    ],
                    'gridFilters' => [],
                    'assert' => [],
                    'expectedResultCount' => 0
                ],
            ],
        ];
    }
}


1			<?php
2
3			namespace Oro\Bundle\MagentoBundle\Tests\Functional\Controller;
4
5			use Oro\Bundle\OrganizationBundle\Entity\Organization;
6
7			/**
8			* @outputBuffering enabled
9			* @dbIsolation
10			*/
11			class CartControllerTest extends AbstractController
12			{
13			/** @var \Oro\Bundle\MagentoBundle\Entity\Cart */
14			public static $cart;
15
16			protected function postFixtureLoad()
17			{
18			parent::postFixtureLoad();
19
20			self::$cart = $this->getReference('cart');
21			}
22
23			/**
24			* @afterClass
25			*/
26			public function clear()
27			{
28			self::$cart = null;
29			gc_collect_cycles();
30			}
31
32			/**
33			* @return int
34			*/
35			protected function getMainEntityId()
36			{
37			$this->assertNotEmpty(self::$cart);
38
39			return self::$cart->getId();
40			}
41
42			public function testView()
43			{
44			$this->client->request(
45			'GET',
46			$this->getUrl(
47			'oro_magento_cart_view',
48			['id' => $this->getMainEntityId(), 'isRemoved' => 0]
49			)
50			);
51			$result = $this->client->getResponse();
52			$this->assertHtmlResponseStatusCodeEquals($result, 200);
53			$this->assertContains('Cart Information', $result->getContent());
54			$this->assertContains('[email protected]', $result->getContent());
55			$this->assertContains('Customer Information', $result->getContent());
56			$this->assertContains('[email protected]', $result->getContent());
57			$this->assertContains('Cart Items', $result->getContent());
58			$this->assertContains('Demo Web store', $result->getContent());
59			$this->assertContains('Sync Data', $result->getContent());
60			$this->assertContains('Open', $result->getContent());
61			$this->assertContains('web site', $result->getContent());
62			$this->assertContains('demo store', $result->getContent());
63			$this->assertContains('Send email', $result->getContent());
64
65			$filteredHtml = str_replace(['<br/>', '<br />'], ' ', $result->getContent());
66
67			/** @var Organization $organization */
68			$organization = $this->client
69			->getContainer()
70			->get('doctrine')
71			->getRepository('OroOrganizationBundle:Organization')
72			->getFirst();
73
74			$this->assertContains(
75			'John Doe ' . $organization->getName() . ' street CITY AZ US 123456',
76			preg_replace('#\s+#', ' ', $filteredHtml)
77			);
78			}
79
80			/**
81			* {@inheritdoc}
82			*
83			* @dataProvider gridProvider
84			*/
85			public function testGrid($requestData)
86			{
87			parent::testGrid($requestData);
88			}
89
90			public function gridProvider()
91			{
92			return [
93			'Magento cart grid' => [
94			[
95			'gridParameters' => [
96			'gridName' => 'magento-cart-grid',
97			'magento-cart-grid[_sort_by][originId]' => 'ASC',
98			],
99			'gridFilters' => [],
100			'asserts' => [
101			[
102			'channelName' => 'Magento channel',
103			'firstName' => 'John',
104			'lastName' => 'Doe',
105			'email' => '[email protected]',
106			'regionName' => 'Arizona'
107			],
108			[
109			'channelName' => 'Magento channel',
110			'firstName' => 'Guest Jack',
111			'lastName' => 'Guest White',
112			'email' => '[email protected]',
113			'regionName' => 'Arizona'
114			]
115			],
116			'expectedResultCount' => 2
117			],
118			],
119			'Magento cart grid with filters' => [
120			[
121			'gridParameters' => [
122			'gridName' => 'magento-cart-grid'
123			],
124			'gridFilters' => [
125			'magento-cart-grid[_filter][lastName][value]' => 'Doe',
126			'magento-cart-grid[_filter][firstName][value]' => 'John'
127			],
128			'assert' => [
129			'channelName' => 'Magento channel',
130			'firstName' => 'John',
131			'lastName' => 'Doe',
132			'email' => '[email protected]',
133			'regionName' => 'Arizona'
134			],
135			'expectedResultCount' => 1
136			],
137			],
138			'Magento cart grid with filters without result' => [
139			[
140			'gridParameters' => [
141			'gridName' => 'magento-cart-grid'
142			],
143			'gridFilters' => [
144			'magento-cart-grid[_filter][lastName][value]' => 'Doe',
145			'magento-cart-grid[_filter][firstName][value]' => 'Doe'
146			],
147			'assert' => [],
148			'expectedResultCount' => 0
149			]
150			],
151			'Cart item grid' => [
152			[
153			'gridParameters' => [
154			'gridName' => 'magento-cartitem-active-grid',
155			'id' => 'id',
156			],
157			'gridFilters' => [],
158			'assert' => [
159			'sku' => 'sku',
160			'qty' => 0,
161			'rowTotal' => 'USD 100.00',
162			'taxAmount' => 'USD 10.00',
163			'discountAmount' => 'USD 0.00'
164			],
165			'expectedResultCount' => 1
166			],
167			],
168			'Cart item grid removed' => [
169			[
170			'gridParameters' => [
171			'gridName' => 'magento-cartitem-removed-grid',
172			'id' => 'id',
173			],
174			'gridFilters' => [],
175			'assert' => [],
176			'expectedResultCount' => 0
177			],
178			],
179			];
180			}
181			}
182

orocrm / crm

Push — master ( 9fc944...74d39c )

CartControllerTest::gridProvider() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like