CallActivityListProvider::getActivityOwners() - Code Metrics - Inspection of "Merge remote-tracking branch 'remotes/dev/1.8' int..." - orocrm/crm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.8 ( 8d6730...a2d9e7 )

unknown

created 2017-06-12 13:53 UTC

CallActivityListProvider::getActivityOwners() A

↳ Parent: CallActivityListProvider

Complexity

Conditions	3
Paths	2

Size

Total Lines	15
Code Lines	10

Duplication

Lines	15
Ratio	100 %

Importance

Changes

Metric	Value
dl	15
loc	15
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	10
nc	2
nop	2

<?php

namespace OroCRM\Bundle\CallBundle\Provider;

use Oro\Bundle\ActivityBundle\Tools\ActivityAssociationHelper;
use Oro\Bundle\ActivityListBundle\Entity\ActivityList;
use Oro\Bundle\ActivityListBundle\Model\ActivityListProviderInterface;
use Oro\Bundle\ActivityListBundle\Entity\ActivityOwner;
use Oro\Bundle\CommentBundle\Model\CommentProviderInterface;
use Oro\Bundle\CommentBundle\Tools\CommentAssociationHelper;
use Oro\Bundle\EntityBundle\ORM\DoctrineHelper;
use Oro\Bundle\EntityConfigBundle\DependencyInjection\Utils\ServiceLink;

use OroCRM\Bundle\CallBundle\Entity\Call;

class CallActivityListProvider implements ActivityListProviderInterface, CommentProviderInterface

{
    const ACTIVITY_CLASS = 'OroCRM\Bundle\CallBundle\Entity\Call';
    const ACL_CLASS = 'OroCRM\Bundle\CallBundle\Entity\Call';

    /** @var DoctrineHelper */
    protected $doctrineHelper;

    /** @var ServiceLink */
    protected $entityOwnerAccessorLink;

    /** @var ActivityAssociationHelper */
    protected $activityAssociationHelper;

    /** @var CommentAssociationHelper */
    protected $commentAssociationHelper;

    /**
     * @param DoctrineHelper            $doctrineHelper
     * @param ServiceLink               $entityOwnerAccessorLink
     * @param ActivityAssociationHelper $activityAssociationHelper
     * @param CommentAssociationHelper  $commentAssociationHelper
     */
    public function __construct(
        DoctrineHelper $doctrineHelper,
        ServiceLink $entityOwnerAccessorLink,
        ActivityAssociationHelper $activityAssociationHelper,
        CommentAssociationHelper $commentAssociationHelper
    ) {
        $this->doctrineHelper            = $doctrineHelper;
        $this->entityOwnerAccessorLink   = $entityOwnerAccessorLink;
        $this->activityAssociationHelper = $activityAssociationHelper;
        $this->commentAssociationHelper  = $commentAssociationHelper;
    }

    /**
     * {@inheritdoc}
     */
    public function isApplicableTarget($entityClass, $accessible = true)
    {
        return $this->activityAssociationHelper->isActivityAssociationEnabled(
            $entityClass,
            self::ACTIVITY_CLASS,
            $accessible
        );
    }

    /**
     * {@inheritdoc}
     */
    public function getSubject($entity)
    {
        /** @var $entity Call */
        return $entity->getSubject();
    }

    /**
     * {@inheritdoc}
     */
    public function getDescription($entity)
    {
        /** @var $entity Call */
        return $entity->getNotes();
    }

    /**
     * {@inheritdoc}
     */
    public function getData(ActivityList $activityListEntity)
    {
        return [];
    }

    /**
     * {@inheritdoc}
     */
    public function getOrganization($activityEntity)
    {
        /** @var $activityEntity Call */
        return $activityEntity->getOrganization();
    }

    /**
     * {@inheritdoc}
     */
    public function getTemplate()
    {
        return 'OroCRMCallBundle:Call:js/activityItemTemplate.js.twig';
    }

    /**
     * {@inheritdoc}
     */
    public function getRoutes()
    {
        return [
            'itemView'   => 'orocrm_call_widget_info',
            'itemEdit'   => 'orocrm_call_update',
            'itemDelete' => 'oro_api_delete_call'
        ];
    }

    /**
     * {@inheritdoc}
     */
    public function getActivityClass()
    {
        return self::ACTIVITY_CLASS;
    }

    /**
     * {@inheritdoc}
     */
    public function getAclClass()
    {
        return self::ACL_CLASS;
    }

    /**
     * {@inheritdoc}
     */
    public function getActivityId($entity)
    {
        return $this->doctrineHelper->getSingleEntityIdentifier($entity);
    }

    /**
     * {@inheritdoc}
     */
    public function isApplicable($entity)
    {
        if (is_object($entity)) {
            $entity = $this->doctrineHelper->getEntityClass($entity);
        }

        return $entity == self::ACTIVITY_CLASS;
    }

    /**
     * {@inheritdoc}
     */
    public function getTargetEntities($entity)
    {
        return $entity->getActivityTargetEntities();
    }

    /**
     * {@inheritdoc}
     */
    public function isCommentsEnabled($entityClass)
    {
        return $this->commentAssociationHelper->isCommentAssociationEnabled($entityClass);
    }

    /**
     * {@inheritdoc}
     */
    public function getActivityOwners($entity, ActivityList $activityList)
    {
        $organization = $this->getOrganization($entity);
        $owner = $this->entityOwnerAccessorLink->getService()->getOwner($entity);

        if (!$organization || !$owner) {
            return [];
        }

        $activityOwner = new ActivityOwner();
        $activityOwner->setActivity($activityList);
        $activityOwner->setOrganization($organization);
        $activityOwner->setUser($owner);
        return [$activityOwner];
    }
}


1		<?php
2
3		namespace OroCRM\Bundle\CallBundle\Provider;
4
5		use Oro\Bundle\ActivityBundle\Tools\ActivityAssociationHelper;
6		use Oro\Bundle\ActivityListBundle\Entity\ActivityList;
7		use Oro\Bundle\ActivityListBundle\Model\ActivityListProviderInterface;
8		use Oro\Bundle\ActivityListBundle\Entity\ActivityOwner;
9		use Oro\Bundle\CommentBundle\Model\CommentProviderInterface;
10		use Oro\Bundle\CommentBundle\Tools\CommentAssociationHelper;
11		use Oro\Bundle\EntityBundle\ORM\DoctrineHelper;
12		use Oro\Bundle\EntityConfigBundle\DependencyInjection\Utils\ServiceLink;
13
14		use OroCRM\Bundle\CallBundle\Entity\Call;
15
16	View Code Duplication	class CallActivityListProvider implements ActivityListProviderInterface, CommentProviderInterface
		0 ignored issues – show Bug introduced 2017-06-12 14:34 UTC by Report Bug Copy Issue Report There is one abstract method `hasComments` in this class; you could implement it, or declare this class as abstract. Loading history... Duplication introduced 2015-12-23 15:22 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
17		{
18		const ACTIVITY_CLASS = 'OroCRM\Bundle\CallBundle\Entity\Call';
19		const ACL_CLASS = 'OroCRM\Bundle\CallBundle\Entity\Call';
20
21		/** @var DoctrineHelper */
22		protected $doctrineHelper;
23
24		/** @var ServiceLink */
25		protected $entityOwnerAccessorLink;
26
27		/** @var ActivityAssociationHelper */
28		protected $activityAssociationHelper;
29
30		/** @var CommentAssociationHelper */
31		protected $commentAssociationHelper;
32
33		/**
34		* @param DoctrineHelper $doctrineHelper
35		* @param ServiceLink $entityOwnerAccessorLink
36		* @param ActivityAssociationHelper $activityAssociationHelper
37		* @param CommentAssociationHelper $commentAssociationHelper
38		*/
39		public function __construct(
40		DoctrineHelper $doctrineHelper,
41		ServiceLink $entityOwnerAccessorLink,
42		ActivityAssociationHelper $activityAssociationHelper,
43		CommentAssociationHelper $commentAssociationHelper
44		) {
45		$this->doctrineHelper = $doctrineHelper;
46		$this->entityOwnerAccessorLink = $entityOwnerAccessorLink;
47		$this->activityAssociationHelper = $activityAssociationHelper;
48		$this->commentAssociationHelper = $commentAssociationHelper;
49		}
50
51		/**
52		* {@inheritdoc}
53		*/
54		public function isApplicableTarget($entityClass, $accessible = true)
55		{
56		return $this->activityAssociationHelper->isActivityAssociationEnabled(
57		$entityClass,
58		self::ACTIVITY_CLASS,
59		$accessible
60		);
61		}
62
63		/**
64		* {@inheritdoc}
65		*/
66		public function getSubject($entity)
67		{
68		/** @var $entity Call */
69		return $entity->getSubject();
70		}
71
72		/**
73		* {@inheritdoc}
74		*/
75		public function getDescription($entity)
76		{
77		/** @var $entity Call */
78		return $entity->getNotes();
79		}
80
81		/**
82		* {@inheritdoc}
83		*/
84		public function getData(ActivityList $activityListEntity)
85		{
86		return [];
87		}
88
89		/**
90		* {@inheritdoc}
91		*/
92		public function getOrganization($activityEntity)
93		{
94		/** @var $activityEntity Call */
95		return $activityEntity->getOrganization();
96		}
97
98		/**
99		* {@inheritdoc}
100		*/
101		public function getTemplate()
102		{
103		return 'OroCRMCallBundle:Call:js/activityItemTemplate.js.twig';
104		}
105
106		/**
107		* {@inheritdoc}
108		*/
109		public function getRoutes()
110		{
111		return [
112		'itemView' => 'orocrm_call_widget_info',
113		'itemEdit' => 'orocrm_call_update',
114		'itemDelete' => 'oro_api_delete_call'
115		];
116		}
117
118		/**
119		* {@inheritdoc}
120		*/
121		public function getActivityClass()
122		{
123		return self::ACTIVITY_CLASS;
124		}
125
126		/**
127		* {@inheritdoc}
128		*/
129		public function getAclClass()
130		{
131		return self::ACL_CLASS;
132		}
133
134		/**
135		* {@inheritdoc}
136		*/
137		public function getActivityId($entity)
138		{
139		return $this->doctrineHelper->getSingleEntityIdentifier($entity);
140		}
141
142		/**
143		* {@inheritdoc}
144		*/
145		public function isApplicable($entity)
146		{
147		if (is_object($entity)) {
148		$entity = $this->doctrineHelper->getEntityClass($entity);
149		}
150
151		return $entity == self::ACTIVITY_CLASS;
152		}
153
154		/**
155		* {@inheritdoc}
156		*/
157		public function getTargetEntities($entity)
158		{
159		return $entity->getActivityTargetEntities();
160		}
161
162		/**
163		* {@inheritdoc}
164		*/
165		public function isCommentsEnabled($entityClass)
166		{
167		return $this->commentAssociationHelper->isCommentAssociationEnabled($entityClass);
168		}
169
170		/**
171		* {@inheritdoc}
172		*/
173		public function getActivityOwners($entity, ActivityList $activityList)
174		{
175		$organization = $this->getOrganization($entity);
176		$owner = $this->entityOwnerAccessorLink->getService()->getOwner($entity);
177
178		if (!$organization \|\| !$owner) {
179		return [];
180		}
181
182		$activityOwner = new ActivityOwner();
183		$activityOwner->setActivity($activityList);
184		$activityOwner->setOrganization($organization);
185		$activityOwner->setUser($owner);
186		return [$activityOwner];
187		}
188		}
189

orocrm / crm

Push — 1.8 ( 8d6730...a2d9e7 )

CallActivityListProvider::getActivityOwners() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like