OroCRM\Bundle\MagentoBundle\Tests\Unit\DependencyInjection\OroCRMMagentoExtensionTest

Complexity

Total Complexity

8

Size/Duplication

Total Lines	157
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	1
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	testInvalidAccountDiscoveryConfiguration()	0	23	1
B	testInheritanceConfiguration()	0	31	3
A	inheritanceConfigurationDataProvider()	0	47	1
B	testConfigPassedToConnectors()	0	37	3

<?php

namespace OroCRM\Bundle\MagentoBundle\Tests\Unit\DependencyInjection;

use OroCRM\Bundle\MagentoBundle\DependencyInjection\OroCRMMagentoExtension;
use OroCRM\Bundle\MagentoBundle\DependencyInjection\Configuration;

use Symfony\Component\DependencyInjection\ContainerBuilder;

class OroCRMMagentoExtensionTest extends \PHPUnit_Framework_TestCase
{
    public function testConfigPassedToConnectors()
    {
        $config = [
            'sync_settings' => [
                'mistiming_assumption_interval' => '10 minutes',
                'initial_import_step_interval' => '1 day',
                'region_sync_interval' => '1 day',
                'skip_ssl_verification' => false
            ]
        ];

        $container = new ContainerBuilder();
        $extension = new OroCRMMagentoExtension();

        $extension->load(['oro_crm_magento' => $config], $container);

        $tagged = $container->findTaggedServiceIds('orocrm_magento.bundle_config.aware');

        $missedConfigDefinitions = [];
        foreach (array_keys($tagged) as $serviceId) {
            $definition = $container->getDefinition($serviceId);

            $definition->getArguments();

The call to the method Symfony\Component\DependencyInjection\Definition::getArguments() seems un-needed as the method has no side-effects.

            $configArguments = array_filter(
                $definition->getArguments(),
                function ($arg) use ($config) {
                    return $arg === $config;
                }
            );

            if (!$configArguments) {

The expression $configArguments of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

                $missedConfigDefinitions[] = $serviceId;
            }
        }

        $this->assertEquals([], $missedConfigDefinitions, 'Should contain config array');
    }

    /**
     * @expectedException \Symfony\Component\Config\Definition\Exception\InvalidConfigurationException
     * @expectedExceptionMessage Strategy configuration contains unknown fields "unknown_field"
     */
    public function testInvalidAccountDiscoveryConfiguration()
    {
        $config = [
            [
                'account_discovery' => [
                    'fields'   => [
                        'field1' => null,
                        'field2' => [
                            'field2.1' => null
                        ]
                    ],
                    'strategy' => [
                        'field1'        => 'some',
                        'unknown_field' => 'other'
                    ]
                ]
            ],
            null
        ];
        $container = new ContainerBuilder();
        $extension = new OroCRMMagentoExtension();
        $extension->load($config, $container);
    }

    /**
     * @dataProvider inheritanceConfigurationDataProvider
     *
     * @param array $config
     * @param array $resultConfig
     */
    public function testInheritanceConfiguration(array $config, array $resultConfig)
    {
        $container = new ContainerBuilder();
        $extension = new OroCRMMagentoExtension();
        $extension->load($config, $container);
        $services = $container->findTaggedServiceIds('orocrm_magento.bundle_config.aware');
        foreach ($services as $serviceId => $tagAttributes) {
            $tagAttributes = reset($tagAttributes);
            if (isset($tagAttributes['argument_number'])) {
                $serviceDefinition = $container->getDefinition($serviceId);
                $serviceArgument   = $serviceDefinition->getArgument($tagAttributes['argument_number']);
                self::assertArrayHasKey(Configuration::DISCOVERY_NODE, $serviceArgument);
                self::assertArrayHasKey(
                    Configuration::DISCOVERY_OPTIONS_KEY,
                    $serviceArgument[Configuration::DISCOVERY_NODE]
                );
                self::assertArrayHasKey(
                    Configuration::DISCOVERY_STRATEGY_KEY,
                    $serviceArgument[Configuration::DISCOVERY_NODE]
                );
                self::assertArrayHasKey(
                    Configuration::DISCOVERY_FIELDS_KEY,
                    $serviceArgument[Configuration::DISCOVERY_NODE]
                );
                self::assertEquals(
                    $serviceArgument[Configuration::DISCOVERY_NODE],
                    $resultConfig[Configuration::DISCOVERY_NODE]
                );
            }
        }
    }

    /**
     * @return array
     */
    public function inheritanceConfigurationDataProvider()
    {
        return [
            'one config block' => [
                'config'       => [
                    null,
                    [
                        'account_discovery' => [
                            'fields'  => ['field1' => null, 'field2' => null, 'field3' => null,],
                            'options' => ['match' => 'first', 'empty' => false,]
                        ]
                    ]
                ],
                'resultConfig' => [
                    'account_discovery' => [
                        'fields'   => ['field1' => null, 'field2' => null, 'field3' => null,],
                        'options'  => ['match' => 'first', 'empty' => false,],
                        'strategy' => []
                    ]
                ]
            ],
            'two config block' => [
                'config'       => [
                    null,
                    [
                        'account_discovery' => [
                            'fields'  => ['field1' => null],
                            'options' => ['match' => 'first', 'empty' => false]
                        ]
                    ],
                    [
                        'account_discovery' => [
                            'fields'  => ['field1' => null, 'field2' => null, 'field3' => null],
                            'options' => ['match' => 'first', 'empty' => false]
                        ]
                    ]
                ],
                'resultConfig' => [
                    'account_discovery' => [
                        'fields'   => ['field1' => null,],
                        'options'  => ['match' => 'first', 'empty' => false,],
                        'strategy' => []
                    ]
                ]
            ]
        ];
    }
}