RFMBuilderTest::buildDataProvider() - Code Metrics - Inspection of "Merge remote-tracking branch 'remotes/dev/master'" - orocrm/crm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0ac209...7b7af5 )

unknown

created 2016-02-10 07:03 UTC

RFMBuilderTest::buildDataProvider() B

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	140
Code Lines	123

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	140
rs	8.2857
cc	1
eloc	123
nc	1
nop	0

How to fix Long Method

<?php

namespace OroCRM\Bundle\AnalyticsBundle\Tests\Unit\Builder;

use Oro\Bundle\EntityBundle\ORM\DoctrineHelper;
use OroCRM\Bundle\AnalyticsBundle\Builder\RFMBuilder;
use OroCRM\Bundle\AnalyticsBundle\Builder\RFMProviderInterface;
use OroCRM\Bundle\AnalyticsBundle\Entity\RFMMetricCategory;
use OroCRM\Bundle\AnalyticsBundle\Tests\Unit\Model\Stub\RFMAwareStub;
use OroCRM\Bundle\ChannelBundle\Entity\Channel;

class RFMBuilderTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var RFMBuilder
     */
    protected $builder;

    /**
     * @var \PHPUnit_Framework_MockObject_MockObject|DoctrineHelper
     */
    protected $doctrineHelper;

    protected function setUp()
    {
        $this->doctrineHelper = $this->getMockBuilder('Oro\Bundle\EntityBundle\ORM\DoctrineHelper')
            ->disableOriginalConstructor()
            ->getMock();

        $this->builder = new RFMBuilder($this->doctrineHelper);
    }

    /**
     * @expectedException \InvalidArgumentException
     * @expectedExceptionMessage Expected one of "recency,frequency,monetary" type, "wrong_type" given
     */
    public function testAddProviderFailed()

    {
        /** @var \PHPUnit_Framework_MockObject_MockObject|RFMProviderInterface $provider */
        $provider = $this->getMock('OroCRM\Bundle\AnalyticsBundle\Builder\RFMProviderInterface');
        $provider->expects($this->once())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('getType')
            ->will($this->returnValue('wrong_type'));

        $this->builder->addProvider($provider);
    }

    public function testAddProviderSuccess()

    {
        /** @var \PHPUnit_Framework_MockObject_MockObject|RFMProviderInterface $provider */
        $provider = $this->getMock('OroCRM\Bundle\AnalyticsBundle\Builder\RFMProviderInterface');
        $provider->expects($this->once())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->method('getType')
            ->will($this->returnValue(RFMMetricCategory::TYPE_FREQUENCY));

        $this->builder->addProvider($provider);
    }

    /**
     * @param mixed $entity
     * @param bool $expected
     *
     * @dataProvider supportsDataProvider
     */
    public function testSupports($entity, $expected)
    {
        $this->assertEquals(
            $expected,
            $this->builder->supports($entity)
        );
    }

    /**
     * @return array
     */
    public function supportsDataProvider()
    {
        $mock = $this->getMock('OroCRM\Bundle\ChannelBundle\Entity\Channel');
        $mock->expects($this->once())
            ->method('getCustomerIdentity')
            ->willReturn(new RFMAwareStub());
        return [
            [new Channel(), false],
            [$mock, true],
        ];
    }
}


1		<?php
2
3		namespace OroCRM\Bundle\AnalyticsBundle\Tests\Unit\Builder;
4
5		use Oro\Bundle\EntityBundle\ORM\DoctrineHelper;
6		use OroCRM\Bundle\AnalyticsBundle\Builder\RFMBuilder;
7		use OroCRM\Bundle\AnalyticsBundle\Builder\RFMProviderInterface;
8		use OroCRM\Bundle\AnalyticsBundle\Entity\RFMMetricCategory;
9		use OroCRM\Bundle\AnalyticsBundle\Tests\Unit\Model\Stub\RFMAwareStub;
10		use OroCRM\Bundle\ChannelBundle\Entity\Channel;
11
12		class RFMBuilderTest extends \PHPUnit_Framework_TestCase
13		{
14		/**
15		* @var RFMBuilder
16		*/
17		protected $builder;
18
19		/**
20		* @var \PHPUnit_Framework_MockObject_MockObject\|DoctrineHelper
21		*/
22		protected $doctrineHelper;
23
24		protected function setUp()
25		{
26		$this->doctrineHelper = $this->getMockBuilder('Oro\Bundle\EntityBundle\ORM\DoctrineHelper')
27		->disableOriginalConstructor()
28		->getMock();
29
30		$this->builder = new RFMBuilder($this->doctrineHelper);
31		}
32
33		/**
34		* @expectedException \InvalidArgumentException
35		* @expectedExceptionMessage Expected one of "recency,frequency,monetary" type, "wrong_type" given
36		*/
37	View Code Duplication	public function testAddProviderFailed()
		0 ignored issues – show Duplication introduced 2016-02-10 07:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		{
39		/** @var \PHPUnit_Framework_MockObject_MockObject\|RFMProviderInterface $provider */
40		$provider = $this->getMock('OroCRM\Bundle\AnalyticsBundle\Builder\RFMProviderInterface');
41		$provider->expects($this->once())
		0 ignored issues – show Bug introduced 2016-02-04 07:16 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `OroCRM\Bundle\AnalyticsB...er\RFMProviderInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
42		->method('getType')
43		->will($this->returnValue('wrong_type'));
44
45		$this->builder->addProvider($provider);
46		}
47
48	View Code Duplication	public function testAddProviderSuccess()
		0 ignored issues – show Duplication introduced 2016-02-10 07:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
49		{
50		/** @var \PHPUnit_Framework_MockObject_MockObject\|RFMProviderInterface $provider */
51		$provider = $this->getMock('OroCRM\Bundle\AnalyticsBundle\Builder\RFMProviderInterface');
52		$provider->expects($this->once())
		0 ignored issues – show Bug introduced 2016-02-04 07:16 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `OroCRM\Bundle\AnalyticsB...er\RFMProviderInterface`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
53		->method('getType')
54		->will($this->returnValue(RFMMetricCategory::TYPE_FREQUENCY));
55
56		$this->builder->addProvider($provider);
57		}
58
59		/**
60		* @param mixed $entity
61		* @param bool $expected
62		*
63		* @dataProvider supportsDataProvider
64		*/
65		public function testSupports($entity, $expected)
66		{
67		$this->assertEquals(
68		$expected,
69		$this->builder->supports($entity)
70		);
71		}
72
73		/**
74		* @return array
75		*/
76		public function supportsDataProvider()
77		{
78		$mock = $this->getMock('OroCRM\Bundle\ChannelBundle\Entity\Channel');
79		$mock->expects($this->once())
80		->method('getCustomerIdentity')
81		->willReturn(new RFMAwareStub());
82		return [
83		[new Channel(), false],
84		[$mock, true],
85		];
86		}
87		}
88

orocrm / crm

Push — master ( 0ac209...7b7af5 )

RFMBuilderTest::buildDataProvider() B

Complexity

Size

Duplication

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like