orocrm /
crm
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 14 | View Code Duplication | class CreateActivityAssociation implements Migration, ActivityExtensionAwareInterface, NoteExtensionAwareInterface |
|
|
|
|||
| 15 | { |
||
| 16 | /** @var ActivityExtension */ |
||
| 17 | protected $activityExtension; |
||
| 18 | |||
| 19 | /** @var NoteExtension */ |
||
| 20 | protected $noteExtension; |
||
| 21 | |||
| 22 | /** |
||
| 23 | * {@inheritdoc} |
||
| 24 | */ |
||
| 25 | public function setActivityExtension(ActivityExtension $activityExtension) |
||
| 29 | |||
| 30 | /** |
||
| 31 | * {@inheritdoc} |
||
| 32 | */ |
||
| 33 | public function setNoteExtension(NoteExtension $noteExtension) |
||
| 37 | |||
| 38 | /** |
||
| 39 | * {@inheritdoc} |
||
| 40 | */ |
||
| 41 | public function up(Schema $schema, QueryBag $queries) |
||
| 42 | { |
||
| 43 | self::addActivityAssociations($schema, $this->activityExtension); |
||
| 44 | self::addNoteAssociations($schema, $this->noteExtension); |
||
| 45 | } |
||
| 46 | |||
| 47 | /** |
||
| 48 | * Enable activities |
||
| 49 | * |
||
| 50 | * @param Schema $schema |
||
| 51 | * @param ActivityExtension $activityExtension |
||
| 52 | */ |
||
| 53 | public static function addActivityAssociations(Schema $schema, ActivityExtension $activityExtension) |
||
| 54 | { |
||
| 55 | $activityExtension->addActivityAssociation($schema, 'orocrm_task', 'orocrm_magento_order'); |
||
| 56 | $activityExtension->addActivityAssociation($schema, 'oro_calendar_event', 'orocrm_magento_order'); |
||
| 57 | } |
||
| 58 | |||
| 59 | /** |
||
| 60 | * Enable notes for Magento Order entity |
||
| 61 | * |
||
| 62 | * @param Schema $schema |
||
| 63 | * @param NoteExtension $noteExtension |
||
| 64 | */ |
||
| 65 | public static function addNoteAssociations(Schema $schema, NoteExtension $noteExtension) |
||
| 69 | } |
||
| 70 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.