OroCRM\Bundle\ActivityContactBundle\Migrations\Schema\v1_0\UpdateConfigQuery

Complexity

Total Complexity

11

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	2
Bugs	1	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	execute()	0	4	1
A	getDescription()	0	7	1
A	doExecute()	0	11	3
B	updateEntityData()	0	22	5
A	executeQuery()	0	6	1

<?php

namespace OroCRM\Bundle\ActivityContactBundle\Migrations\Schema\v1_0;

use Psr\Log\LoggerInterface;

use Doctrine\DBAL\Types\Type;

use Oro\Bundle\MigrationBundle\Migration\ArrayLogger;
use Oro\Bundle\MigrationBundle\Migration\ParametrizedMigrationQuery;

use OroCRM\Bundle\ActivityContactBundle\EntityConfig\ActivityScope;

class UpdateConfigQuery extends ParametrizedMigrationQuery
{
    /**
     * {@inheritDoc}
     */
    public function getDescription()
    {
        $logger = new ArrayLogger();
        $this->doExecute($logger, true);

        return $logger->getMessages();
    }

    /**
     * {@inheritDoc}
     */
    public function execute(LoggerInterface $logger)
    {
        $this->doExecute($logger);
    }

    /**
     * @param LoggerInterface $logger
     * @param bool            $dryRun
     *
     * @throws \Doctrine\DBAL\DBALException
     */
    protected function doExecute(LoggerInterface $logger, $dryRun = false)

The parameter $dryRun is not used and could be removed.

    {
        $className = 'Oro\Bundle\UserBundle\Entity\User';
        if ($className) {
            $sql = 'SELECT e.data FROM oro_entity_config as e WHERE e.class_name = ? LIMIT 1';
            $entityRow = $this->connection->fetchAssoc($sql, [$className]);
            if ($entityRow) {

The expression $entityRow of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                $this->updateEntityData($className, $entityRow['data'], $logger);
            }
        }
    }

    /**
     * @param string $className
     * @param string $data
     * @param LoggerInterface $logger
     */
    protected function updateEntityData($className, $data, $logger)
    {
        $data = $data ? $this->connection->convertToPHPValue($data, Type::TARRAY) : [];

        foreach (array_keys(ActivityScope::$fieldsConfiguration) as $fieldName) {
            if (isset($data['extend']['schema']['property'][$fieldName])) {
                unset($data['extend']['schema']['property'][$fieldName]);
            }
            $entityName = $data['extend']['schema']['entity'];
            if (isset($data['extend']['schema']['doctrine'][$entityName]['fields'][$fieldName])) {
                unset($data['extend']['schema']['doctrine'][$entityName]['fields'][$fieldName]);
            }
        }

        $data = $this->connection->convertToDatabaseValue($data, Type::TARRAY);

        $this->executeQuery(
            $logger,
            'UPDATE oro_entity_config SET data = ? WHERE class_name = ?',
            [$data, $className]
        );
    }

    /**
     * @param LoggerInterface $logger
     * @param $sql
     * @param array $parameters
     * @throws \Doctrine\DBAL\DBALException
     */
    protected function executeQuery(LoggerInterface $logger, $sql, array $parameters = [])
    {
        $statement = $this->connection->prepare($sql);
        $statement->execute($parameters);
        $this->logQuery($logger, $sql, $parameters);
    }
}