OrderWithExistingCustomerStrategy::isProcessingAllowed() - Code Metrics - orocrm/crm - Measure and Improve Code Quality continuously with Scrutinizer

isProcessingAllowed() D
last analyzed 2016-10-27 06:19 UTC

↳ Parent: OrderWithExistingCustomerStrategy

Complexity

Conditions	9
Paths	12

Size

Total Lines	41
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	41
rs	4.909
c	0
b	0
f	0
cc	9
eloc	21
nc	12
nop	1

<?php

namespace Oro\Bundle\MagentoBundle\ImportExport\Strategy;

use Oro\Bundle\MagentoBundle\Entity\Customer;
use Oro\Bundle\MagentoBundle\Entity\MagentoSoapTransport;
use Oro\Bundle\MagentoBundle\Entity\Order;
use Oro\Bundle\MagentoBundle\ImportExport\Converter\GuestCustomerDataConverter;
use Oro\Bundle\MagentoBundle\Provider\Reader\ContextCartReader;
use Oro\Bundle\MagentoBundle\Provider\Reader\ContextCustomerReader;

class OrderWithExistingCustomerStrategy extends OrderStrategy
{
    const CONTEXT_ORDER_POST_PROCESS = 'postProcessOrders';

    /**
     * @param Order $importingOrder
     *
     * {@inheritdoc}
     */
    public function process($importingOrder)

    {
        if (!$this->isProcessingAllowed($importingOrder)) {
            $this->appendDataToContext(self::CONTEXT_ORDER_POST_PROCESS, $this->context->getValue('itemData'));

            return null;
        }

        return parent::process($importingOrder);
    }

    /**
     * @param Order $order
     * @return bool
     */
    protected function isProcessingAllowed(Order $order)
    {
        $isProcessingAllowed = true;
        $customer = $this->findExistingCustomer($order);
        $customerOriginId = $order->getCustomer()->getOriginId();
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        if (!$customer && $customerOriginId) {
            $this->appendDataToContext(ContextCustomerReader::CONTEXT_POST_PROCESS_CUSTOMERS, $customerOriginId);

            $isProcessingAllowed = false;
        }

        // Do not try to load cart if bridge does not installed
        /** @var MagentoSoapTransport $transport */
        $channel = $this->databaseHelper->findOneByIdentity($order->getChannel());
        $transport = $channel->getTransport();
        if ($transport->getIsExtensionInstalled()) {
            $cart = $this->findExistingEntity($order->getCart());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
            $cartOriginId = $order->getCart()->getOriginId();
            if (!$cart && $cartOriginId) {
                $this->appendDataToContext(ContextCartReader::CONTEXT_POST_PROCESS_CARTS, $cartOriginId);

                $isProcessingAllowed = false;
            }
        }

        /**
         * If Order created with registered customer but registered customer was deleted in Magento
         * before it was synced order will not have connection to the customer
         * Customer for such orders should be processed as guest if Guest Customer synchronization is allowed
         */
        if (!$customer && !$customerOriginId && $transport->getGuestCustomerSync()) {
            $this->appendDataToContext(
                'postProcessGuestCustomers',
                GuestCustomerDataConverter::extractCustomersValues((array)$this->context->getValue('itemData'))
            );

            $isProcessingAllowed = false;
        }

        return $isProcessingAllowed;
    }

    /**
     * Get existing registered customer or existing guest customer
     * If customer not found by Identifier
     * find existing customer using entity data for entities containing customer like Order and Cart
     *
     * @param Order $entity
     *
     * @return null|Customer
     */
    protected function findExistingCustomer(Order $entity)

    {
        $existingEntity = null;
        $customer = $entity->getCustomer();

        if ($customer->getId() || $customer->getOriginId()) {
            $existingEntity = parent::findExistingEntity($customer);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        }
        if (!$existingEntity) {
            $existingEntity = $this->findExistingCustomerByContext($entity);
        }

        return $existingEntity;
    }

    /**
     * Get existing customer entity by Identifier or using entity data
     *
     * @param object $entity
     * @param array $searchContext
     * @return null|object
     */
    protected function findExistingEntity($entity, array $searchContext = [])
    {
        if ($entity instanceof Customer && !$entity->getOriginId() && $this->existingEntity) {

            return $this->findExistingCustomerByContext($this->existingEntity);
        }

        return parent::findExistingEntity($entity, $searchContext);
    }
}


1		<?php
2
3		namespace Oro\Bundle\MagentoBundle\ImportExport\Strategy;
4
5		use Oro\Bundle\MagentoBundle\Entity\Customer;
6		use Oro\Bundle\MagentoBundle\Entity\MagentoSoapTransport;
7		use Oro\Bundle\MagentoBundle\Entity\Order;
8		use Oro\Bundle\MagentoBundle\ImportExport\Converter\GuestCustomerDataConverter;
9		use Oro\Bundle\MagentoBundle\Provider\Reader\ContextCartReader;
10		use Oro\Bundle\MagentoBundle\Provider\Reader\ContextCustomerReader;
11
12		class OrderWithExistingCustomerStrategy extends OrderStrategy
13		{
14		const CONTEXT_ORDER_POST_PROCESS = 'postProcessOrders';
15
16		/**
17		* @param Order $importingOrder
18		*
19		* {@inheritdoc}
20		*/
21	View Code Duplication	public function process($importingOrder)
		0 ignored issues – show Duplication introduced 2015-11-25 07:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		{
23		if (!$this->isProcessingAllowed($importingOrder)) {
24		$this->appendDataToContext(self::CONTEXT_ORDER_POST_PROCESS, $this->context->getValue('itemData'));
25
26		return null;
27		}
28
29		return parent::process($importingOrder);
30		}
31
32		/**
33		* @param Order $order
34		* @return bool
35		*/
36		protected function isProcessingAllowed(Order $order)
37		{
38		$isProcessingAllowed = true;
39		$customer = $this->findExistingCustomer($order);
40		$customerOriginId = $order->getCustomer()->getOriginId();
		0 ignored issues – show Bug introduced 2016-10-23 08:54 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Oro\Bundle\BusinessEntit...undle\Entity\BasePerson` as the method `getOriginId()` does only exist in the following sub-classes of `Oro\Bundle\BusinessEntit...undle\Entity\BasePerson`: `Oro\Bundle\MagentoBundle\Entity\Customer`, `Oro\Bundle\MagentoBundle...s\Entity\ExtendCustomer`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
41		if (!$customer && $customerOriginId) {
42		$this->appendDataToContext(ContextCustomerReader::CONTEXT_POST_PROCESS_CUSTOMERS, $customerOriginId);
43
44		$isProcessingAllowed = false;
45		}
46
47		// Do not try to load cart if bridge does not installed
48		/** @var MagentoSoapTransport $transport */
49		$channel = $this->databaseHelper->findOneByIdentity($order->getChannel());
50		$transport = $channel->getTransport();
51		if ($transport->getIsExtensionInstalled()) {
52		$cart = $this->findExistingEntity($order->getCart());
		0 ignored issues – show Bug introduced 2016-10-23 08:54 UTC by Report Bug Copy Issue Report It seems like `$order->getCart()` can be `null`; however, `findExistingEntity()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
53		$cartOriginId = $order->getCart()->getOriginId();
54		if (!$cart && $cartOriginId) {
55		$this->appendDataToContext(ContextCartReader::CONTEXT_POST_PROCESS_CARTS, $cartOriginId);
56
57		$isProcessingAllowed = false;
58		}
59		}
60
61		/**
62		* If Order created with registered customer but registered customer was deleted in Magento
63		* before it was synced order will not have connection to the customer
64		* Customer for such orders should be processed as guest if Guest Customer synchronization is allowed
65		*/
66		if (!$customer && !$customerOriginId && $transport->getGuestCustomerSync()) {
67		$this->appendDataToContext(
68		'postProcessGuestCustomers',
69		GuestCustomerDataConverter::extractCustomersValues((array)$this->context->getValue('itemData'))
70		);
71
72		$isProcessingAllowed = false;
73		}
74
75		return $isProcessingAllowed;
76		}
77
78		/**
79		* Get existing registered customer or existing guest customer
80		* If customer not found by Identifier
81		* find existing customer using entity data for entities containing customer like Order and Cart
82		*
83		* @param Order $entity
84		*
85		* @return null\|Customer
86		*/
87	View Code Duplication	protected function findExistingCustomer(Order $entity)
		0 ignored issues – show Duplication introduced 2016-09-30 06:24 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
88		{
89		$existingEntity = null;
90		$customer = $entity->getCustomer();
91
92		if ($customer->getId() \|\| $customer->getOriginId()) {
93		$existingEntity = parent::findExistingEntity($customer);
		0 ignored issues – show Comprehensibility Bug introduced 2016-08-14 18:24 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`findExistingEntity()` instead of `findExistingCustomer()`). Are you sure this is correct? If so, you might want to change this to `$this->findExistingEntity()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
94		}
95		if (!$existingEntity) {
96		$existingEntity = $this->findExistingCustomerByContext($entity);
97		}
98
99		return $existingEntity;
100		}
101
102		/**
103		* Get existing customer entity by Identifier or using entity data
104		*
105		* @param object $entity
106		* @param array $searchContext
107		* @return null\|object
108		*/
109		protected function findExistingEntity($entity, array $searchContext = [])
110		{
111	View Code Duplication	if ($entity instanceof Customer && !$entity->getOriginId() && $this->existingEntity) {
		0 ignored issues – show Duplication introduced 2016-09-30 06:24 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
112		return $this->findExistingCustomerByContext($this->existingEntity);
113		}
114
115		return parent::findExistingEntity($entity, $searchContext);
116		}
117		}
118

orocrm / crm

isProcessingAllowed() D last analyzed 2016-10-27 06:19 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

isProcessingAllowed() D
last analyzed 2016-10-27 06:19 UTC