Orkhanahmadov\YandexCheckout\Models\Traits\HandlesYandexCheckout

Complexity

Total Complexity

3

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	yandexCheckouts()	0	3	1
A	yandexCheckoutIdempotenceKey()	0	3	1
A	createPayment()	0	9	1

<?php

namespace Orkhanahmadov\YandexCheckout\Models\Traits;

use Illuminate\Container\Container;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\MorphMany;
use Orkhanahmadov\YandexCheckout\Models\YandexCheckout;
use Orkhanahmadov\YandexCheckout\YandexCheckoutService;
use YooKassa\Request\Payments\CreatePaymentRequestInterface;

/**
 * Trait Payable.
 *
 * @mixin Model
 */
trait HandlesYandexCheckout
{
    public function yandexCheckouts(): MorphMany
    {
        return $this->morphMany(YandexCheckout::class, 'payable');

It seems like morphMany() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @param  CreatePaymentRequestInterface|array  $paymentRequest
     * @param  string|null  $idempotenceKey
     * @return YandexCheckout
     */
    public function createPayment($paymentRequest, ?string $idempotenceKey = null): YandexCheckout
    {
        /** @var YandexCheckoutService $yandexCheckout */
        $yandexCheckout = Container::getInstance()->make(YandexCheckoutService::class);

        return $yandexCheckout->createPayment(
            $this,

$this of type Orkhanahmadov\YandexCheckout\Models\Traits\HandlesYandexCheckout is incompatible with the type Illuminate\Database\Eloquent\Model expected by parameter $model of Orkhanahmadov\YandexCheckout\YandexCheckoutService::createPayment().

            $paymentRequest,
            $idempotenceKey ?? $this->yandexCheckoutIdempotenceKey()
        );
    }

    public function yandexCheckoutIdempotenceKey(): ?string
    {
        return "{$this->getTable()}-{$this->getKey()}";

It seems like getKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

It seems like getTable() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}