Orkhanahmadov\LaravelGoldenpay\Http\Controllers\GoldenpayController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	1
A	paymentResult()	0	4	1

<?php

namespace Orkhanahmadov\LaravelGoldenpay\Http\Controllers;

use Orkhanahmadov\LaravelGoldenpay\Actions\PaymentEvent;
use Orkhanahmadov\LaravelGoldenpay\Goldenpay;
use Orkhanahmadov\LaravelGoldenpay\Http\Requests\Request;
use Orkhanahmadov\LaravelGoldenpay\Models\Payment;

abstract class GoldenpayController
{
    /**
     * @var PaymentEvent
     */
    private $event;
    /**
     * @var Goldenpay
     */
    protected $goldenpay;
    /**
     * @var Payment
     */
    protected $payment;


    /**
     * Controller constructor.
     *
     * @param Request $request
     * @param PaymentEvent $event
     * @param Goldenpay $goldenpay
     */
    public function __construct(
        Request $request,
        PaymentEvent $event,
        Goldenpay $goldenpay
    ) {
        $this->event = $event;
        $this->goldenpay = $goldenpay;

        $this->paymentResult($request);
    }

    /**
     * Checks payment result with "payment_key" query parameter.
     *
     * @param Request $request
     */
    final protected function paymentResult(Request $request): void
    {
        $this->payment = $this->goldenpay->result($request->query('payment_key'));

It seems like $request->query('payment_key') targeting Illuminate\Http\Concerns\InteractsWithInput::query() can also be of type array or null; however, Orkhanahmadov\LaravelGoldenpay\Goldenpay::result() does only seem to accept object<Orkhanahmadov\LaravelGoldenpay\Models\Payment>|string, maybe add an additional type check?

    }
}