orkhanahmadov / laravel-currencylayer

src/Commands/LiveCommand.php

<?php

namespace Orkhanahmadov\LaravelCurrencylayer\Commands;

use Orkhanahmadov\LaravelCurrencylayer\Contracts\CurrencyService;

class LiveCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'currencylayer:live 
                            {source : Source currency code} 
                            {currencies* : Target currency codes}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Gets live rates for currencies';

    /**
     * Execute the console command.
     *
     * @param CurrencyService $currencyService
     */
    public function handle(CurrencyService $currencyService): void
    {
        /**
         * @var array|float
         */
        $rates = $currencyService->live(
            /**
             * @var string
             */
            $source = $this->argument('source'),

It seems like $source = $this->argument('source') can also be of type string[]; however, parameter $source of Orkhanahmadov\LaravelCurrencylayer\Contracts\CurrencyService::live() does only seem to accept Orkhanahmadov\LaravelCurrencylayer\Models\Currency|string, maybe add an additional type check?

            /**
             * @var array
             */
            $currencies = $this->argument('currencies')
        );

        $this->output(
            'Live '.$source.' rates',

Are you sure $source of type null|string|string[] can be used in concatenation?

            $this->prepareRows($currencies, $rates)

It seems like $currencies can also be of type null and string; however, parameter $currencies of Orkhanahmadov\LaravelCurrencylayer\Commands\Command::prepareRows() does only seem to accept array, maybe add an additional type check?

        );
    }
}