Orkhanahmadov\LaravelCurrencylayer\Commands\RateCommand

Complexity

Total Complexity

3

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	handle()	0	13	2
A	__construct()	0	3	1

<?php

namespace Orkhanahmadov\LaravelCurrencylayer\Commands;

use Illuminate\Console\Command;
use Orkhanahmadov\LaravelCurrencylayer\Currencylayer;

class RateCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'currencylayer:rate 
                            {source : Source currency code} 
                            {date : Date for currency rates} 
                            {currencies* : Target currency codes}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Gets live rates for currencies';

    /**
     * Create a new command instance.
     *
     * @return void
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @param Currencylayer $currencylayer
     *
     * @return mixed
     */
    public function handle(Currencylayer $currencylayer)
    {
        $rates = $currencylayer->rate(
            $this->argument('source'),

It seems like $this->argument('source') can also be of type string[]; however, parameter $source of Orkhanahmadov\LaravelCurrencylayer\Currencylayer::rate() does only seem to accept Orkhanahmadov\LaravelCurrencylayer\Models\Currency|string, maybe add an additional type check?

            $this->argument('date'),

It seems like $this->argument('date') can also be of type string[]; however, parameter $date of Orkhanahmadov\LaravelCurrencylayer\Currencylayer::rate() does only seem to accept Carbon\Carbon|string, maybe add an additional type check?

            $this->argument('currencies')
        );

        $header = ['Currency', 'Value'];
        if (is_array($rates)) {
            $this->table($header, [array_keys($rates), array_values($rates)]);
        } else {
            $this->table($header, [$this->argument('currencies'), [$rates]]);
        }
    }
}