Orkhanahmadov\LaravelCurrencylayer\Commands\RateCommand

Complexity

Total Complexity

1

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Importance

Changes	6
Bugs	1	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	handle()	0	23	1

<?php

namespace Orkhanahmadov\LaravelCurrencylayer\Commands;

use Orkhanahmadov\LaravelCurrencylayer\Currencylayer;

class RateCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'currencylayer:rate 
                            {source : Source currency code} 
                            {date : Date for currency rates} 
                            {currencies* : Target currency codes}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Gets live rates for currencies';

    /**
     * Execute the console command.
     *
     * @param Currencylayer $currencylayer
     */
    public function handle(Currencylayer $currencylayer): void
    {
        /**
         * @var array|float $rates
         */
        $rates = $currencylayer->rate(
            /**
             * @var string $source
             */
            $source = $this->argument('source'),

It seems like $source = $this->argument('source') can also be of type string[]; however, parameter $source of Orkhanahmadov\LaravelCurrencylayer\Currencylayer::rate() does only seem to accept Orkhanahmadov\LaravelCurrencylayer\Models\Currency|string, maybe add an additional type check?

            /**
             * @var string $date
             */
            $date = $this->argument('date'),

It seems like $date = $this->argument('date') can also be of type string[]; however, parameter $date of Orkhanahmadov\LaravelCurrencylayer\Currencylayer::rate() does only seem to accept Carbon\Carbon|string, maybe add an additional type check?

            /**
             * @var array $currencies
             */
            $currencies = $this->argument('currencies')
        );

        $this->output(
            $date.' '.$source.' rates',
            $this->prepareRows($currencies, $rates)
        );
    }
}