Orkhanahmadov\LaravelAcceptLanguageMiddleware\Middleware

Complexity

Total Complexity

4

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	parseHttpLocale()	0	23	2
A	handle()	0	5	1

<?php

namespace Orkhanahmadov\LaravelAcceptLanguageMiddleware;

use Closure;
use Illuminate\Contracts\Foundation\Application;
use Illuminate\Http\Request;
use Illuminate\Support\Collection;

class Middleware
{
    /**
     * @var Application
     */
    private $app;

    /**
     * HttpLocaleMiddleware constructor.
     *
     * @param Application $app
     */
    public function __construct(Application $app)
    {
        $this->app = $app;
    }

    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Closure  $next
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        $this->app->setLocale($this->parseHttpLocale($request));

        return $next($request);
    }

    /**
     * @param Request $request
     *
     * @return string
     */
    private function parseHttpLocale(Request $request): string
    {
        $list = explode(',', $request->server('HTTP_ACCEPT_LANGUAGE'));

It seems like $request->server('HTTP_ACCEPT_LANGUAGE') can also be of type array; however, parameter $string of explode() does only seem to accept string, maybe add an additional type check?

        $locales = Collection::make($list)->map(function ($locale) {
            $parts = explode(';', $locale);

            $mapping['locale'] = trim($parts[0]);

$mapping was never initialized. Although not strictly required by PHP, it is generally a good practice to add $mapping = array(); before regardless.

            if (isset($parts[1])) {
                $factorParts = explode('=', $parts[1]);

                $mapping['factor'] = $factorParts[1];
            } else {
                $mapping['factor'] = 1;
            }

            return $mapping;
        })->sortByDesc(function ($locale) {
            return $locale['factor'];
        });

        return $locales->first()['locale'];
    }
}