Orkhanahmadov\EloquentRepository\Repository\Concerns\UpdatesEntity

Complexity

Total Complexity

3

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	findAndUpdate()	0	5	1
A	update()	0	9	2

<?php

namespace Orkhanahmadov\EloquentRepository\Repository\Concerns;

use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Builder;
use Orkhanahmadov\EloquentRepository\Repository\Contracts\Cacheable;

/**
 * @method Builder|Model find(int $modelId)
 * @method void invalidateCache()
 */
trait UpdatesEntity
{
    /**
     * Finds a model with ID and updates it with given properties.
     *
     * @param int|string $modelId
     * @param mixed $properties
     *
     * @return Builder|Model
     */
    public function findAndUpdate($modelId, $properties)
    {
        $model = $this->find($modelId);

It seems like $modelId can also be of type string; however, parameter $modelId of Orkhanahmadov\EloquentRepository\Repository\Concerns\UpdatesEntity::find() does only seem to accept integer, maybe add an additional type check?

        return $this->update($model, $properties);

It seems like $model can also be of type Illuminate\Database\Eloquent\Builder; however, parameter $model of Orkhanahmadov\EloquentRepository\Repository\Concerns\UpdatesEntity::update() does only seem to accept Illuminate\Database\Eloquent\Model, maybe add an additional type check?

    }

    /**
     * Updates a model given properties.
     *
     * @param Model $model
     * @param mixed $properties
     *
     * @return Builder|Model
     */
    public function update($model, $properties)
    {
        if ($this instanceof Cacheable) {
            $this->invalidateCache($model);

The call to Orkhanahmadov\EloquentRepository\Repository\Concerns\UpdatesEntity::invalidateCache() has too many arguments starting with $model.

        }

        $model->fill($properties)->save();

        return $model->refresh();
    }
}