NovaServiceResult::getZones() - Code Metrics - Inspection of "Add method for collections" - orca-services/nova-api-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 81bf05...4d256e )

by Daniel

created 2020-05-29 06:54 UTC

NovaServiceResult::getZones() A

↳ Parent: NovaServiceResult

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

namespace OrcaServices\NovaApi\Result;

use Cake\Chronos\Chronos;

/**
 * NovaServiceResult.
 */
final class NovaServiceResult
{
    /**
     * Tkid.
     *
     * @var string
     */
    public $tkId;

    /**
     * Valid start date.
     *
     * @var Chronos
     */
    public $validFrom;

    /**
     * Valid end date.
     *
     * @var Chronos
     */
    public $validTo;

    /**
     * Product number.
     *
     * @var string
     */
    public $productNumber;

    /**
     * Restricted to zones.
     *
     * @var string[]
     */
    private $zones = [];

    /**
     * Add zones.
     *
     * @param string $zone The zone
     *
     * @return void
     */
    public function addZone(string $zone)
    {
        $this->zones[] = $zone;
    }

    /**
     * Get a list of zones.
     *
     * @return string[] List of zones
     */
    public function getZones(): array
    {
        return $this->zones;
    }
}


1		<?php
2
3		namespace OrcaServices\NovaApi\Result;
4
5		use Cake\Chronos\Chronos;
6
7		/**
8		* NovaServiceResult.
9		*/
10		final class NovaServiceResult
11		{
12		/**
13		* Tkid.
14		*
15		* @var string
16		*/
17		public $tkId;
18
19		/**
20		* Valid start date.
21		*
22		* @var Chronos
23		*/
24		public $validFrom;
25
26		/**
27		* Valid end date.
28		*
29		* @var Chronos
30		*/
31		public $validTo;
32
33		/**
34		* Product number.
35		*
36		* @var string
37		*/
38		public $productNumber;
39
40		/**
41		* Restricted to zones.
42		*
43		* @var string[]
44		*/
45		private $zones = [];
46
47		/**
48		* Add zones.
49		*
50		* @param string $zone The zone
51		*
52		* @return void
53		*/
54	1	public function addZone(string $zone)
55		{
56	1	$this->zones[] = $zone;
57	1	}
58
59		/**
60		* Get a list of zones.
61		*
62		* @return string[] List of zones
63		*/
64	1	public function getZones(): array
65		{
66	1	return $this->zones;
67		}
68		}
69

orca-services / nova-api-php

Push — master ( 81bf05...4d256e )

NovaServiceResult::getZones() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like