ElasticController::actionSpool() - Code Metrics - opus-online/yii2-elastic - Measure and Improve Code Quality continuously with Scrutinizer

ElasticController::actionSpool() A
last analyzed 2019-01-16 12:09 UTC

↳ Parent: ElasticController

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.9666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php
/**
 *
 * @author Mihkel Viilveer <[email protected]>
 * @date 22.08.2014
 */

namespace opus\elastic\spooler;

use yii\base\ErrorException;
use yii\console\Controller;

/**
 * Class ElasticController
 *
 * @author Mihkel Viilveer <[email protected]>
 * @package opus\elastic\spooler
 */
class ElasticController extends Controller
{
    /**
     * Data providers to index/spool
     * @var string[]
     */
    public $dataProviders = [];
    /**
     * @throws \yii\base\ErrorException
     */
    public function actionImport()
    {
        $elasticManager = new SpoolManager(
            [
                'dataProviders' => $this->createDataProviders($this->dataProviders)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ]
        );
        $elasticManager->reindex();
    }

    /**
     * @throws \yii\base\ErrorException
     */
    public function actionSpool()
    {
        $elasticManager = new SpoolManager(
            [
                'dataProviders' => $this->createDataProviders($this->dataProviders)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ]
        );
        $elasticManager->spool();
    }

    /**
     * @param AbstractDataProvider[] $dataProviders
     * @throws ErrorException
     * @return array
     */
    private function createDataProviders(array $dataProviders)
    {
        $dataProviderModels = [];

        foreach ($dataProviders as $dataProvider) {
            $dataProvider = new $dataProvider();
            if (!($dataProvider instanceof AbstractDataProvider)) {
                throw new ErrorException(
                    'dataProvider is not instance of DataProviderInterface'
                );
            }
            $dataProviderModels[] = $dataProvider;
        }
        return $dataProviderModels;
    }
}


1			<?php
2			/**
3			*
4			* @author Mihkel Viilveer <[email protected]>
5			* @date 22.08.2014
6			*/
7
8			namespace opus\elastic\spooler;
9
10			use yii\base\ErrorException;
11			use yii\console\Controller;
12
13			/**
14			* Class ElasticController
15			*
16			* @author Mihkel Viilveer <[email protected]>
17			* @package opus\elastic\spooler
18			*/
19			class ElasticController extends Controller
20			{
21			/**
22			* Data providers to index/spool
23			* @var string[]
24			*/
25			public $dataProviders = [];
26			/**
27			* @throws \yii\base\ErrorException
28			*/
29			public function actionImport()
30			{
31			$elasticManager = new SpoolManager(
32			[
33			'dataProviders' => $this->createDataProviders($this->dataProviders)
			0 ignored issues – show Documentation introduced 2016-07-21 07:10 UTC by Report Bug Copy Issue Report `$this->dataProviders` is of type `array<integer,string>`, but the function expects a `array<integer,object<opu...\AbstractDataProvider>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
34			]
35			);
36			$elasticManager->reindex();
37			}
38
39			/**
40			* @throws \yii\base\ErrorException
41			*/
42			public function actionSpool()
43			{
44			$elasticManager = new SpoolManager(
45			[
46			'dataProviders' => $this->createDataProviders($this->dataProviders)
			0 ignored issues – show Documentation introduced 2016-07-21 07:10 UTC by Report Bug Copy Issue Report `$this->dataProviders` is of type `array<integer,string>`, but the function expects a `array<integer,object<opu...\AbstractDataProvider>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
47			]
48			);
49			$elasticManager->spool();
50			}
51
52			/**
53			* @param AbstractDataProvider[] $dataProviders
54			* @throws ErrorException
55			* @return array
56			*/
57			private function createDataProviders(array $dataProviders)
58			{
59			$dataProviderModels = [];
60
61			foreach ($dataProviders as $dataProvider) {
62			$dataProvider = new $dataProvider();
63			if (!($dataProvider instanceof AbstractDataProvider)) {
64			throw new ErrorException(
65			'dataProvider is not instance of DataProviderInterface'
66			);
67			}
68			$dataProviderModels[] = $dataProvider;
69			}
70			return $dataProviderModels;
71			}
72			}
73

opus-online / yii2-elastic

ElasticController::actionSpool() A last analyzed 2019-01-16 12:09 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ElasticController::actionSpool() A
last analyzed 2019-01-16 12:09 UTC