DayOf - Code Metrics - Inspection of "pull request into master from develop" - opencafe/datium - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#16)

unknown

created 2016-10-20 13:07 UTC

DayOf A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	104
Duplicated Lines	17.31 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
wmc	10
c	1
b	1
f	0
lcom	1
cbo	0
dl	18
loc	104
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	12	1
A	year()	0	6	1
A	week()	0	6	1
C	lastDayMonth()	18	37	7

How to fix Duplicated Code

<?php

namespace OpenCafe\Tools;

/**
 * Define Day of current date.
 */
class DayOf
{
	/**
     * @var object
     */
    protected $date_time;

	/**
     * @var array
     */
    protected $config;

	/**
	 * @var string
	 */
	protected $calendar_type;

	/**
   	 * Constructor of DayOf class
     */
    public function __construct($date_time, $calendar_type = 'gregorian')
    {

		$this->config = include __DIR__.'/CalendarSettings/' . ucfirst($calendar_type) . '.php';

		$this->calendar_type = $calendar_type;

        $this->date_time = $date_time;

        return $this;


    }

    /**
   * Which day of year is current day.
   *
   * @since  Aug, 03 2015
   * @return integer
   */
    public function year()
    {

        return $this->config[ 'day_of_year' ]( $this->date_time );

    }


    /**
   * Which day of week is current day.
   *
   * @since  Aug, 09 2015
   * @return integer
   */
    public function week()
    {

        return $this->config[ 'day_of_week' ]( $this->date_time );

    }

	/**
	 * Return last day of current month
	 *
	 * @since  Oct, 18 2016
	 * @return integer
	 */
	public function lastDayMonth() {

		$days = 0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

		switch ( $this->calendar_type ) {

			case 'gregorian':


				if ( intval( $this->date_time->format( 'm' ) ) == 2 &&
				      $this->config[ 'leap_year' ]( $this->date_time->format( 'Y' )) )
					$days = $this->config[ 'month_days_number' ][ intval( $this->date_time->format( 'm' ) ) ] + 1;
				else
					$days = $this->config[ 'month_days_number' ][ intval( $this->date_time->format( 'm' ) ) ];

				break;

			case 'jalali':


				if ( intval( $this->date_time->format( 'm' ) ) == 12 &&
				  		$this->config[ 'leap_year' ]( $this->date_time->format( 'Y' )) )
				 	$days = $this->config[ 'month_days_number' ][ intval( $this->date_time->format( 'm' ) ) ] + 1;
				else
					$days = $this->config[ 'month_days_number' ][ intval( $this->date_time->format( 'm' ) ) ];

			  	break;

		  default:

			$days = $this->config[ 'month_days_number' ][ intval( $this->date_time->format( 'm' ) ) ];

			break;

		}

		return $days;

	}
}


1		<?php
2
3		namespace OpenCafe\Tools;
4
5		/**
6		* Define Day of current date.
7		*/
8		class DayOf
9		{
10		/**
11		* @var object
12		*/
13		protected $date_time;
14
15		/**
16		* @var array
17		*/
18		protected $config;
19
20		/**
21		* @var string
22		*/
23		protected $calendar_type;
24
25		/**
26		* Constructor of DayOf class
27		*/
28		public function __construct($date_time, $calendar_type = 'gregorian')
29		{
30
31		$this->config = include __DIR__.'/CalendarSettings/' . ucfirst($calendar_type) . '.php';
32
33		$this->calendar_type = $calendar_type;
34
35		$this->date_time = $date_time;
36
37		return $this;
		0 ignored issues – show Bug introduced 2015-11-23 14:42 UTC by Report Bug Copy Issue Report Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct? Loading history...
38
39		}
40
41		/**
42		* Which day of year is current day.
43		*
44		* @since Aug, 03 2015
45		* @return integer
46		*/
47		public function year()
48		{
49
50		return $this->config[ 'day_of_year' ]( $this->date_time );
51
52		}
53
54
55		/**
56		* Which day of week is current day.
57		*
58		* @since Aug, 09 2015
59		* @return integer
60		*/
61		public function week()
62		{
63
64		return $this->config[ 'day_of_week' ]( $this->date_time );
65
66		}
67
68		/**
69		* Return last day of current month
70		*
71		* @since Oct, 18 2016
72		* @return integer
73		*/
74		public function lastDayMonth() {
75
76		$days = 0;
		0 ignored issues – show Unused Code introduced 2016-10-20 13:11 UTC by Report Bug Copy Issue Report `$days` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
77
78		switch ( $this->calendar_type ) {
79
80	View Code Duplication	case 'gregorian':
		0 ignored issues – show Duplication introduced 2016-10-20 13:11 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
81
82		if ( intval( $this->date_time->format( 'm' ) ) == 2 &&
83		$this->config[ 'leap_year' ]( $this->date_time->format( 'Y' )) )
84		$days = $this->config[ 'month_days_number' ][ intval( $this->date_time->format( 'm' ) ) ] + 1;
85		else
86		$days = $this->config[ 'month_days_number' ][ intval( $this->date_time->format( 'm' ) ) ];
87
88		break;
89
90	View Code Duplication	case 'jalali':
		0 ignored issues – show Duplication introduced 2016-10-20 13:11 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
91
92		if ( intval( $this->date_time->format( 'm' ) ) == 12 &&
93		$this->config[ 'leap_year' ]( $this->date_time->format( 'Y' )) )
94		$days = $this->config[ 'month_days_number' ][ intval( $this->date_time->format( 'm' ) ) ] + 1;
95		else
96		$days = $this->config[ 'month_days_number' ][ intval( $this->date_time->format( 'm' ) ) ];
97
98		break;
99
100		default:
101
102		$days = $this->config[ 'month_days_number' ][ intval( $this->date_time->format( 'm' ) ) ];
103
104		break;
105
106		}
107
108		return $days;
109
110		}
111		}
112

opencafe / datium

Pull Request — master (#16)

DayOf A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like