Leap::hijriLeapYear() - Code Metrics - Inspection of "Finilizing the project" - opencafe/datium - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 91cedd...fb54ac )

by mehdi

created 2016-06-13 17:55 UTC

Leap::hijriLeapYear() B

↳ Parent: Project

Complexity

Conditions	12
Paths	2

Size

Total Lines	10
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	10
rs	7.4259
cc	12
eloc	4
nc	2
nop	0

How to fix Complexity

<?php namespace OpenCafe\Tools;

/**
 * @since Aug, 21 2015
 */
class Leap
{

    /**
   * @param integer store year value
   */
    protected $year;

    /**
   * @param string store type of year value
   */
    protected $type;

    /**
   * @param boolean store result of leap functions
   */
    protected $result;


    /**
   * @param $year integer
   * @since Aug, 21 2015
   */
    public function __construct($year, $type = 'gregorian')
    {

         $this->year = $year;

         $this->type = $type;

         return $this;


    }


    /**
   * return the year is leap or not
   *
   * @since  Aug, 21 2015
   * @return boolean
   */
    public function get()
    {

      $this->result = include('CalendarSettings/' . ucfirst($this->type) . '.php');

      return $this->result['leap_year']($this->year);

    }
}


1			<?php namespace OpenCafe\Tools;
2
3			/**
4			* @since Aug, 21 2015
5			*/
6			class Leap
7			{
8
9			/**
10			* @param integer store year value
11			*/
12			protected $year;
13
14			/**
15			* @param string store type of year value
16			*/
17			protected $type;
18
19			/**
20			* @param boolean store result of leap functions
21			*/
22			protected $result;
23
24
25			/**
26			* @param $year integer
27			* @since Aug, 21 2015
28			*/
29			public function __construct($year, $type = 'gregorian')
30			{
31
32			$this->year = $year;
33
34			$this->type = $type;
35
36			return $this;
			0 ignored issues – show Bug introduced 2015-11-23 14:42 UTC by Report Bug Copy Issue Report Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct? Loading history...
37
38			}
39
40
41			/**
42			* return the year is leap or not
43			*
44			* @since Aug, 21 2015
45			* @return boolean
46			*/
47			public function get()
48			{
49
50			$this->result = include('CalendarSettings/' . ucfirst($this->type) . '.php');
51
52			return $this->result['leap_year']($this->year);
53
54			}
55			}
56

opencafe / datium

Push — master ( 91cedd...fb54ac )

Leap::hijriLeapYear() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like