Issues in MediaRepositoryTest.php - All Issues - Inspection of "remove theme (#1157)" - open-orchestra/open-orchestra - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d1d910...7edec1 )

by amaury

created 2017-03-02 13:47 UTC

Repository/MediaRepositoryTest.php (2 issues)

Showing only issues like (Show All)

duplicate/similar methods.

Duplication Informational

itkg-ngilain 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace OpenOrchestra\FunctionalTests\MediaBundle\Repository;

use OpenOrchestra\BaseBundle\Tests\AbstractTest\AbstractKernelTestCase;
use OpenOrchestra\Media\Repository\MediaRepositoryInterface;
use OpenOrchestra\ModelInterface\Repository\RepositoryTrait\KeywordableTraitInterface;
use OpenOrchestra\Pagination\Configuration\PaginateFinderConfiguration;

/**
 * Class MediaRepositoryTest
 *
 * @group integrationTest
 */
class MediaRepositoryTest extends AbstractKernelTestCase
{
    /**
     * @var MediaRepositoryInterface
     */
    protected $repository;
    protected $keywordRepository;

    /**
     * Set up test
     */
    protected function setUp()
    {
        parent::setUp();

        static::bootKernel();
        $this->keywordRepository = static::$kernel->getContainer()->get('open_orchestra_model.repository.keyword');
        $this->repository = static::$kernel->getContainer()->get('open_orchestra_media.repository.media');
    }

    /**
     * @param string $keywords
     * @param int    $count
     *
     * @dataProvider provideKeywordAndCount
     */
    public function testFindByKeywords($keywords, $count)
    {
        $keywords = $this->replaceKeywordLabelById($keywords);
        $keywords = $this->repository->findByKeywords($keywords);

        $this->assertCount($count, $keywords);
    }

    /**
     * @return array
     */
    public function provideKeywordAndCount()
    {
        return array(
            array('lorem', 5),
            array('sit', 0),
            array('dolor', 4),
            array('lorem OR dolor', 5),
        );
    }

    /**
     * @param string $condition
     *
     * @return array
     */
    protected function replaceKeywordLabelById($condition)

    {
        $conditionWithoutOperator = preg_replace(explode('|', KeywordableTraitInterface::OPERATOR_SPLIT), ' ', $condition);
        $conditionArray = explode(' ', $conditionWithoutOperator);

        foreach ($conditionArray as $keyword) {
            if ($keyword != '') {
                $keywordDocument = $this->keywordRepository->findOneByLabel($keyword);
                if (!is_null($keywordDocument)) {
                    $condition = str_replace($keyword, $keywordDocument->getId(), $condition);
                } else {
                    return '';
                }
            }
        }

        return $condition;
    }

    /**
     * test findForPaginate
     *
     * @param PaginateFinderConfiguration $configuration
     * @param int                         $expectedCount
     * @param int                         $expectedFilteredCount
     *
     * @dataProvider providePaginateConfiguration
     */
    public function testFindForPaginate(PaginateFinderConfiguration $configuration, $expectedCount, $expectedFilteredCount)
    {
        $this->assertCount($expectedCount, $this->repository->findForPaginate($configuration));
    }

    /**
     * test count
     */
    public function testCount()
    {
        $this->assertSame(6, $this->repository->count());
    }

    /**
     * test count with Filtertered
     */
    public function testCountFiltered()
    {
        $this->assertSame(1, $this->repository->count('pdf'));
        $this->assertSame(5, $this->repository->count('image'));
    }

    /**
     * test countWithFilter
     *
     * @param PaginateFinderConfiguration $configuration
     * @param int                         $expectedCount
     * @param int                         $expectedFilteredCount
     *
     * @dataProvider providePaginateConfiguration
     */
    public function testCountWithFilter(PaginateFinderConfiguration $configuration, $expectedCount, $expectedFilteredCount)
    {
        $this->assertSame($expectedFilteredCount, $this->repository->countWithFilter($configuration));
    }

    /**
     * Provide PaginateFinderConfiguration
     *
     * @return array
     */
    public function providePaginateConfiguration()
    {
        $mapping =  array();
        $conf1 = PaginateFinderConfiguration::generateFromVariable(null , null, null, $mapping, null);
        $conf2 = PaginateFinderConfiguration::generateFromVariable(null , null, null, $mapping, array('label' => 'dolor', 'language' => 'en'));
        $conf3 = PaginateFinderConfiguration::generateFromVariable(null , null, null, $mapping, array('type' => 'pdf'));

        return array(
            'No criteria'       => array($conf1, 6, 6),
            'Filtering "dolor"' => array($conf2, 4, 4),
            'Filtering pdf'     => array($conf3, 1, 1),
        );
    }

    /**
     * Test remove medias
     */
    public function testRemoveMedias()

    {
        $dm = static::$kernel->getContainer()->get('object_manager');
        $image01 = $this->repository->findOneByName('Image 01');
        $image02 = $this->repository->findOneByName('Image 02');

        $mediaIds = array($image01->getId(), $image02->getId());

        $this->repository->removeMedias($mediaIds);
        $this->assertNull($this->repository->findOneByName('Image 01'));
        $this->assertNull($this->repository->findOneByName('Image 02'));

        $dm->persist(clone $image01);
        $dm->persist(clone $image02);
        $dm->flush();
    }
}


1		<?php
2
3		namespace OpenOrchestra\FunctionalTests\MediaBundle\Repository;
4
5		use OpenOrchestra\BaseBundle\Tests\AbstractTest\AbstractKernelTestCase;
6		use OpenOrchestra\Media\Repository\MediaRepositoryInterface;
7		use OpenOrchestra\ModelInterface\Repository\RepositoryTrait\KeywordableTraitInterface;
8		use OpenOrchestra\Pagination\Configuration\PaginateFinderConfiguration;
9
10		/**
11		* Class MediaRepositoryTest
12		*
13		* @group integrationTest
14		*/
15		class MediaRepositoryTest extends AbstractKernelTestCase
16		{
17		/**
18		* @var MediaRepositoryInterface
19		*/
20		protected $repository;
21		protected $keywordRepository;
22
23		/**
24		* Set up test
25		*/
26		protected function setUp()
27		{
28		parent::setUp();
29
30		static::bootKernel();
31		$this->keywordRepository = static::$kernel->getContainer()->get('open_orchestra_model.repository.keyword');
32		$this->repository = static::$kernel->getContainer()->get('open_orchestra_media.repository.media');
33		}
34
35		/**
36		* @param string $keywords
37		* @param int $count
38		*
39		* @dataProvider provideKeywordAndCount
40		*/
41		public function testFindByKeywords($keywords, $count)
42		{
43		$keywords = $this->replaceKeywordLabelById($keywords);
44		$keywords = $this->repository->findByKeywords($keywords);
45
46		$this->assertCount($count, $keywords);
47		}
48
49		/**
50		* @return array
51		*/
52		public function provideKeywordAndCount()
53		{
54		return array(
55		array('lorem', 5),
56		array('sit', 0),
57		array('dolor', 4),
58		array('lorem OR dolor', 5),
59		);
60		}
61
62		/**
63		* @param string $condition
64		*
65		* @return array
66		*/
67	View Code Duplication	protected function replaceKeywordLabelById($condition)
		0 ignored issues – show Duplication introduced 2016-06-28 13:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68		{
69		$conditionWithoutOperator = preg_replace(explode('\|', KeywordableTraitInterface::OPERATOR_SPLIT), ' ', $condition);
70		$conditionArray = explode(' ', $conditionWithoutOperator);
71
72		foreach ($conditionArray as $keyword) {
73		if ($keyword != '') {
74		$keywordDocument = $this->keywordRepository->findOneByLabel($keyword);
75		if (!is_null($keywordDocument)) {
76		$condition = str_replace($keyword, $keywordDocument->getId(), $condition);
77		} else {
78		return '';
79		}
80		}
81		}
82
83		return $condition;
84		}
85
86		/**
87		* test findForPaginate
88		*
89		* @param PaginateFinderConfiguration $configuration
90		* @param int $expectedCount
91		* @param int $expectedFilteredCount
92		*
93		* @dataProvider providePaginateConfiguration
94		*/
95		public function testFindForPaginate(PaginateFinderConfiguration $configuration, $expectedCount, $expectedFilteredCount)
96		{
97		$this->assertCount($expectedCount, $this->repository->findForPaginate($configuration));
98		}
99
100		/**
101		* test count
102		*/
103		public function testCount()
104		{
105		$this->assertSame(6, $this->repository->count());
106		}
107
108		/**
109		* test count with Filtertered
110		*/
111		public function testCountFiltered()
112		{
113		$this->assertSame(1, $this->repository->count('pdf'));
114		$this->assertSame(5, $this->repository->count('image'));
115		}
116
117		/**
118		* test countWithFilter
119		*
120		* @param PaginateFinderConfiguration $configuration
121		* @param int $expectedCount
122		* @param int $expectedFilteredCount
123		*
124		* @dataProvider providePaginateConfiguration
125		*/
126		public function testCountWithFilter(PaginateFinderConfiguration $configuration, $expectedCount, $expectedFilteredCount)
127		{
128		$this->assertSame($expectedFilteredCount, $this->repository->countWithFilter($configuration));
129		}
130
131		/**
132		* Provide PaginateFinderConfiguration
133		*
134		* @return array
135		*/
136		public function providePaginateConfiguration()
137		{
138		$mapping = array();
139		$conf1 = PaginateFinderConfiguration::generateFromVariable(null , null, null, $mapping, null);
140		$conf2 = PaginateFinderConfiguration::generateFromVariable(null , null, null, $mapping, array('label' => 'dolor', 'language' => 'en'));
141		$conf3 = PaginateFinderConfiguration::generateFromVariable(null , null, null, $mapping, array('type' => 'pdf'));
142
143		return array(
144		'No criteria' => array($conf1, 6, 6),
145		'Filtering "dolor"' => array($conf2, 4, 4),
146		'Filtering pdf' => array($conf3, 1, 1),
147		);
148		}
149
150		/**
151		* Test remove medias
152		*/
153	View Code Duplication	public function testRemoveMedias()
		0 ignored issues – show Duplication introduced 2017-02-02 17:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
154		{
155		$dm = static::$kernel->getContainer()->get('object_manager');
156		$image01 = $this->repository->findOneByName('Image 01');
157		$image02 = $this->repository->findOneByName('Image 02');
158
159		$mediaIds = array($image01->getId(), $image02->getId());
160
161		$this->repository->removeMedias($mediaIds);
162		$this->assertNull($this->repository->findOneByName('Image 01'));
163		$this->assertNull($this->repository->findOneByName('Image 02'));
164
165		$dm->persist(clone $image01);
166		$dm->persist(clone $image02);
167		$dm->flush();
168		}
169		}
170

open-orchestra / open-orchestra

Push — master ( d1d910...7edec1 )

Repository/MediaRepositoryTest.php (2 issues)

Showing only issues like (Show All)

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like