Issues in GroupRepositoryTest.php - All Issues - Inspection of "remove theme (#1157)" - open-orchestra/open-orchestra - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d1d910...7edec1 )

by amaury

created 2017-03-02 13:47 UTC

GroupBundle/Repository/GroupRepositoryTest.php (3 issues)

Labels

Severity

Nicolas ANNE 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace OpenOrchestra\FunctionalTests\GroupBundle\Repository;

use OpenOrchestra\Backoffice\Repository\GroupRepositoryInterface;
use OpenOrchestra\BaseBundle\Tests\AbstractTest\AbstractKernelTestCase;
use OpenOrchestra\ModelBundle\Repository\SiteRepository;
use OpenOrchestra\Pagination\Configuration\PaginateFinderConfiguration;
use OpenOrchestra\GroupBundle\Document\Group;

/**
 * Class GroupRepositoryTest
 *
 * @group integrationTest
 */
class GroupRepositoryTest extends AbstractKernelTestCase
{
    /**
     * @var GroupRepositoryInterface
     */
    protected $repository;

    /**
     * @var SiteRepository
     */
    protected $siteRepository;

    /**
     * Set up test
     */
    protected function setUp()
    {
        parent::setUp();

        static::bootKernel();
        $this->repository = static::$kernel->getContainer()->get('open_orchestra_user.repository.group');
        $this->siteRepository = static::$kernel->getContainer()->get('open_orchestra_model.repository.site');
    }

    /**
     * @param PaginateFinderConfiguration $configuration
     * @param array                       $siteIds
     * @param int                         $count
     *
     * @dataProvider provideConfigurationAndSites
     */
    public function testFindForPaginate(PaginateFinderConfiguration $configuration, array $siteIds, $count)
    {
        $siteIds = $this->generateMongoIdForSite($siteIds);
        $groups = $this->repository->findForPaginate($configuration, $siteIds);

        $this->assertCount($count, $groups);
    }

    /**
     * test count all user
     *
     * @param PaginateFinderConfiguration $configuration
     * @param array                       $siteIds
     * @param int                         $count
     *
     * @dataProvider provideConfigurationAndSites
     */
    public function testCount(PaginateFinderConfiguration $configuration, array $siteIds, $count)

    {
        $siteIds = $this->generateMongoIdForSite($siteIds);
        $groups = $this->repository->count($siteIds);

        $this->assertEquals($count, $groups);
    }

    /**
     * @return array
     */
    public function provideConfigurationAndSites()
    {
        $configuration = new PaginateFinderConfiguration();
        $configuration->setPaginateConfiguration(null, 0, 100, array('label' => 'labels'));
        return array(
            array($configuration, array(), 0),
            array($configuration, array('2'), 2),
            array($configuration, array('2', '3'), 3),
            array($configuration, array('test'), 0),
        );
    }

    /**
     * test findAllWithSite
     */
    public function testFindAllWithSite()
    {
        $groups = $this->repository->findAllWithSite();
        $this->assertCount(3, $groups);
    }

    /**
     * test findAllWithSiteId
     *
     * @param string $siteId
     * @param int    $expectedGroupCount
     *
     * @dataProvider provideSiteId
     */
    public function testFindAllWithSiteId($siteId, $expectedGroupCount)
    {
        $site = $this->siteRepository->findOneBySiteId($siteId);
        $groups = $this->repository->findAllWithSiteId($site->getId());

        $this->assertCount($expectedGroupCount, $groups);
    }

    /**
     * Provite site mongoId
     */
    public function provideSiteId()
    {
        return array(
             'Empty site' => array('3', 1),
             'Demo site' => array('2', 2)
        );
    }

    /**
     * @param PaginateFinderConfiguration $configuration
     * @param array                       $siteIds
     * @param int                         $count
     *
     * @dataProvider provideColumnsAndSearchAndCount
     */
    public function testCountWithFilter(PaginateFinderConfiguration $configuration, array $siteIds, $count)
    {
        $siteIds = $this->generateMongoIdForSite($siteIds);
        $groups = $this->repository->countWithFilter($configuration, $siteIds);

        $this->assertEquals($count, $groups);
    }

    /**
     * @return array
     */
    public function provideColumnsAndSearchAndCount(){

        $configuration = new PaginateFinderConfiguration();
        $configuration->setPaginateConfiguration(null, 0, 100, array('label' => 'labels'));

        $configuration->setSearch(array('language' => 'en', 'label' => 'site'));

        return array(
            array($configuration, array(), 0),
            array($configuration, array('2'), 1),
            array($configuration, array('2', '3'), 1),
            array($configuration, array('test'), 0),
        );
    }

    /**
     * Test remove users
     */
    public function testRemoveGroups()
    {
        $dm = static::$kernel->getContainer()->get('object_manager');

        $groupTest = new Group();
        $groupTest->setName('test');
        $dm->persist($groupTest);
        $dm->flush();
        $dm->clear();

        $groupTest = $this->repository->findOneByName('test');


        $groupIds = array($groupTest->getId());

        $this->repository->removeGroups($groupIds);
        $this->assertNull($this->repository->findOneByName('test'));

    }

   /**
     * Test remove users
     */
    public function testSoftDeleteGroupBySite()
    {
        $dm = static::$kernel->getContainer()->get('object_manager');
        $site = $this->siteRepository->findOneBySiteId('3');
        $this->repository->softDeleteGroupsBySite($site);

        $groups = $this->repository->findAllWithSiteId($site->getId());

        foreach ($groups as $group) {
            $this->assertTrue($group->isDeleted());
            $group->setDeleted(false);
        }
        $dm->flush();
    }

    /**
     * Generate columns of content with search value
     *
     * @param string $searchName
     * @param string $globalSearch
     *
     * @return array
     */
    protected function generateSearchProvider($searchName = '', $globalSearch = '')
    {
        $search = array();
        if (!empty($searchName)) {
            $search['columns'] = array('name' => $searchName);
        }
        if (!empty($globalSearch)) {
            $search['global'] = $globalSearch;
        }

        return $search;
    }

    /**
     * @param array $siteIds
     *
     * @return array
     */
    protected function generateMongoIdForSite(array $siteIds)
    {
        foreach ($siteIds as $key => $siteId) {
            $site = $this->siteRepository->findOneBySiteId($siteId);
            if (null !== $site) {
                $siteIds[$key] = $site->getId();
            } else {
                unset($siteIds[$key]);
            }
        }

        return $siteIds;
    }

    /**
     * Generate relation between columns names and entities attributes
     *
     * @return array
     */
    protected function getDescriptionColumnEntity()
    {

        return array(
            'name' => array('key' => 'name', 'field' => 'name', 'type' => 'string')
        );
    }

}


1			<?php
2
3			namespace OpenOrchestra\FunctionalTests\GroupBundle\Repository;
4
5			use OpenOrchestra\Backoffice\Repository\GroupRepositoryInterface;
6			use OpenOrchestra\BaseBundle\Tests\AbstractTest\AbstractKernelTestCase;
7			use OpenOrchestra\ModelBundle\Repository\SiteRepository;
8			use OpenOrchestra\Pagination\Configuration\PaginateFinderConfiguration;
9			use OpenOrchestra\GroupBundle\Document\Group;
10
11			/**
12			* Class GroupRepositoryTest
13			*
14			* @group integrationTest
15			*/
16			class GroupRepositoryTest extends AbstractKernelTestCase
17			{
18			/**
19			* @var GroupRepositoryInterface
20			*/
21			protected $repository;
22
23			/**
24			* @var SiteRepository
25			*/
26			protected $siteRepository;
27
28			/**
29			* Set up test
30			*/
31			protected function setUp()
32			{
33			parent::setUp();
34
35			static::bootKernel();
36			$this->repository = static::$kernel->getContainer()->get('open_orchestra_user.repository.group');
37			$this->siteRepository = static::$kernel->getContainer()->get('open_orchestra_model.repository.site');
38			}
39
40			/**
41			* @param PaginateFinderConfiguration $configuration
42			* @param array $siteIds
43			* @param int $count
44			*
45			* @dataProvider provideConfigurationAndSites
46			*/
47			public function testFindForPaginate(PaginateFinderConfiguration $configuration, array $siteIds, $count)
48			{
49			$siteIds = $this->generateMongoIdForSite($siteIds);
50			$groups = $this->repository->findForPaginate($configuration, $siteIds);
51
52			$this->assertCount($count, $groups);
53			}
54
55			/**
56			* test count all user
57			*
58			* @param PaginateFinderConfiguration $configuration
59			* @param array $siteIds
60			* @param int $count
61			*
62			* @dataProvider provideConfigurationAndSites
63			*/
64			public function testCount(PaginateFinderConfiguration $configuration, array $siteIds, $count)
			0 ignored issues – show Unused Code introduced 2016-12-06 15:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$configuration` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
65			{
66			$siteIds = $this->generateMongoIdForSite($siteIds);
67			$groups = $this->repository->count($siteIds);
68
69			$this->assertEquals($count, $groups);
70			}
71
72			/**
73			* @return array
74			*/
75			public function provideConfigurationAndSites()
76			{
77			$configuration = new PaginateFinderConfiguration();
78			$configuration->setPaginateConfiguration(null, 0, 100, array('label' => 'labels'));
79			return array(
80			array($configuration, array(), 0),
81			array($configuration, array('2'), 2),
82			array($configuration, array('2', '3'), 3),
83			array($configuration, array('test'), 0),
84			);
85			}
86
87			/**
88			* test findAllWithSite
89			*/
90			public function testFindAllWithSite()
91			{
92			$groups = $this->repository->findAllWithSite();
93			$this->assertCount(3, $groups);
94			}
95
96			/**
97			* test findAllWithSiteId
98			*
99			* @param string $siteId
100			* @param int $expectedGroupCount
101			*
102			* @dataProvider provideSiteId
103			*/
104			public function testFindAllWithSiteId($siteId, $expectedGroupCount)
105			{
106			$site = $this->siteRepository->findOneBySiteId($siteId);
107			$groups = $this->repository->findAllWithSiteId($site->getId());
108
109			$this->assertCount($expectedGroupCount, $groups);
110			}
111
112			/**
113			* Provite site mongoId
114			*/
115			public function provideSiteId()
116			{
117			return array(
118			'Empty site' => array('3', 1),
119			'Demo site' => array('2', 2)
120			);
121			}
122
123			/**
124			* @param PaginateFinderConfiguration $configuration
125			* @param array $siteIds
126			* @param int $count
127			*
128			* @dataProvider provideColumnsAndSearchAndCount
129			*/
130			public function testCountWithFilter(PaginateFinderConfiguration $configuration, array $siteIds, $count)
131			{
132			$siteIds = $this->generateMongoIdForSite($siteIds);
133			$groups = $this->repository->countWithFilter($configuration, $siteIds);
134
135			$this->assertEquals($count, $groups);
136			}
137
138			/**
139			* @return array
140			*/
141			public function provideColumnsAndSearchAndCount(){
142
143			$configuration = new PaginateFinderConfiguration();
144			$configuration->setPaginateConfiguration(null, 0, 100, array('label' => 'labels'));
145
146			$configuration->setSearch(array('language' => 'en', 'label' => 'site'));
147
148			return array(
149			array($configuration, array(), 0),
150			array($configuration, array('2'), 1),
151			array($configuration, array('2', '3'), 1),
152			array($configuration, array('test'), 0),
153			);
154			}
155
156			/**
157			* Test remove users
158			*/
159			public function testRemoveGroups()
160			{
161			$dm = static::$kernel->getContainer()->get('object_manager');
162
163			$groupTest = new Group();
164			$groupTest->setName('test');
165			$dm->persist($groupTest);
166			$dm->flush();
167			$dm->clear();
168
169			$groupTest = $this->repository->findOneByName('test');
			0 ignored issues – show Bug introduced 2016-12-16 16:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `findOneByName()` does not seem to exist on `object<OpenOrchestra\Bac...oupRepositoryInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
170
171			$groupIds = array($groupTest->getId());
172
173			$this->repository->removeGroups($groupIds);
174			$this->assertNull($this->repository->findOneByName('test'));
			0 ignored issues – show Bug introduced 2016-12-16 16:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `findOneByName()` does not seem to exist on `object<OpenOrchestra\Bac...oupRepositoryInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
175			}
176
177			/**
178			* Test remove users
179			*/
180			public function testSoftDeleteGroupBySite()
181			{
182			$dm = static::$kernel->getContainer()->get('object_manager');
183			$site = $this->siteRepository->findOneBySiteId('3');
184			$this->repository->softDeleteGroupsBySite($site);
185
186			$groups = $this->repository->findAllWithSiteId($site->getId());
187
188			foreach ($groups as $group) {
189			$this->assertTrue($group->isDeleted());
190			$group->setDeleted(false);
191			}
192			$dm->flush();
193			}
194
195			/**
196			* Generate columns of content with search value
197			*
198			* @param string $searchName
199			* @param string $globalSearch
200			*
201			* @return array
202			*/
203			protected function generateSearchProvider($searchName = '', $globalSearch = '')
204			{
205			$search = array();
206			if (!empty($searchName)) {
207			$search['columns'] = array('name' => $searchName);
208			}
209			if (!empty($globalSearch)) {
210			$search['global'] = $globalSearch;
211			}
212
213			return $search;
214			}
215
216			/**
217			* @param array $siteIds
218			*
219			* @return array
220			*/
221			protected function generateMongoIdForSite(array $siteIds)
222			{
223			foreach ($siteIds as $key => $siteId) {
224			$site = $this->siteRepository->findOneBySiteId($siteId);
225			if (null !== $site) {
226			$siteIds[$key] = $site->getId();
227			} else {
228			unset($siteIds[$key]);
229			}
230			}
231
232			return $siteIds;
233			}
234
235			/**
236			* Generate relation between columns names and entities attributes
237			*
238			* @return array
239			*/
240			protected function getDescriptionColumnEntity()
241			{
242
243			return array(
244			'name' => array('key' => 'name', 'field' => 'name', 'type' => 'string')
245			);
246			}
247
248			}
249

open-orchestra / open-orchestra

Push — master ( d1d910...7edec1 )

GroupBundle/Repository/GroupRepositoryTest.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like