Issues in PublishElementCommandTrait.php - All Issues - Inspection of "remove theme (#1157)" - open-orchestra/open-orchestra - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d1d910...7edec1 )

by amaury

created 2017-03-02 13:47 UTC

Command/PublishElementCommandTrait.php (1 issue)

Labels

Bug 1

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace OpenOrchestra\FunctionalTests\BackofficeBundle\Command;

use Symfony\Component\Console\Tester\CommandTester;

/**
 * Class PublishElementCommandTrait
 */
trait PublishElementCommandTrait
{
    /**
     * @param string $siteId
     * @param string $commandName
     * @param string $repositoryName
     * @param string $entityName
     */
    public function executePublish($siteId, $commandName, $repositoryName, $entityName)
    {
        $command = $this->application->find($commandName);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $commandTester = new CommandTester($command);

        $site = static::$kernel->getContainer()->get('open_orchestra_model.repository.site')->findOneBySiteId($siteId);
        $fromStatus = static::$kernel->getContainer()->get('open_orchestra_model.repository.status')
            ->findByAutoPublishFrom();
        $elements = static::$kernel->getContainer()->get($repositoryName)
            ->findElementToAutoPublish($site->getSiteId(), $fromStatus);

        $commandTester->execute(array('command' => $command->getName()));
        $this->assertRegExp(
            '/Publishing '.$entityName.'s for siteId ' . $siteId . '/',
            $commandTester->getDisplay()
        );

        foreach ($elements as $element) {
            $this->assertRegExp(
                '/-> ' . $element->getName() . ' \(v' . $element->getVersion() . ' ' . $element->getLanguage() . '\) published/',
                $commandTester->getDisplay()
            );
        }

        $this->assertRegExp('/Done./', $commandTester->getDisplay());
    }
    /**
     * @param string $siteId
     * @param string $commandName
     * @param string $repositoryName
     * @param string $entityName
     */
    public function executeUnpublish($siteId, $commandName, $repositoryName, $entityName)
    {
        $command = $this->application->find($commandName);
        $commandTester = new CommandTester($command);

        $site = static::$kernel->getContainer()->get('open_orchestra_model.repository.site')->findOneBySiteId($siteId);
        $fromStatus = static::$kernel->getContainer()->get('open_orchestra_model.repository.status')
            ->findOneByPublished();
        $elements = static::$kernel->getContainer()->get($repositoryName)
            ->findElementToAutoUnpublish($site->getSiteId(), $fromStatus);

        $commandTester->execute(array('command' => $command->getName()));
        $this->assertRegExp(
            '/Unpublishing '.$entityName.'s for siteId ' . $siteId . '/',
            $commandTester->getDisplay()
        );

        foreach ($elements as $element) {
            $this->assertRegExp(
                '/-> ' . $element->getName() . ' \(v' . $element->getVersion() . ' ' . $element->getLanguage() . '\) unpublished/',
                $commandTester->getDisplay()
            );
        }

        $this->assertRegExp('/Done./', $commandTester->getDisplay());
    }
}


1		<?php
2
3		namespace OpenOrchestra\FunctionalTests\BackofficeBundle\Command;
4
5		use Symfony\Component\Console\Tester\CommandTester;
6
7		/**
8		* Class PublishElementCommandTrait
9		*/
10		trait PublishElementCommandTrait
11		{
12		/**
13		* @param string $siteId
14		* @param string $commandName
15		* @param string $repositoryName
16		* @param string $entityName
17		*/
18	View Code Duplication	public function executePublish($siteId, $commandName, $repositoryName, $entityName)
19		{
20		$command = $this->application->find($commandName);
		0 ignored issues – show Bug introduced 2017-01-30 12:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `application` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
21		$commandTester = new CommandTester($command);
22
23		$site = static::$kernel->getContainer()->get('open_orchestra_model.repository.site')->findOneBySiteId($siteId);
24		$fromStatus = static::$kernel->getContainer()->get('open_orchestra_model.repository.status')
25		->findByAutoPublishFrom();
26		$elements = static::$kernel->getContainer()->get($repositoryName)
27		->findElementToAutoPublish($site->getSiteId(), $fromStatus);
28
29		$commandTester->execute(array('command' => $command->getName()));
30		$this->assertRegExp(
31		'/Publishing '.$entityName.'s for siteId ' . $siteId . '/',
32		$commandTester->getDisplay()
33		);
34
35		foreach ($elements as $element) {
36		$this->assertRegExp(
37		'/-> ' . $element->getName() . ' \(v' . $element->getVersion() . ' ' . $element->getLanguage() . '\) published/',
38		$commandTester->getDisplay()
39		);
40		}
41
42		$this->assertRegExp('/Done./', $commandTester->getDisplay());
43		}
44		/**
45		* @param string $siteId
46		* @param string $commandName
47		* @param string $repositoryName
48		* @param string $entityName
49		*/
50	View Code Duplication	public function executeUnpublish($siteId, $commandName, $repositoryName, $entityName)
51		{
52		$command = $this->application->find($commandName);
53		$commandTester = new CommandTester($command);
54
55		$site = static::$kernel->getContainer()->get('open_orchestra_model.repository.site')->findOneBySiteId($siteId);
56		$fromStatus = static::$kernel->getContainer()->get('open_orchestra_model.repository.status')
57		->findOneByPublished();
58		$elements = static::$kernel->getContainer()->get($repositoryName)
59		->findElementToAutoUnpublish($site->getSiteId(), $fromStatus);
60
61		$commandTester->execute(array('command' => $command->getName()));
62		$this->assertRegExp(
63		'/Unpublishing '.$entityName.'s for siteId ' . $siteId . '/',
64		$commandTester->getDisplay()
65		);
66
67		foreach ($elements as $element) {
68		$this->assertRegExp(
69		'/-> ' . $element->getName() . ' \(v' . $element->getVersion() . ' ' . $element->getLanguage() . '\) unpublished/',
70		$commandTester->getDisplay()
71		);
72		}
73
74		$this->assertRegExp('/Done./', $commandTester->getDisplay());
75		}
76		}
77

open-orchestra / open-orchestra

Push — master ( d1d910...7edec1 )

Command/PublishElementCommandTrait.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like