Issues in GroupRepositoryTest.php - New Issues - Inspection of "Move test functional (#1186)" - open-orchestra/open-orchestra - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c3eba2...34879d )

by amaury

created 2017-04-06 09:08 UTC

GroupBundle/Repository/GroupRepositoryTest.php (2 issues)

Labels

Bug 2

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace OpenOrchestra\FunctionalTests\GroupBundle\Repository;

use OpenOrchestra\Backoffice\Repository\GroupRepositoryInterface;
use OpenOrchestra\BaseBundle\Tests\AbstractTest\AbstractKernelTestCase;
use OpenOrchestra\ModelBundle\Repository\SiteRepository;
use OpenOrchestra\Pagination\Configuration\PaginateFinderConfiguration;
use OpenOrchestra\GroupBundle\Document\Group;

/**
 * Class GroupRepositoryTest
 *
 * @group integrationTest
 */
class GroupRepositoryTest extends AbstractKernelTestCase
{
    /**
     * @var GroupRepositoryInterface
     */
    protected $repository;

    /**
     * @var SiteRepository
     */
    protected $siteRepository;

    /**
     * Set up test
     */
    protected function setUp()
    {
        parent::setUp();

        static::bootKernel();
        $this->repository = static::$kernel->getContainer()->get('open_orchestra_user.repository.group');
        $this->siteRepository = static::$kernel->getContainer()->get('open_orchestra_model.repository.site');
    }

    /**
     * @param PaginateFinderConfiguration $configuration
     * @param array                       $siteIds
     * @param int                         $count
     *
     * @dataProvider provideConfigurationAndSites
     */
    public function testFindForPaginate(PaginateFinderConfiguration $configuration, array $siteIds, $count)
    {
        $siteIds = $this->generateMongoIdForSite($siteIds);
        $groups = $this->repository->findForPaginate($configuration, $siteIds);

        $this->assertCount($count, $groups);
    }

    /**
     * test count all user
     *
     * @param PaginateFinderConfiguration $configuration
     * @param array                       $siteIds
     * @param int                         $count
     *
     * @dataProvider provideConfigurationAndSites
     */
    public function testCount(PaginateFinderConfiguration $configuration, array $siteIds, $count)
    {
        $siteIds = $this->generateMongoIdForSite($siteIds);
        $groups = $this->repository->count($siteIds);

        $this->assertEquals($count, $groups);
    }

    /**
     * @return array
     */
    public function provideConfigurationAndSites()
    {
        $configuration = new PaginateFinderConfiguration();
        $configuration->setPaginateConfiguration(null, 0, 100, array('label' => 'labels'));
        return array(
            array($configuration, array(), 0),
            array($configuration, array('2'), 2),
            array($configuration, array('2', '3'), 3),
            array($configuration, array('test'), 0),
        );
    }

    /**
     * @param PaginateFinderConfiguration $configuration
     * @param array                       $siteIds
     * @param int                         $count
     *
     * @dataProvider provideColumnsAndSearchAndCount
     */
    public function testCountWithFilter(PaginateFinderConfiguration $configuration, array $siteIds, $count)
    {
        $siteIds = $this->generateMongoIdForSite($siteIds);
        $groups = $this->repository->countWithFilter($configuration, $siteIds);

        $this->assertEquals($count, $groups);
    }

    /**
     * @return array
     */
    public function provideColumnsAndSearchAndCount(){

        $configuration = new PaginateFinderConfiguration();
        $configuration->setPaginateConfiguration(null, 0, 100, array('label' => 'labels'));

        $configuration->setSearch(array('language' => 'en', 'label' => 'site'));

        return array(
            array($configuration, array(), 0),
            array($configuration, array('2'), 1),
            array($configuration, array('2', '3'), 1),
            array($configuration, array('test'), 0),
        );
    }

    /**
     * Test remove users
     */
    public function testRemoveGroups()
    {
        $dm = static::$kernel->getContainer()->get('object_manager');

        $groupTest = new Group();
        $groupTest->setName('test');
        $dm->persist($groupTest);
        $dm->flush();
        $dm->clear();

        $groupTest = $this->repository->findOneByName('test');


        $groupIds = array($groupTest->getId());

        $this->repository->removeGroups($groupIds);
        $this->assertNull($this->repository->findOneByName('test'));

    }

   /**
     * Test remove users
     */
    public function testSoftDeleteGroupBySite()
    {
        $dm = static::$kernel->getContainer()->get('object_manager');
        $site = $this->siteRepository->findOneBySiteId('3');
        $this->repository->softDeleteGroupsBySite($site);

        $groups = $this->repository->findBy(
            array('site.$id' => new \MongoId($site->getId()))
        );

        foreach ($groups as $group) {
            $this->assertTrue($group->isDeleted());
            $group->setDeleted(false);
        }
        $dm->flush();
    }

    /**
     * Generate columns of content with search value
     *
     * @param string $searchName
     * @param string $globalSearch
     *
     * @return array
     */
    protected function generateSearchProvider($searchName = '', $globalSearch = '')
    {
        $search = array();
        if (!empty($searchName)) {
            $search['columns'] = array('name' => $searchName);
        }
        if (!empty($globalSearch)) {
            $search['global'] = $globalSearch;
        }

        return $search;
    }

    /**
     * @param array $siteIds
     *
     * @return array
     */
    protected function generateMongoIdForSite(array $siteIds)
    {
        foreach ($siteIds as $key => $siteId) {
            $site = $this->siteRepository->findOneBySiteId($siteId);
            if (null !== $site) {
                $siteIds[$key] = $site->getId();
            } else {
                unset($siteIds[$key]);
            }
        }

        return $siteIds;
    }

    /**
     * Generate relation between columns names and entities attributes
     *
     * @return array
     */
    protected function getDescriptionColumnEntity()
    {

        return array(
            'name' => array('key' => 'name', 'field' => 'name', 'type' => 'string')
        );
    }

}


1		<?php
2
3		namespace OpenOrchestra\FunctionalTests\GroupBundle\Repository;
4
5		use OpenOrchestra\Backoffice\Repository\GroupRepositoryInterface;
6		use OpenOrchestra\BaseBundle\Tests\AbstractTest\AbstractKernelTestCase;
7		use OpenOrchestra\ModelBundle\Repository\SiteRepository;
8		use OpenOrchestra\Pagination\Configuration\PaginateFinderConfiguration;
9		use OpenOrchestra\GroupBundle\Document\Group;
10
11		/**
12		* Class GroupRepositoryTest
13		*
14		* @group integrationTest
15		*/
16		class GroupRepositoryTest extends AbstractKernelTestCase
17		{
18		/**
19		* @var GroupRepositoryInterface
20		*/
21		protected $repository;
22
23		/**
24		* @var SiteRepository
25		*/
26		protected $siteRepository;
27
28		/**
29		* Set up test
30		*/
31	View Code Duplication	protected function setUp()
32		{
33		parent::setUp();
34
35		static::bootKernel();
36		$this->repository = static::$kernel->getContainer()->get('open_orchestra_user.repository.group');
37		$this->siteRepository = static::$kernel->getContainer()->get('open_orchestra_model.repository.site');
38		}
39
40		/**
41		* @param PaginateFinderConfiguration $configuration
42		* @param array $siteIds
43		* @param int $count
44		*
45		* @dataProvider provideConfigurationAndSites
46		*/
47		public function testFindForPaginate(PaginateFinderConfiguration $configuration, array $siteIds, $count)
48		{
49		$siteIds = $this->generateMongoIdForSite($siteIds);
50		$groups = $this->repository->findForPaginate($configuration, $siteIds);
51
52		$this->assertCount($count, $groups);
53		}
54
55		/**
56		* test count all user
57		*
58		* @param PaginateFinderConfiguration $configuration
59		* @param array $siteIds
60		* @param int $count
61		*
62		* @dataProvider provideConfigurationAndSites
63		*/
64		public function testCount(PaginateFinderConfiguration $configuration, array $siteIds, $count)
65		{
66		$siteIds = $this->generateMongoIdForSite($siteIds);
67		$groups = $this->repository->count($siteIds);
68
69		$this->assertEquals($count, $groups);
70		}
71
72		/**
73		* @return array
74		*/
75		public function provideConfigurationAndSites()
76		{
77		$configuration = new PaginateFinderConfiguration();
78		$configuration->setPaginateConfiguration(null, 0, 100, array('label' => 'labels'));
79		return array(
80		array($configuration, array(), 0),
81		array($configuration, array('2'), 2),
82		array($configuration, array('2', '3'), 3),
83		array($configuration, array('test'), 0),
84		);
85		}
86
87		/**
88		* @param PaginateFinderConfiguration $configuration
89		* @param array $siteIds
90		* @param int $count
91		*
92		* @dataProvider provideColumnsAndSearchAndCount
93		*/
94		public function testCountWithFilter(PaginateFinderConfiguration $configuration, array $siteIds, $count)
95		{
96		$siteIds = $this->generateMongoIdForSite($siteIds);
97		$groups = $this->repository->countWithFilter($configuration, $siteIds);
98
99		$this->assertEquals($count, $groups);
100		}
101
102		/**
103		* @return array
104		*/
105		public function provideColumnsAndSearchAndCount(){
106
107		$configuration = new PaginateFinderConfiguration();
108		$configuration->setPaginateConfiguration(null, 0, 100, array('label' => 'labels'));
109
110		$configuration->setSearch(array('language' => 'en', 'label' => 'site'));
111
112		return array(
113		array($configuration, array(), 0),
114		array($configuration, array('2'), 1),
115		array($configuration, array('2', '3'), 1),
116		array($configuration, array('test'), 0),
117		);
118		}
119
120		/**
121		* Test remove users
122		*/
123		public function testRemoveGroups()
124		{
125		$dm = static::$kernel->getContainer()->get('object_manager');
126
127		$groupTest = new Group();
128		$groupTest->setName('test');
129		$dm->persist($groupTest);
130		$dm->flush();
131		$dm->clear();
132
133		$groupTest = $this->repository->findOneByName('test');
		0 ignored issues – show Bug introduced 2017-04-05 12:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `findOneByName()` does not seem to exist on `object<OpenOrchestra\Bac...oupRepositoryInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
134
135		$groupIds = array($groupTest->getId());
136
137		$this->repository->removeGroups($groupIds);
138		$this->assertNull($this->repository->findOneByName('test'));
		0 ignored issues – show Bug introduced 2017-04-05 12:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `findOneByName()` does not seem to exist on `object<OpenOrchestra\Bac...oupRepositoryInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
139		}
140
141		/**
142		* Test remove users
143		*/
144		public function testSoftDeleteGroupBySite()
145		{
146		$dm = static::$kernel->getContainer()->get('object_manager');
147		$site = $this->siteRepository->findOneBySiteId('3');
148		$this->repository->softDeleteGroupsBySite($site);
149
150		$groups = $this->repository->findBy(
151		array('site.$id' => new \MongoId($site->getId()))
152		);
153
154		foreach ($groups as $group) {
155		$this->assertTrue($group->isDeleted());
156		$group->setDeleted(false);
157		}
158		$dm->flush();
159		}
160
161		/**
162		* Generate columns of content with search value
163		*
164		* @param string $searchName
165		* @param string $globalSearch
166		*
167		* @return array
168		*/
169		protected function generateSearchProvider($searchName = '', $globalSearch = '')
170		{
171		$search = array();
172		if (!empty($searchName)) {
173		$search['columns'] = array('name' => $searchName);
174		}
175		if (!empty($globalSearch)) {
176		$search['global'] = $globalSearch;
177		}
178
179		return $search;
180		}
181
182		/**
183		* @param array $siteIds
184		*
185		* @return array
186		*/
187		protected function generateMongoIdForSite(array $siteIds)
188		{
189		foreach ($siteIds as $key => $siteId) {
190		$site = $this->siteRepository->findOneBySiteId($siteId);
191		if (null !== $site) {
192		$siteIds[$key] = $site->getId();
193		} else {
194		unset($siteIds[$key]);
195		}
196		}
197
198		return $siteIds;
199		}
200
201		/**
202		* Generate relation between columns names and entities attributes
203		*
204		* @return array
205		*/
206		protected function getDescriptionColumnEntity()
207		{
208
209		return array(
210		'name' => array('key' => 'name', 'field' => 'name', 'type' => 'string')
211		);
212		}
213
214		}
215

open-orchestra / open-orchestra

Push — master ( c3eba2...34879d )

GroupBundle/Repository/GroupRepositoryTest.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like