Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | View Code Duplication | class ShipmentTemplate extends Service |
|
|
|||
11 | { |
||
12 | |||
13 | /** |
||
14 | * @var SoapClient|null |
||
15 | */ |
||
16 | private $_client; |
||
17 | |||
18 | /** |
||
19 | * @var string |
||
20 | */ |
||
21 | private $endPoint = "/ShipmentService.wsdl"; |
||
22 | |||
23 | /** |
||
24 | * Shipment Service constructor |
||
25 | * @throws N11Exception|\SoapFault |
||
26 | */ |
||
27 | public function __construct() |
||
32 | |||
33 | /** |
||
34 | * @param string $templateName |
||
35 | * @return mixed |
||
36 | * @description Teslimat şablon ismi ile aratılan şablonun adres metod gibi özelliklerini gösterme. |
||
37 | * deliverableCities teslimat yapılacak şehirlerin seçimini yaptığımız alan bu alana değer girilmezse tüm şehirlere gönderim yapılacak anlamındadır. |
||
38 | */ |
||
39 | public function getShipmentTemplate(string $templateName) { |
||
43 | |||
44 | } |
||
45 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.