ArrayStopwordAnalyzerTest::stopWordsProvider() - Code Metrics - Inspection of "Add SanitizerFactory" - onoi/tesa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9401a4...2cc7a2 )

by mw

created 2016-08-02 14:22 UTC

ArrayStopwordAnalyzerTest::stopWordsProvider() B

↳ Parent: ArrayStopwordAnalyzerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	24
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	24
rs	8.9713
cc	1
eloc	15
nc	1
nop	0

<?php

namespace Onoi\Tesa\Tests\StopwordAnalyzer;

use Onoi\Tesa\StopwordAnalyzer\ArrayStopwordAnalyzer;

/**
 * @covers \Onoi\Tesa\StopwordAnalyzer\ArrayStopwordAnalyzer
 * @group onoi-tesa
 *
 * @license GNU GPL v2+
 * @since 0.1
 *
 * @author mwjames
 */
class ArrayStopwordAnalyzerTest extends \PHPUnit_Framework_TestCase {

	public function testCanConstruct() {

		$this->assertInstanceOf(
			'\Onoi\Tesa\StopwordAnalyzer\ArrayStopwordAnalyzer',
			new ArrayStopwordAnalyzer()
		);
	}

	/**
	 * @dataProvider stopWordsProvider
	 */
	public function testIsStopWord( $defaultList, $word, $expected ) {

		$instance = new ArrayStopwordAnalyzer( $defaultList );

		$this->assertEquals(
			$expected,
			$instance->isStopWord( $word )
		);
	}

	public function stopWordsProvider() {

		$defaultList = array( 'Foo', 'かつて', 'bAR' );

		$provider[] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			$defaultList,
			'Foo',
			true
		);

		$provider[] = array(
			$defaultList,
			'かつて',
			true
		);

		$provider[] = array(
			$defaultList,
			'bar',
			false
		);

		return $provider;
	}

}


1			<?php
2
3			namespace Onoi\Tesa\Tests\StopwordAnalyzer;
4
5			use Onoi\Tesa\StopwordAnalyzer\ArrayStopwordAnalyzer;
6
7			/**
8			* @covers \Onoi\Tesa\StopwordAnalyzer\ArrayStopwordAnalyzer
9			* @group onoi-tesa
10			*
11			* @license GNU GPL v2+
12			* @since 0.1
13			*
14			* @author mwjames
15			*/
16			class ArrayStopwordAnalyzerTest extends \PHPUnit_Framework_TestCase {
17
18			public function testCanConstruct() {
19
20			$this->assertInstanceOf(
21			'\Onoi\Tesa\StopwordAnalyzer\ArrayStopwordAnalyzer',
22			new ArrayStopwordAnalyzer()
23			);
24			}
25
26			/**
27			* @dataProvider stopWordsProvider
28			*/
29			public function testIsStopWord( $defaultList, $word, $expected ) {
30
31			$instance = new ArrayStopwordAnalyzer( $defaultList );
32
33			$this->assertEquals(
34			$expected,
35			$instance->isStopWord( $word )
36			);
37			}
38
39			public function stopWordsProvider() {
40
41			$defaultList = array( 'Foo', 'かつて', 'bAR' );
42
43			$provider[] = array(
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-08-02 14:35 UTC by Report Bug Copy Issue Report `$provider` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$provider = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
44			$defaultList,
45			'Foo',
46			true
47			);
48
49			$provider[] = array(
50			$defaultList,
51			'かつて',
52			true
53			);
54
55			$provider[] = array(
56			$defaultList,
57			'bar',
58			false
59			);
60
61			return $provider;
62			}
63
64			}
65

onoi / tesa

Push — master ( 9401a4...2cc7a2 )

ArrayStopwordAnalyzerTest::stopWordsProvider() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like