CombinedNGramTokenizerTest::textProvider() - Code Metrics - Inspection of "Add SanitizerFactory" - onoi/tesa - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9401a4...2cc7a2 )

by mw

created 2016-08-02 14:22 UTC

CombinedNGramTokenizerTest::textProvider() A

↳ Parent: CombinedNGramTokenizerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	68
Code Lines	60

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	68
rs	9.2447
cc	1
eloc	60
nc	1
nop	0

How to fix Long Method

<?php

namespace Onoi\Tesa\Tests\Integration;

use Onoi\Tesa\SanitizerFactory;
use Onoi\Tesa\Tokenizer\NGramTokenizer;

/**
 * @group onoi-tesa
 *
 * @license GNU GPL v2+
 * @since 0.1
 *
 * @author mwjames
 */
class CombinedNGramTokenizerTest extends \PHPUnit_Framework_TestCase {

	/**
	 * @dataProvider textProvider
	 */
	public function testNgramWithBeginEndMarker( $languageCode, $ngramSize, $text, $expected ) {

		$sanitizerFactory = new SanitizerFactory();

		$tokenizer = $sanitizerFactory->newNGramTokenizer(
			$sanitizerFactory->newGenericRegExTokenizer()
		);

		$tokenizer->withMarker( true );
		$tokenizer->setNgramSize( $ngramSize );

		$tokens = $tokenizer->tokenize( $text );

		$this->assertEquals(
			$expected,
			$tokens
		);
	}

	public function textProvider() {

		// https://en.wikipedia.org/wiki/Stop_words
		$provider[] = array(
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
			'en',
			'2',
			//
			'In computing, stop words are words which are filtered ...',
			//
			array(
				0 => '_i',
				1 => 'in',
				2 => 'n_',
				3 => '_c',
				4 => 'co',
				5 => 'om',
				6 => 'mp',
				7 => 'pu',
				8 => 'ut',
				9 => 'ti',
				10 => 'in',
				11 => 'ng',
				12 => 'g_',
				13 => '_s',
				14 => 'st',
				15 => 'to',
				16 => 'op',
				17 => 'p_',
				18 => '_w',
				19 => 'wo',
				20 => 'or',
				21 => 'rd',
				22 => 'ds',
				23 => 's_',
				24 => '_a',
				25 => 'ar',
				26 => 're',
				27 => 'e_',
				28 => '_w',
				29 => 'wo',
				30 => 'or',
				31 => 'rd',
				32 => 'ds',
				33 => 's_',
				34 => '_w',
				35 => 'wh',
				36 => 'hi',
				37 => 'ic',
				38 => 'ch',
				39 => 'h_',
				40 => '_a',
				41 => 'ar',
				42 => 're',
				43 => 'e_',
				44 => '_f',
				45 => 'fi',
				46 => 'il',
				47 => 'lt',
				48 => 'te',
				49 => 'er',
				50 => 're',
				51 => 'ed',
				52 => 'd_',
			)
		);

		return $provider;
	}

}


1			<?php
2
3			namespace Onoi\Tesa\Tests\Integration;
4
5			use Onoi\Tesa\SanitizerFactory;
6			use Onoi\Tesa\Tokenizer\NGramTokenizer;
7
8			/**
9			* @group onoi-tesa
10			*
11			* @license GNU GPL v2+
12			* @since 0.1
13			*
14			* @author mwjames
15			*/
16			class CombinedNGramTokenizerTest extends \PHPUnit_Framework_TestCase {
17
18			/**
19			* @dataProvider textProvider
20			*/
21			public function testNgramWithBeginEndMarker( $languageCode, $ngramSize, $text, $expected ) {
22
23			$sanitizerFactory = new SanitizerFactory();
24
25			$tokenizer = $sanitizerFactory->newNGramTokenizer(
26			$sanitizerFactory->newGenericRegExTokenizer()
27			);
28
29			$tokenizer->withMarker( true );
30			$tokenizer->setNgramSize( $ngramSize );
31
32			$tokens = $tokenizer->tokenize( $text );
33
34			$this->assertEquals(
35			$expected,
36			$tokens
37			);
38			}
39
40			public function textProvider() {
41
42			// https://en.wikipedia.org/wiki/Stop_words
43			$provider[] = array(
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-08-02 14:35 UTC by Report Bug Copy Issue Report `$provider` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$provider = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
44			'en',
45			'2',
46			//
47			'In computing, stop words are words which are filtered ...',
48			//
49			array(
50			0 => '_i',
51			1 => 'in',
52			2 => 'n_',
53			3 => '_c',
54			4 => 'co',
55			5 => 'om',
56			6 => 'mp',
57			7 => 'pu',
58			8 => 'ut',
59			9 => 'ti',
60			10 => 'in',
61			11 => 'ng',
62			12 => 'g_',
63			13 => '_s',
64			14 => 'st',
65			15 => 'to',
66			16 => 'op',
67			17 => 'p_',
68			18 => '_w',
69			19 => 'wo',
70			20 => 'or',
71			21 => 'rd',
72			22 => 'ds',
73			23 => 's_',
74			24 => '_a',
75			25 => 'ar',
76			26 => 're',
77			27 => 'e_',
78			28 => '_w',
79			29 => 'wo',
80			30 => 'or',
81			31 => 'rd',
82			32 => 'ds',
83			33 => 's_',
84			34 => '_w',
85			35 => 'wh',
86			36 => 'hi',
87			37 => 'ic',
88			38 => 'ch',
89			39 => 'h_',
90			40 => '_a',
91			41 => 'ar',
92			42 => 're',
93			43 => 'e_',
94			44 => '_f',
95			45 => 'fi',
96			46 => 'il',
97			47 => 'lt',
98			48 => 'te',
99			49 => 'er',
100			50 => 're',
101			51 => 'ed',
102			52 => 'd_',
103			)
104			);
105
106			return $provider;
107			}
108
109			}
110

onoi / tesa

Push — master ( 9401a4...2cc7a2 )

CombinedNGramTokenizerTest::textProvider() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like