onoi /
tesa
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 18 |
| Code Lines | 10 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 1 |
| 1 | <?php |
||
| 21 | public function testNgramWithBeginEndMarker( $languageCode, $ngramSize, $text, $expected ) { |
||
| 22 | |||
| 23 | $sanitizerFactory = new SanitizerFactory(); |
||
| 24 | |||
| 25 | $tokenizer = $sanitizerFactory->newNGramTokenizer( |
||
| 26 | $sanitizerFactory->newGenericRegExTokenizer() |
||
| 27 | ); |
||
| 28 | |||
| 29 | $tokenizer->withMarker( true ); |
||
| 30 | $tokenizer->setNgramSize( $ngramSize ); |
||
| 31 | |||
| 32 | $tokens = $tokenizer->tokenize( $text ); |
||
| 33 | |||
| 34 | $this->assertEquals( |
||
| 35 | $expected, |
||
| 36 | $tokens |
||
| 37 | ); |
||
| 38 | } |
||
| 39 | |||
| 110 |
Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.
Let’s take a look at an example:
As you can see in this example, the array
$myArrayis initialized the first time when the foreach loop is entered. You can also see that the value of thebarkey is only written conditionally; thus, its value might result from a previous iteration.This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.