Issues in PubMedCannedResponseParserTest.php (master) - Issues in master - onoi/remi - Measure and Improve Code Quality continuously with Scrutinizer

Issues (16)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Ncbi/PubMedCannedResponseParserTest.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Onoi\Remi\Tests\Integration\Ncbi;

use Onoi\Remi\FilteredHttpResponseParserFactory;
use Onoi\Remi\FilteredRecord;

/**
 * @group semantic-cite
 *
 * @license GNU GPL v2+
 * @since 0.1
 *
 * @author mwjames
 */
class PubMedCannedResponseParserTest extends \PHPUnit_Framework_TestCase {

	/**
	 * @dataProvider pmidFileProvider
	 */
	public function testPMIDParser( $id, $httpJsonRequestFile, $httpXmlRequestFile, $expectedResultFile ) {

		list( $id, $httpRequest, $jsonContents, $xmlContents, $expected ) = $this->prepareFileContents(
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
			$id,
			$httpJsonRequestFile,
			$httpXmlRequestFile,
			$expectedResultFile
		);

		$filteredHttpResponseParserFactory = new FilteredHttpResponseParserFactory(
			$httpRequest
		);

		$instance = $filteredHttpResponseParserFactory->newNcbiPubMedFilteredHttpResponseParser(
			new FilteredRecord()
		);

		$this->assertEquals(
			$jsonContents . $xmlContents,
			$instance->getRawResponseById( $id )

		);

		$instance->doFilterResponseById( $id );

		$this->assertJsonStringEqualsJsonFile(
			$expectedResultFile,
			$instance->getFilteredRecord()->asJsonString()
		);
	}

	/**
	 * @dataProvider pmcidFileProvider
	 */
	public function testPMCIDParser( $id, $httpJsonRequestFile, $httpXmlRequestFile, $expectedResultFile ) {

		list( $id, $httpRequest, $jsonContents, $xmlContents, $expected ) = $this->prepareFileContents(
<?php

function returnThreeValues() {
    return array('a', 'b', 'c');
}

list($a, $b, $c) = returnThreeValues();

print $a . " - " . $c;
			$id,
			$httpJsonRequestFile,
			$httpXmlRequestFile,
			$expectedResultFile
		);

		$FilteredHttpResponseParserFactory = new FilteredHttpResponseParserFactory(
			$httpRequest
		);

		$instance = $FilteredHttpResponseParserFactory->newNcbiPubMedCentralFilteredHttpResponseParser(
			new FilteredRecord()
		);

		$this->assertEquals(
			$jsonContents . $xmlContents,
			$instance->getRawResponseById( $id )

		);

		$instance->doFilterResponseById( $id );

		$this->assertJsonStringEqualsJsonFile(
			$expectedResultFile,
			$instance->getFilteredRecord()->asJsonString()
		);
	}

	private function prepareFileContents( $id, $httpJsonRequestFile, $httpXmlRequestFile, $expectedResultFile ) {

		$id = str_replace( array( 'PMID', 'PMC' ), '', $id );

		$jsonContents = file_get_contents( $httpJsonRequestFile );
		$xmlContents = file_get_contents( $httpXmlRequestFile );

		$httpRequest = $this->getMockBuilder( '\Onoi\HttpRequest\HttpRequest' )
			->disableOriginalConstructor()
			->getMock();

		$httpRequest->expects( $this->any() )
			->method( 'execute' )
			->will( $this->onConsecutiveCalls(
				$jsonContents, $xmlContents,
				$jsonContents, $xmlContents ) );

		$httpRequest->expects( $this->any() )
			->method( 'getLastError' )
			->will( $this->returnValue( '' ) );

		return array( $id, $httpRequest, $jsonContents, $xmlContents, $expectedResultFile );
	}

	public function pmidFileProvider() {

		$path = __DIR__ . '/Fixtures/';
		$provider = array();

		$provider[] = array(
			'PMID19782018',
			$path . 'PMID19782018.json',
			$path . 'PMID19782018.xml',
			$path . 'PMID19782018.expected'
		);

		return $provider;
	}

	public function pmcidFileProvider() {

		$path = __DIR__ . '/Fixtures/';
		$provider = array();

		$provider[] = array(
			'PMC2286209',
			$path . 'PMC2286209.json',
			$path . 'PMC2286209.xml',
			$path . 'PMC2286209.expected'
		);

		$provider[] = array(
			'PMC2776723',
			$path . 'PMC2776723.json',
			$path . 'PMC2776723.xml',
			$path . 'PMC2776723.expected'
		);

		$provider[] = array(
			'PMC5348191',
			$path . 'PMC5348191.json',
			$path . 'PMC5348191.xml',
			$path . 'PMC5348191.expected'
		);

		return $provider;
	}

}


1			<?php
2
3			namespace Onoi\Remi\Tests\Integration\Ncbi;
4
5			use Onoi\Remi\FilteredHttpResponseParserFactory;
6			use Onoi\Remi\FilteredRecord;
7
8			/**
9			* @group semantic-cite
10			*
11			* @license GNU GPL v2+
12			* @since 0.1
13			*
14			* @author mwjames
15			*/
16			class PubMedCannedResponseParserTest extends \PHPUnit_Framework_TestCase {
17
18			/**
19			* @dataProvider pmidFileProvider
20			*/
21			public function testPMIDParser( $id, $httpJsonRequestFile, $httpXmlRequestFile, $expectedResultFile ) {
22
23			list( $id, $httpRequest, $jsonContents, $xmlContents, $expected ) = $this->prepareFileContents(
			0 ignored issues – show Unused Code introduced 2016-09-21 02:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$expected` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
24			$id,
25			$httpJsonRequestFile,
26			$httpXmlRequestFile,
27			$expectedResultFile
28			);
29
30			$filteredHttpResponseParserFactory = new FilteredHttpResponseParserFactory(
31			$httpRequest
32			);
33
34			$instance = $filteredHttpResponseParserFactory->newNcbiPubMedFilteredHttpResponseParser(
35			new FilteredRecord()
36			);
37
38			$this->assertEquals(
39			$jsonContents . $xmlContents,
40			$instance->getRawResponseById( $id )
			0 ignored issues – show Bug introduced 2016-09-21 04:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getRawResponseById()` does not exist on `Onoi\Remi\ResponseParser`. Did you maybe mean `getRawResponse()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
41			);
42
43			$instance->doFilterResponseById( $id );
44
45			$this->assertJsonStringEqualsJsonFile(
46			$expectedResultFile,
47			$instance->getFilteredRecord()->asJsonString()
48			);
49			}
50
51			/**
52			* @dataProvider pmcidFileProvider
53			*/
54			public function testPMCIDParser( $id, $httpJsonRequestFile, $httpXmlRequestFile, $expectedResultFile ) {
55
56			list( $id, $httpRequest, $jsonContents, $xmlContents, $expected ) = $this->prepareFileContents(
			0 ignored issues – show Unused Code introduced 2016-09-21 02:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$expected` is unused. Consider omitting it like so `list($first,,$third)`. This checks looks for assignemnts to variables using the `list(...)` function, where not all assigned variables are subsequently used. Consider the following code example. <?php function returnThreeValues() { return array('a', 'b', 'c'); } list($a, $b, $c) = returnThreeValues(); print $a . " - " . $c; Only the variables `$a` and `$c` are used. There was no need to assign `$b`. Instead, the list call could have been. list($a,, $c) = returnThreeValues(); Loading history...
57			$id,
58			$httpJsonRequestFile,
59			$httpXmlRequestFile,
60			$expectedResultFile
61			);
62
63			$FilteredHttpResponseParserFactory = new FilteredHttpResponseParserFactory(
64			$httpRequest
65			);
66
67			$instance = $FilteredHttpResponseParserFactory->newNcbiPubMedCentralFilteredHttpResponseParser(
68			new FilteredRecord()
69			);
70
71			$this->assertEquals(
72			$jsonContents . $xmlContents,
73			$instance->getRawResponseById( $id )
			0 ignored issues – show Bug introduced 2016-09-21 04:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getRawResponseById()` does not exist on `Onoi\Remi\ResponseParser`. Did you maybe mean `getRawResponse()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
74			);
75
76			$instance->doFilterResponseById( $id );
77
78			$this->assertJsonStringEqualsJsonFile(
79			$expectedResultFile,
80			$instance->getFilteredRecord()->asJsonString()
81			);
82			}
83
84			private function prepareFileContents( $id, $httpJsonRequestFile, $httpXmlRequestFile, $expectedResultFile ) {
85
86			$id = str_replace( array( 'PMID', 'PMC' ), '', $id );
87
88			$jsonContents = file_get_contents( $httpJsonRequestFile );
89			$xmlContents = file_get_contents( $httpXmlRequestFile );
90
91			$httpRequest = $this->getMockBuilder( '\Onoi\HttpRequest\HttpRequest' )
92			->disableOriginalConstructor()
93			->getMock();
94
95			$httpRequest->expects( $this->any() )
96			->method( 'execute' )
97			->will( $this->onConsecutiveCalls(
98			$jsonContents, $xmlContents,
99			$jsonContents, $xmlContents ) );
100
101			$httpRequest->expects( $this->any() )
102			->method( 'getLastError' )
103			->will( $this->returnValue( '' ) );
104
105			return array( $id, $httpRequest, $jsonContents, $xmlContents, $expectedResultFile );
106			}
107
108			public function pmidFileProvider() {
109
110			$path = __DIR__ . '/Fixtures/';
111			$provider = array();
112
113			$provider[] = array(
114			'PMID19782018',
115			$path . 'PMID19782018.json',
116			$path . 'PMID19782018.xml',
117			$path . 'PMID19782018.expected'
118			);
119
120			return $provider;
121			}
122
123			public function pmcidFileProvider() {
124
125			$path = __DIR__ . '/Fixtures/';
126			$provider = array();
127
128			$provider[] = array(
129			'PMC2286209',
130			$path . 'PMC2286209.json',
131			$path . 'PMC2286209.xml',
132			$path . 'PMC2286209.expected'
133			);
134
135			$provider[] = array(
136			'PMC2776723',
137			$path . 'PMC2776723.json',
138			$path . 'PMC2776723.xml',
139			$path . 'PMC2776723.expected'
140			);
141
142			$provider[] = array(
143			'PMC5348191',
144			$path . 'PMC5348191.json',
145			$path . 'PMC5348191.xml',
146			$path . 'PMC5348191.expected'
147			);
148
149			return $provider;
150			}
151
152			}
153

onoi / remi

Issues (16)

Security Analysis no request data

Ncbi/PubMedCannedResponseParserTest.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like