Issues in SocketRequestTest.php (master) - Issues in master - onoi/http-request - Measure and Improve Code Quality continuously with Scrutinizer

Issues (18)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/phpunit/Unit/SocketRequestTest.php (1 issue)

Labels

Unused Code 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Onoi\HttpRequest\Tests;

use Onoi\HttpRequest\SocketRequest;

/**
 * @covers \Onoi\HttpRequest\SocketRequest
 * @group onoi-http-request
 *
 * @license GNU GPL v2+
 * @since 1.1
 *
 * @author mwjames
 */
class SocketRequestTest extends \PHPUnit_Framework_TestCase {

	public function testCanConstruct() {

		$instance = new SocketRequest();

		$this->assertInstanceOf(
			'\Onoi\HttpRequest\SocketRequest',
			$instance
		);

		$this->assertInstanceOf(
			'\Onoi\HttpRequest\HttpRequest',
			$instance
		);
	}

	public function testPing() {

		$instance = new SocketRequest();

		$this->assertFalse(
			$instance->ping()
		);

		$instance->setOption( ONOI_HTTP_REQUEST_URL, 'http://example.org' );

		$this->assertInternalType(
			'boolean',
			$instance->ping()
		);
	}

	public function testExecute() {

		$instance = new SocketRequest();
		$instance->setOption( ONOI_HTTP_REQUEST_CONNECTION_TIMEOUT, 1 );
		$instance->setOption( ONOI_HTTP_REQUEST_URL, 'http://localhost:8888' );

		$this->assertInternalType(
			'boolean',
			$instance->execute()
		);
	}

	public function testGetLastError() {

		$instance = new SocketRequest();
		$instance->setOption( ONOI_HTTP_REQUEST_CONNECTION_TIMEOUT, 1 );

		$instance->execute();

		$this->assertInternalType(
			'string',
			$instance->getLastError()
		);
	}

	public function testGetLastErrorCode() {

		$instance = new SocketRequest();

		$this->assertInternalType(
			'integer',
			$instance->getLastErrorCode()
		);
	}

	public function testGetLastTransferInfo() {

		$instance = new SocketRequest();

		$this->assertInternalType(
			'string',
			$instance->getLastTransferInfo()
		);
	}

	public function testCallbackOnRequestNotCompleted() {

		$instance = new SocketRequest();
		$instance->setOption( ONOI_HTTP_REQUEST_CONNECTION_TIMEOUT, 0.1 );

		$requestResponse = null;

		$instance->setOption( ONOI_HTTP_REQUEST_ON_FAILED_CALLBACK, function( $requestResponseFailed ) use ( &$requestResponse ) {
			$requestResponse = $requestResponseFailed;
		} );

		$instance->execute();

		$this->assertRequestResponse( $requestResponse );
	}

	public function testCallbackOnRequestCompleted() {

		$url = 'http://localhost:8080/';

		$instance = new SocketRequest( $url );
		$instance->setOption( ONOI_HTTP_REQUEST_CONNECTION_TIMEOUT, 2 );
		$instance->setOption( ONOI_HTTP_REQUEST_METHOD, 'HEAD' );

		if ( !$instance->ping() ) {
			$this->markTestSkipped( "Skip test because {$url} was not reachable" );
		}

		$requestResponse = null;

		$instance->setOption( ONOI_HTTP_REQUEST_ON_COMPLETED_CALLBACK, function( $requestResponseCompleted ) use ( &$requestResponse ) {
			$requestResponse = $requestResponseCompleted;
		} );

		$instance->execute();

		$this->assertRequestResponse( $requestResponse );
	}

	public function testTryInvalidCallbackOnRequestCompleted() {

		$instance = new SocketRequest();

		$instance->setOption( ONOI_HTTP_REQUEST_CONNECTION_TIMEOUT, 0.1 );
		$instance->setOption( ONOI_HTTP_REQUEST_ON_COMPLETED_CALLBACK, 'foo' );

		$this->assertFalse(
			$instance->execute()
		);
	}

	public function testCallbackOnRequestFailed() {

		$instance = new SocketRequest();
		$instance->setOption( ONOI_HTTP_REQUEST_CONNECTION_TIMEOUT, 0.1 );

		$requestResponse = null;

		$instance->setOption( ONOI_HTTP_REQUEST_ON_FAILED_CALLBACK, function( $requestResponseFailed ) use ( &$requestResponse ) {
			$requestResponse = $requestResponseFailed;
		} );

		$instance->execute();

		$this->assertRequestResponse( $requestResponse );
	}

	public function testCallbackOnRequestNotAccepted() {

		$instance = new SocketRequest();
		$instance->setOption( ONOI_HTTP_REQUEST_CONNECTION_TIMEOUT, 2 );

		$instance->ping();

		$requestResponse = null;

		$instance->setOption( ONOI_HTTP_REQUEST_ON_FAILED_CALLBACK, function( $requestResponseFailed ) use ( &$requestResponse ) {
			$requestResponse = $requestResponseFailed;
		} );

		$instance->execute();
		$this->assertRequestResponse( $requestResponse );
	}

	private function assertRequestResponse( $requestResponse ) {

		$this->assertInstanceOf(
			'\Onoi\HttpRequest\RequestResponse',
			$requestResponse
		);

		$expectedRequestResponseFields = array(
			'wasCompleted',
			'responseMessage',
			'host',
			'port',
			'path',
			'connectionFailure',
			'requestProcTime'
		);

		foreach ( $expectedRequestResponseFields as $field ) {
			$this->assertTrue( $requestResponse->has( $field ), 'Failed for ' . $field );
		}
	}

	public function testDefinedConstants() {

		$constants = array(
			'ONOI_HTTP_REQUEST_ON_FAILED_CALLBACK',
			'ONOI_HTTP_REQUEST_ON_COMPLETED_CALLBACK',
			'ONOI_HTTP_REQUEST_SOCKET_CLIENT_FLAGS',
			'ONOI_HTTP_REQUEST_URL',
			'ONOI_HTTP_REQUEST_CONNECTION_TIMEOUT',
			'ONOI_HTTP_REQUEST_CONNECTION_FAILURE_REPEAT',
			'ONOI_HTTP_REQUEST_CONTENT',
			'ONOI_HTTP_REQUEST_CONTENT_TYPE',
			'ONOI_HTTP_REQUEST_METHOD',
			'ONOI_HTTP_REQUEST_PROTOCOL_VERSION',
			'ONOI_HTTP_REQUEST_SSL_VERIFYPEER',
			'ONOI_HTTP_REQUEST_FOLLOWLOCATION'
		);

		$instance = new SocketRequest();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

		foreach ( $constants as $constant ) {
			$this->assertTrue( defined( $constant ) );
		}
	}

}


1			<?php
2
3			namespace Onoi\HttpRequest\Tests;
4
5			use Onoi\HttpRequest\SocketRequest;
6
7			/**
8			* @covers \Onoi\HttpRequest\SocketRequest
9			* @group onoi-http-request
10			*
11			* @license GNU GPL v2+
12			* @since 1.1
13			*
14			* @author mwjames
15			*/
16			class SocketRequestTest extends \PHPUnit_Framework_TestCase {
17
18			public function testCanConstruct() {
19
20			$instance = new SocketRequest();
21
22			$this->assertInstanceOf(
23			'\Onoi\HttpRequest\SocketRequest',
24			$instance
25			);
26
27			$this->assertInstanceOf(
28			'\Onoi\HttpRequest\HttpRequest',
29			$instance
30			);
31			}
32
33			public function testPing() {
34
35			$instance = new SocketRequest();
36
37			$this->assertFalse(
38			$instance->ping()
39			);
40
41			$instance->setOption( ONOI_HTTP_REQUEST_URL, 'http://example.org' );
42
43			$this->assertInternalType(
44			'boolean',
45			$instance->ping()
46			);
47			}
48
49			public function testExecute() {
50
51			$instance = new SocketRequest();
52			$instance->setOption( ONOI_HTTP_REQUEST_CONNECTION_TIMEOUT, 1 );
53			$instance->setOption( ONOI_HTTP_REQUEST_URL, 'http://localhost:8888' );
54
55			$this->assertInternalType(
56			'boolean',
57			$instance->execute()
58			);
59			}
60
61			public function testGetLastError() {
62
63			$instance = new SocketRequest();
64			$instance->setOption( ONOI_HTTP_REQUEST_CONNECTION_TIMEOUT, 1 );
65
66			$instance->execute();
67
68			$this->assertInternalType(
69			'string',
70			$instance->getLastError()
71			);
72			}
73
74			public function testGetLastErrorCode() {
75
76			$instance = new SocketRequest();
77
78			$this->assertInternalType(
79			'integer',
80			$instance->getLastErrorCode()
81			);
82			}
83
84			public function testGetLastTransferInfo() {
85
86			$instance = new SocketRequest();
87
88			$this->assertInternalType(
89			'string',
90			$instance->getLastTransferInfo()
91			);
92			}
93
94			public function testCallbackOnRequestNotCompleted() {
95
96			$instance = new SocketRequest();
97			$instance->setOption( ONOI_HTTP_REQUEST_CONNECTION_TIMEOUT, 0.1 );
98
99			$requestResponse = null;
100
101			$instance->setOption( ONOI_HTTP_REQUEST_ON_FAILED_CALLBACK, function( $requestResponseFailed ) use ( &$requestResponse ) {
102			$requestResponse = $requestResponseFailed;
103			} );
104
105			$instance->execute();
106
107			$this->assertRequestResponse( $requestResponse );
108			}
109
110			public function testCallbackOnRequestCompleted() {
111
112			$url = 'http://localhost:8080/';
113
114			$instance = new SocketRequest( $url );
115			$instance->setOption( ONOI_HTTP_REQUEST_CONNECTION_TIMEOUT, 2 );
116			$instance->setOption( ONOI_HTTP_REQUEST_METHOD, 'HEAD' );
117
118			if ( !$instance->ping() ) {
119			$this->markTestSkipped( "Skip test because {$url} was not reachable" );
120			}
121
122			$requestResponse = null;
123
124			$instance->setOption( ONOI_HTTP_REQUEST_ON_COMPLETED_CALLBACK, function( $requestResponseCompleted ) use ( &$requestResponse ) {
125			$requestResponse = $requestResponseCompleted;
126			} );
127
128			$instance->execute();
129
130			$this->assertRequestResponse( $requestResponse );
131			}
132
133			public function testTryInvalidCallbackOnRequestCompleted() {
134
135			$instance = new SocketRequest();
136
137			$instance->setOption( ONOI_HTTP_REQUEST_CONNECTION_TIMEOUT, 0.1 );
138			$instance->setOption( ONOI_HTTP_REQUEST_ON_COMPLETED_CALLBACK, 'foo' );
139
140			$this->assertFalse(
141			$instance->execute()
142			);
143			}
144
145			public function testCallbackOnRequestFailed() {
146
147			$instance = new SocketRequest();
148			$instance->setOption( ONOI_HTTP_REQUEST_CONNECTION_TIMEOUT, 0.1 );
149
150			$requestResponse = null;
151
152			$instance->setOption( ONOI_HTTP_REQUEST_ON_FAILED_CALLBACK, function( $requestResponseFailed ) use ( &$requestResponse ) {
153			$requestResponse = $requestResponseFailed;
154			} );
155
156			$instance->execute();
157
158			$this->assertRequestResponse( $requestResponse );
159			}
160
161			public function testCallbackOnRequestNotAccepted() {
162
163			$instance = new SocketRequest();
164			$instance->setOption( ONOI_HTTP_REQUEST_CONNECTION_TIMEOUT, 2 );
165
166			$instance->ping();
167
168			$requestResponse = null;
169
170			$instance->setOption( ONOI_HTTP_REQUEST_ON_FAILED_CALLBACK, function( $requestResponseFailed ) use ( &$requestResponse ) {
171			$requestResponse = $requestResponseFailed;
172			} );
173
174			$instance->execute();
175			$this->assertRequestResponse( $requestResponse );
176			}
177
178			private function assertRequestResponse( $requestResponse ) {
179
180			$this->assertInstanceOf(
181			'\Onoi\HttpRequest\RequestResponse',
182			$requestResponse
183			);
184
185			$expectedRequestResponseFields = array(
186			'wasCompleted',
187			'responseMessage',
188			'host',
189			'port',
190			'path',
191			'connectionFailure',
192			'requestProcTime'
193			);
194
195			foreach ( $expectedRequestResponseFields as $field ) {
196			$this->assertTrue( $requestResponse->has( $field ), 'Failed for ' . $field );
197			}
198			}
199
200			public function testDefinedConstants() {
201
202			$constants = array(
203			'ONOI_HTTP_REQUEST_ON_FAILED_CALLBACK',
204			'ONOI_HTTP_REQUEST_ON_COMPLETED_CALLBACK',
205			'ONOI_HTTP_REQUEST_SOCKET_CLIENT_FLAGS',
206			'ONOI_HTTP_REQUEST_URL',
207			'ONOI_HTTP_REQUEST_CONNECTION_TIMEOUT',
208			'ONOI_HTTP_REQUEST_CONNECTION_FAILURE_REPEAT',
209			'ONOI_HTTP_REQUEST_CONTENT',
210			'ONOI_HTTP_REQUEST_CONTENT_TYPE',
211			'ONOI_HTTP_REQUEST_METHOD',
212			'ONOI_HTTP_REQUEST_PROTOCOL_VERSION',
213			'ONOI_HTTP_REQUEST_SSL_VERIFYPEER',
214			'ONOI_HTTP_REQUEST_FOLLOWLOCATION'
215			);
216
217			$instance = new SocketRequest();
			0 ignored issues – show Unused Code introduced 2015-11-23 12:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$instance` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
218
219			foreach ( $constants as $constant ) {
220			$this->assertTrue( defined( $constant ) );
221			}
222			}
223
224			}
225

onoi / http-request

Issues (18)

Security Analysis not enabled

tests/phpunit/Unit/SocketRequestTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like